commit 00ef1f0dc8449b19e42da4e9cf81323e1ce262ca Author: Travis Reitter Date: Mon Jan 31 09:23:09 2011 -0800 Release version 0.3.4 configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit abe8b43df9eca686f9f48b4c0491c98c49f805a0 Author: Travis Reitter Date: Mon Jan 31 11:48:29 2011 -0800 Write inlined docs for LinkedHashSet to work around bgo#629531 folks/linked-hash-set.vala | 121 ++++++++++++++++++++++++++++++++++++++------ 1 files changed, 106 insertions(+), 15 deletions(-) commit 34a5c1c8a7aa2d167430c7ac8d867ec629beda5a Author: Travis Reitter Date: Mon Jan 31 09:49:06 2011 -0800 Update old doc link to PresenceOwner. folks/imable.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit c4ce8560e3d33ed93d814dec7829e81bb3fa3e7c Author: Travis Reitter Date: Mon Jan 31 09:36:29 2011 -0800 Don't use deprecated string.ndup function. folks/persona.vala | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit a77a239c0dbf87c9ca47a8c7a4a60c59e34a51d0 Author: Travis Reitter Date: Mon Jan 31 09:07:36 2011 -0800 Set @since lines for new release. folks/imable.vala | 2 +- folks/linked-hash-set.vala | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) commit e33efba685d61525b7490d44abc22c5f6b13d02b Author: Travis Reitter Date: Mon Jan 31 08:58:52 2011 -0800 Cut obsolete comment about IMable.im_addresses. folks/imable.vala | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) commit 6d04aa8c96c1950df93fffa9acd8b0006dfeef50 Author: Travis Reitter Date: Mon Jan 31 08:57:34 2011 -0800 Add a note about LinkedHashSet pulling in libgee. NEWS | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 66d30bcbfb342e3baee6e64ac6dd26af7d4ac7b7 Author: Travis Reitter Date: Mon Jan 31 08:54:04 2011 -0800 Combine the API changes sections in NEWS. NEWS | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) commit c23b3188ce02466e386828f03578383b6e10dafb Author: Travis Reitter Date: Fri Jan 28 14:05:14 2011 -0800 Make the TestCase class follow our coding style. tests/lib/test-case.vala | 175 ++++++++++++++++++++++++---------------------- 1 files changed, 92 insertions(+), 83 deletions(-) commit cea73b98512bb82a81b67fc1bbbf147543c8f046 Author: Travis Reitter Date: Wed Dec 22 18:52:55 2010 -0800 Rename HasPresence -> PresenceOwner. Fixes bgo#627397. NEWS | 2 + backends/telepathy/lib/tpf-persona.vala | 6 +- folks/Makefile.am | 2 +- folks/has-presence.vala | 161 --------------------------- folks/individual.vala | 8 +- folks/presence-owner.vala | 162 ++++++++++++++++++++++++++++ tests/telepathy/individual-properties.vala | 2 +- 7 files changed, 173 insertions(+), 170 deletions(-) commit d80e62a4502e67971655bfefcaf91849654cc15d Author: Travis Reitter Date: Wed Dec 22 18:07:15 2010 -0800 Rename HasAvatar -> AvatarOwner. Helps bgo#627397. NEWS | 3 ++ backends/telepathy/lib/tpf-persona.vala | 4 +- folks/Makefile.am | 2 +- folks/avatar-owner.vala | 36 +++++++++++++++++++++++++++++++ folks/has-avatar.vala | 36 ------------------------------- folks/individual.vala | 6 ++-- 6 files changed, 45 insertions(+), 42 deletions(-) commit f9f7d793f74ba34c78454074c64343762db11919 Author: Travis Reitter Date: Mon Jan 24 21:11:57 2011 -0800 Add a simple test case to reproduce bgo#640551 when valgrind-ing. tests/folks/linked-hash-set.vala | 42 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 42 insertions(+), 0 deletions(-) commit 797b08434b1d3429cf66eced1dcd8c7d90304e90 Author: Travis Reitter Date: Fri Jan 21 11:08:44 2011 -0800 Add some LinkedHashSet tests. Fixes bgo#640213 -- Add tests for LinkedHashSet NEWS | 1 + tests/folks/Makefile.am | 6 + tests/folks/linked-hash-set.vala | 254 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 261 insertions(+), 0 deletions(-) commit 14b8da134abffcf0272c06c72d5f6df6036e06e7 Author: Eitan Isaacson Date: Sun Jan 16 11:48:24 2011 +0200 Modified backends to use LinkedHashSet in IMable.im_addresses. backends/key-file/kf-persona-store.vala | 4 +- backends/key-file/kf-persona.vala | 75 ++++++++++++------------------- backends/telepathy/lib/tpf-persona.vala | 12 +++--- 3 files changed, 37 insertions(+), 54 deletions(-) commit f1f826688cfec808d98bf3e588735812cde6160c Author: Eitan Isaacson Date: Sun Jan 16 11:47:50 2011 +0200 Modified libfolks to use LinkedHashSet in im_addresses. NEWS | 1 + folks/imable.vala | 4 ++-- folks/individual-aggregator.vala | 34 ++++++++-------------------------- folks/individual.vala | 29 +++++++++-------------------- 4 files changed, 20 insertions(+), 48 deletions(-) commit da5e0d35d5800bb03ff1e0818c1b51f4284e7c76 Author: Eitan Isaacson Date: Sun Jan 16 11:46:27 2011 +0200 Added a LinkedHashSet ordered set. NEWS | 3 + folks/Makefile.am | 1 + folks/linked-hash-set.vala | 203 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 207 insertions(+), 0 deletions(-) commit 052ce5b471e057aa5f0478e5d605ffacbcbb1e5b Author: Travis Reitter Date: Mon Jan 17 11:37:55 2011 -0800 Suppress Telepathy logger warning for tests. Fixes bgo#639742 - Logger service unavailable in make check NEWS | 1 + tests/lib/telepathy/contactlist/backend.c | 34 +++++++++++++++++++++------- 2 files changed, 26 insertions(+), 9 deletions(-) commit 4b9b2220056ca6e480a28fc3cb4e224d8fc98856 Author: Travis Reitter Date: Mon Jan 17 12:03:16 2011 -0800 Only spew D-Bus info during tests if >= 1 tests/tools/with-session-bus.sh | 25 +++++++++++++++++++++---- 1 files changed, 21 insertions(+), 4 deletions(-) commit b263b1f6fd009d2ed96ef6eb36f2f795a41b6182 Author: Travis Reitter Date: Mon Jan 17 11:42:11 2011 -0800 Silence generally-useless Tp test message. .../telepathy/contactlist/contact-list-manager.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) commit 642b15a9e7662623d1af815595e127cda7dd991c Author: Philip Withnall Date: Mon Jan 17 22:02:55 2011 +0000 Don't add a duplicate candidate individual if one matches by user and IID If an individual matches a persona being aggregated both by them both being the user, and by IID match, don't list the individual as a candidate individual twice (which would cause their personas to appear twice in the final individual). folks/individual-aggregator.vala | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 5f6b4ee0522dfbac090838498f50b93bbaf2e8c6 Author: Eitan Isaacson Date: Wed Jan 12 22:51:12 2011 +0200 Added valgrind support in make check. https://bugzilla.gnome.org/show_bug.cgi?id=639366 tests/folks/Makefile.am | 1 + tests/folks/aggregation.vala | 14 +++++++++----- tests/key-file/Makefile.am | 1 + tests/key-file/individual-retrieval.vala | 8 ++++++-- tests/telepathy/Makefile.am | 1 + tests/telepathy/individual-properties.vala | 10 +++++++--- tests/telepathy/individual-retrieval.vala | 8 ++++++-- tests/telepathy/persona-store-capabilities.vala | 6 +++++- valgrind.mk | 18 ++++++++++++++++++ 9 files changed, 54 insertions(+), 13 deletions(-) commit 053d6482edea8d1b9b36d121b6ae67c0d29af17f Author: Travis Reitter Date: Fri Jan 14 09:47:01 2011 -0800 Add policy for keeping the build healthy. HACKING | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) commit 941e7957329dedd8bdf84f5f55aa1353f57b54d5 Author: Travis Reitter Date: Thu Jan 13 16:04:21 2011 -0800 Finish catching BackendStore up to our coding style. folks/backend-store.vala | 46 +++++++++++++++++++++++----------------------- 1 files changed, 23 insertions(+), 23 deletions(-) commit 3deac065cfeab4f3229bbea5c256d2083e0567ad Author: Travis Reitter Date: Wed Jan 12 17:27:37 2011 -0800 Fix dependencies for internal g-i files. As it was, these libraries wouldn't be re-created after a maintainer-clean (or on the very first build). backends/telepathy/lib/Makefile.am | 4 ++-- tests/lib/telepathy/contactlist/Makefile.am | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) commit 291584d75f98cc42d89c0cf2f96381f27bc81a38 Author: Travis Reitter Date: Wed Jan 12 15:55:57 2011 -0800 Also print a stack trace upon a failed test assertion. tests/lib/test-case.vala | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) commit 5d31cf24220502f6725815d7e6f9d317bba9bb35 Author: Travis Reitter Date: Wed Jan 12 11:44:07 2011 -0800 Don't double-list files in MAINTAINERCLEANFILES. tests/lib/telepathy/contactlist/Makefile.am | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) commit 18c884702b57279866c51922861c77878b8b415c Author: Travis Reitter Date: Tue Jan 11 17:26:01 2011 -0800 Distribute sources for generated files. This un-breaks distcheck by ensuring the generated files don't stick around in _build after the final distclean. This fulfills the requirements laid out in the Automake manual page: http://www.gnu.org/software/hello/manual/automake/distcleancheck.html backends/telepathy/lib/Makefile.am | 4 +++- tests/lib/telepathy/contactlist/Makefile.am | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) commit 14114584c54b145aefa0e892efd9c7f3fd63a8b0 Author: Travis Reitter Date: Tue Jan 11 16:30:56 2011 -0800 Define the Telepathy BACKEND_NAME directly. Properly distributing the backend.mk file proved more difficult than it was worth (it was breaking 'make check' during distcheck), so we've reverted to direct definition. backends/telepathy/Makefile.am | 3 ++- backends/telepathy/backend.mk | 1 - backends/telepathy/lib/Makefile.am | 11 ++++++++--- tests/folks/backend-loading.vala | 1 + 4 files changed, 11 insertions(+), 5 deletions(-) commit d02e7f72faafc1c50f63d9b33c6daa4ee25c9ccc Author: Travis Reitter Date: Tue Jan 11 15:01:45 2011 -0800 Force Vala for non-release builds. This should make buildbot builds a little more consistent. configure.ac | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) commit f4bba6dc4f26cbebc8d944a3eb93ce9bc5884c6e Author: Travis Reitter Date: Tue Jan 11 14:30:16 2011 -0800 Add Vala requirement checks for newer tests. configure.ac | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit f3917b1e8f279ec255cee96c210c74e882da754b Author: Philip Withnall Date: Mon Jan 10 00:30:13 2011 +0000 Bug 639113 — Add static aggregation tests Add some tests which cover several of the ways which personas can be statically aggregated at present. These tests are “static” (as opposed to “dynamic”) because they don't change the inputs to the aggregator after it's been prepared. Consequently, they don't cover much of the interesting and bug-prone behaviour of the aggregator. Still, they're a start. Closes: bgo#639113 NEWS | 1 + tests/folks/Makefile.am | 22 +- tests/folks/aggregation.vala | 653 +++++++++++++++++++++++++++++ tests/folks/backend-loading.vala | 11 + tests/lib/telepathy/contactlist/backend.c | 8 + 5 files changed, 694 insertions(+), 1 deletions(-) commit 39bf15f146f6ec29010b8d71330a98809c097d6a Author: Travis Reitter Date: Tue Jan 11 11:31:10 2011 -0800 Don't announce removal of Individuals twice. Before this patch, we would announce an Individual's removal, "dispose" of the individual, then announce their removal again (at which point they would have zero Personas, which can make it harder for clients to do anything useful with the notification anyhow). Helps: bgo#639113 folks/individual-aggregator.vala | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit b81e26d48507e7fd61b26c9732fb67b150593e20 Author: Philip Withnall Date: Sun Jan 9 21:52:54 2011 +0000 Allow multiple test accounts to be connected simultaneously This doesn't affect any existing tests, but will be useful for testing that aggregation across different persona stores works correctly. tests/lib/telepathy/contactlist/account-manager.c | 50 ++++++- tests/lib/telepathy/contactlist/account-manager.h | 5 + tests/lib/telepathy/contactlist/backend.c | 152 +++++++++++++++------ tests/lib/telepathy/contactlist/backend.h | 8 + tests/telepathy/individual-properties.vala | 4 + tests/telepathy/individual-retrieval.vala | 4 + tests/telepathy/persona-store-capabilities.vala | 4 + 7 files changed, 178 insertions(+), 49 deletions(-) commit fb335d6e40ad765ce9da55909ffe7f7464921423 Author: Travis Reitter Date: Mon Jan 10 21:59:39 2011 -0800 Override the test log handler for Telepathy tests. This avoids aborting and printing unnecessary stack traces for the well-known Telepathy-logger warning message. Fixes bgo#639195 - Print stack traces for failed tests to improve remote debugging NEWS | 2 ++ tests/lib/telepathy/contactlist/backend.c | 13 +++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) commit 9a539691a07feb1dcb7197b1acceb4fcef7582de Author: Travis Reitter Date: Mon Jan 10 16:50:27 2011 -0800 Factor Tp logger warning out of Tp tests. Helps bgo#639195 - Print stack traces for failed tests to improve remote debugging tests/lib/telepathy/contactlist/backend.c | 14 ++++++++++++++ tests/telepathy/individual-properties.vala | 21 --------------------- tests/telepathy/individual-retrieval.vala | 14 -------------- tests/telepathy/persona-store-capabilities.vala | 7 ------- 4 files changed, 14 insertions(+), 42 deletions(-) commit 56c99d93af9191ed47cb05d0daec8c11ed060ad7 Author: Travis Reitter Date: Mon Jan 10 16:40:14 2011 -0800 When a test would print a message >= warning, print a stack trace. This is largely to benefit remote debugging of build bots but also makes debugging test errors easier. Helps bgo#639195 - Print stack traces for failed tests to improve remote debugging tests/lib/test-case.vala | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) commit 38672fd3e8c8001099a4d1451a16f26ab71337ab Author: Travis Reitter Date: Mon Jan 10 16:10:41 2011 -0800 Cut unnecessary log handler for key-file test. Helps bgo#639195 - Print stack traces for failed tests to improve remote debugging tests/key-file/individual-retrieval.vala | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) commit 10696ef6563db92c8b927eb36011dba19cec7b17 Author: Travis Reitter Date: Mon Jan 10 14:44:39 2011 -0800 Cut unnecessary Tp log handler for the general test. Helps bgo#639195 - Print stack traces for failed tests to improve remote debugging tests/folks/backend-loading.vala | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) commit b4b63b8e706b87fd2b927a1b930024803411075e Author: Travis Reitter Date: Thu Jan 6 15:48:08 2011 -0800 Note the fix of bgo#638609 in the NEWS NEWS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit cfdd138a035c6aa13889660852e13b2fb458dbd5 Author: Travis Reitter Date: Thu Jan 6 15:39:20 2011 -0800 Register core debugging as global G_LOG_DOMAIN to reduce magic strings. Fixes bgo#638609 - libfolks hard-codes backend names for debugging folks/backend-store.vala | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit cf95d8dcce95840188c510d0f1cfe78af7a44ecc Author: Travis Reitter Date: Tue Jan 4 12:19:27 2011 -0800 Pin backends' names to global BACKEND_NAME to reduce magic strings. Helps bgo#638609 - libfolks hard-codes backend names for debugging backends/key-file/Makefile.am | 5 ++++- backends/key-file/kf-backend.vala | 4 +++- backends/key-file/kf-persona-store.vala | 2 +- backends/telepathy/Makefile.am | 4 +++- backends/telepathy/backend.mk | 1 + backends/telepathy/lib/Makefile.am | 4 +++- backends/telepathy/lib/tpf-persona-store.vala | 5 +++-- backends/telepathy/tp-backend.vala | 4 +++- 8 files changed, 21 insertions(+), 8 deletions(-) commit efe8d5d6dd1497f4a23bb27323901dabb9a6406f Author: Travis Reitter Date: Tue Jan 4 10:58:15 2011 -0800 Make the main debug domain 'folks' to match the backends. Helps bgo#638609 - libfolks hard-codes backend names for debugging folks/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 7b39b7188be6bf37925f76615c9004c5151e543c Author: Travis Reitter Date: Tue Jan 4 10:51:49 2011 -0800 Make the backends' log domains match their type_id. Helps bgo#638609 - libfolks hard-codes backend names for debugging backends/key-file/Makefile.am | 2 +- backends/telepathy/Makefile.am | 2 +- backends/telepathy/lib/Makefile.am | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit e962ee0505a30b89e143a87db7fcfec4c31b1ee7 Author: Travis Reitter Date: Tue Jan 4 11:26:34 2011 -0800 Push flag setting into the Debug constructor. Helps bgo#638609 - libfolks hard-codes backend names for debugging folks/backend-store.vala | 5 +-- folks/debug.vala | 49 +++++++++++++++++++++------------------------ 2 files changed, 25 insertions(+), 29 deletions(-) commit 74966cd86b4b213eaad81bcb5c8d5a2738ba1f8c Author: Travis Reitter Date: Tue Jan 4 10:54:01 2011 -0800 Add new API for setting debugging levels. Helps bgo#638609 - libfolks hard-codes backend names for debugging folks/backend-store.vala | 9 ++++++- folks/debug.vala | 49 +++++++++++++++++++++++++++++---------------- 2 files changed, 38 insertions(+), 20 deletions(-) commit 26f43d1aeeadf48a23cf6fb29d7900720fd4a6ea Author: Travis Reitter Date: Mon Jan 3 16:23:05 2011 -0800 Make Folks.Debug a class so we can store state. Helps bgo#638609 - libfolks hard-codes backend names for debugging folks/backend-store.vala | 4 +++- folks/debug.vala | 27 +++++++++++++++++++++++++-- 2 files changed, 28 insertions(+), 3 deletions(-) commit c04e2f11290abf229e188901cd21430b4ae32314 Author: Travis Reitter Date: Mon Jan 3 14:15:58 2011 -0800 Don't use a magic string in the Tp backend. backends/telepathy/lib/tpf-persona.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 7cf015416c26cb840f52d800a17d9394c921bbc8 Author: Travis Reitter Date: Mon Jan 3 13:29:06 2011 -0800 Add a comment for bgo#638609 - backend debug hard-coding folks/debug.vala | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 8b2e847d2a9c9b78e095f8dff7f5f20e4db00df9 Author: Philip Withnall Date: Fri Dec 31 14:23:31 2010 +0000 Bug 638395 — folks-inspect prevents default Vala-free builds Add notices and errors to the configure script to notify the user of why the inspect tool is not being built. Closes: bgo#638395 configure.ac | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit 5655e72bef34eb0308ecd3624d458bf069930c2f Author: Philip Withnall Date: Fri Dec 31 14:21:11 2010 +0000 Add a missing backslash to the configure.ac file configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 697a12646bd7d25c68c3042f13b3b9e323427262 Author: Travis Reitter Date: Thu Dec 30 23:19:31 2010 -0800 Don't break the build if building folks-inspect without Vala configure.ac | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) commit 0f65abfa48d5f615419a871a726ca38d9cb3c76b Author: Philip Withnall Date: Thu Dec 30 17:59:37 2010 +0000 Fix some variable names in the inspector signal parsing code See: https://bugzilla.gnome.org/show_bug.cgi?id=629075#c8 tools/inspect/command-signals.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 96b1a7b28989b50cc0bb2241ece5889a2b7fb0cf Author: Philip Withnall Date: Mon Sep 6 19:38:21 2010 +0100 Bug 629075 — Add folks command line application Add an interactive command line inspection utility for libfolks. Closes: bgo#629075. NEWS | 4 + configure.ac | 21 ++ tools/Makefile.am | 8 + tools/inspect/Makefile.am | 40 +++ tools/inspect/command-backends.vala | 102 ++++++ tools/inspect/command-help.vala | 89 +++++ tools/inspect/command-individuals.vala | 90 +++++ tools/inspect/command-persona-stores.vala | 107 ++++++ tools/inspect/command-personas.vala | 81 +++++ tools/inspect/command-quit.vala | 57 ++++ tools/inspect/command-signals.vala | 250 ++++++++++++++ tools/inspect/inspect.vala | 223 +++++++++++++ tools/inspect/signal-manager.vala | 502 +++++++++++++++++++++++++++++ tools/inspect/utils.vala | 477 +++++++++++++++++++++++++++ 14 files changed, 2051 insertions(+), 0 deletions(-) commit 98772a1dce8cf8d47c6a1c942e42dafaa156a700 Author: Travis Reitter Date: Thu Dec 30 09:23:31 2010 -0800 Add NEWS entry for bgo#629083 fix NEWS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit ac6e49d352728a089708afebf73e018b5f722e6d Author: Travis Reitter Date: Thu Dec 30 09:22:24 2010 -0800 Add NEWS entry for bgo#638311 fix NEWS | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit dc3acdfca04a03f00f0fb04d375fa6946145ce4b Author: Travis Reitter Date: Tue Dec 28 17:21:53 2010 -0800 Refer to non-local variables and methods with full name. The benefit here is to make it easier to tell when variables are local. Methods are referred to similarly for consistency. Fixes bgo#629083 HACKING | 6 ++++ backends/telepathy/lib/tpf-persona-store.vala | 32 ++++++++++++++----------- backends/telepathy/lib/tpf-persona.vala | 6 ++-- folks/backend-store.vala | 2 +- folks/has-presence.vala | 3 +- folks/individual-aggregator.vala | 2 +- 6 files changed, 31 insertions(+), 20 deletions(-) commit 6aa04aae7ffda13afe2654a8a3e6b1d9c42c4ff3 Author: Travis Reitter Date: Tue Dec 28 16:58:34 2010 -0800 Cut unnecessary casting. Excessive casting can hide real compiler warnings/errors and is best avoided. Helps bgo#629083 HACKING | 3 +++ backends/key-file/kf-persona.vala | 3 +-- folks/has-presence.vala | 5 ++--- folks/individual-aggregator.vala | 12 +++++------- 4 files changed, 11 insertions(+), 12 deletions(-) commit 7668bd500b5e6739da2b1e583df5265b0ba2b399 Author: Travis Reitter Date: Tue Dec 28 09:15:23 2010 -0800 Maximize use of 'unowned' keyword. This is used when (and only when) variables: 1. would avoid a non-trivial copy (eg, a string or array but not an int or object ref-count increase) AND 2. will only be assigned unowned values (excessive use of 'unowned' here will be caught by the compiler) The net benefit is avoiding unecessary memory allocation/freeing. Helps bgo#629083 HACKING | 9 +++++++++ backends/key-file/kf-backend.vala | 2 +- backends/key-file/kf-persona.vala | 4 ++-- backends/telepathy/lib/tpf-persona-store.vala | 9 +++++---- backends/telepathy/lib/tpf-persona.vala | 4 ++-- folks/backend-store.vala | 5 +++-- folks/individual-aggregator.vala | 8 ++++---- folks/individual.vala | 8 ++++---- 8 files changed, 30 insertions(+), 19 deletions(-) commit b93b4445e87bc645c1b6c1425deb17a99c27304c Author: Travis Reitter Date: Mon Dec 27 17:22:21 2010 -0800 Maximize use of the 'var' keyword. This is used whenever a variable: 1. is declared and initialized in the same line AND 2. would not avoid a copy by using the 'unowned'. In the future, we may be able to declare variables 'unowned var', in which case this point won't matter. See bgo#638199. The net benefit is less noise on variable declaration lines. Helps bgo#629083 HACKING | 6 ++ backends/key-file/kf-backend.vala | 2 +- backends/key-file/kf-persona-store.vala | 12 ++-- backends/key-file/kf-persona.vala | 25 ++++---- backends/telepathy/lib/tpf-persona-store.vala | 35 ++++++----- backends/telepathy/lib/tpf-persona.vala | 6 +- backends/telepathy/tp-backend.vala | 3 +- folks/backend-store.vala | 33 +++++----- folks/debug.vala | 2 +- folks/individual-aggregator.vala | 80 ++++++++++++------------- folks/individual.vala | 44 +++++++------- folks/persona.vala | 2 +- 12 files changed, 127 insertions(+), 123 deletions(-) commit 531ad2e2bab35e5aaa0be7fdb0eb12c8f6b5bcff Author: Travis Reitter Date: Mon Dec 27 17:14:45 2010 -0800 Ensure private and internal methods begin with a _ Helps bgo#629083 HACKING | 4 + backends/key-file/kf-backend.vala | 4 +- backends/telepathy/lib/tpf-persona-store.vala | 176 ++++++++++++------------ backends/telepathy/lib/tpf-persona.vala | 28 ++-- backends/telepathy/tp-backend.vala | 20 ++-- folks/backend-store.vala | 42 +++--- folks/debug.vala | 2 +- folks/has-presence.vala | 6 +- folks/individual-aggregator.vala | 71 +++++----- folks/individual.vala | 114 ++++++++-------- folks/persona.vala | 16 +- 11 files changed, 244 insertions(+), 239 deletions(-) commit a9bbcc8e1787511900ea738af3118e15b2cdae3e Author: Travis Reitter Date: Mon Dec 27 16:28:38 2010 -0800 Ensure private and internal data members begin with a _ Helps bgo#629083 HACKING | 5 + backends/key-file/kf-backend-factory.vala | 6 +- backends/key-file/kf-persona-store.vala | 64 +++--- backends/key-file/kf-persona.vala | 29 +-- backends/telepathy/lib/tpf-logger.vala | 36 ++-- backends/telepathy/lib/tpf-persona-store.vala | 317 +++++++++++++------------ backends/telepathy/lib/tpf-persona.vala | 8 +- backends/telepathy/tp-backend-factory.vala | 6 +- backends/telepathy/tp-backend.vala | 19 +- folks/backend-store.vala | 18 +- folks/individual-aggregator.vala | 89 ++++---- folks/individual.vala | 26 +- 12 files changed, 316 insertions(+), 307 deletions(-) commit 74ad4b3675d93dc02a27032d1caac2ce94119d8b Author: Travis Reitter Date: Wed Dec 29 15:55:44 2010 -0800 Write down development policies. Fixes bgo #638311. HACKING | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 75 insertions(+), 0 deletions(-) commit bb992186c6fa65eac8608d1398edf8ae879c0c67 Author: Philip Withnall Date: Fri Dec 17 11:16:04 2010 +0000 Bug 637240 — libfolks-telepathy.so exports private symbols Limit the symbols exported by the libfolks-telepathy.so library to those starting with “tpf_”. Based on a patch by Emilio Pozuelo Monfort . Closes: bgo#637240 NEWS | 6 ++++++ backends/telepathy/lib/Makefile.am | 4 +++- 2 files changed, 9 insertions(+), 1 deletions(-) commit 730aedbcc032ac509c111d85b36d4a01a937abf6 Author: Philip Withnall Date: Mon Dec 13 16:49:18 2010 +0000 Post-release version bump configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 36f984c444d87443d86d09f180de25ea8e9d85c1 Author: Philip Withnall Date: Mon Dec 13 16:45:07 2010 +0000 Release version 0.3.3 NEWS | 12 ++++++++++++ configure.ac | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-)