commit 2b67dc0e8d244d87c39d52ae627711ebc9de2f71 Author: Matthias Clasen Date: Sun Jul 15 15:10:41 2012 -0400 Updates NEWS | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) commit 85f2a721cfae94ed9497c56a72b3dce0677f4317 Author: Cosimo Cecchi Date: Thu Jul 5 10:08:10 2012 -0400 pixbuf-engine: add a GtkRC option for widget direction Add a GtkRC option to select for an LTR/RTL widget direction in the pixbuf engine; this will allow the engine to apply different theming assets according to the text direction, which is useful when theming e.g. a spinbutton or a combobox entry. modules/engines/pixbuf/pixbuf-draw.c | 12 +++++++++- modules/engines/pixbuf/pixbuf-rc-style.c | 37 +++++++++++++++++++++++++++++- modules/engines/pixbuf/pixbuf.h | 9 ++++++-- 3 files changed, 54 insertions(+), 4 deletions(-) commit da324fa2d5723739b9a74996e1e11df93b300aec Author: Daniel Sabo Date: Wed Jun 13 17:21:56 2012 +0100 [Bug 676362] _gdk_quartz_image_copy_to_image always returns black for the root window Revised patch which doesn't depend upon NSRect being typdeffed from CGRect (64-bit only). gdk/quartz/gdkimage-quartz.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 2f706868ff3c4a3d25aa85e233590161a55c9657 Author: Daniel Sabo Date: Mon Jun 11 21:06:58 2012 +0200 Bug 676362 - _gdk_quartz_image_copy_to_image always returns black... Implement a special case for the root window, which has to be handled differently on OS X. Contains some bit fiddling corrections by Kristian Rietveld. gdk/quartz/gdkimage-quartz.c | 69 ++++++++++++++++++++++++++++-------------- 1 file changed, 47 insertions(+), 22 deletions(-) commit 860499ce90a6f184181f2e7249871e2514c83e00 Author: Kristian Rietveld Date: Sun Jun 3 15:19:27 2012 +0200 quartz: delay emission of EnterNotify until window position is known Beforehand, the check whether or not emission is necessary was done based on the "uninitialized" window position in the top left corner. We now wait until the window size is set for the first time, to avoid emitting EnterNotify when it is not necessary. gdk/quartz/GdkQuartzView.c | 9 --------- gdk/quartz/GdkQuartzWindow.c | 22 ++++++++++++++++++++++ gdk/quartz/GdkQuartzWindow.h | 1 + 3 files changed, 23 insertions(+), 9 deletions(-) commit 0b59fbfb9d677b77b392c0c6d327ddecd7978d89 Author: Matthias Clasen Date: Tue Jun 5 17:03:42 2012 -0400 Allow fallback for input method modules Accept a :-separated list of module names in GTK_IM_MODULE and the corresponding setting, to deal a bit better with broken situations. https://bugzilla.gnome.org/show_bug.cgi?id=603559 Patch by Akira Tagoh, backported from GTK+ 3. The backport is required because GTK+ 2 and 3 are listening to the same env vars and settings for immodules. docs/reference/gtk/running.sgml | 2 ++ gtk/gtkimmodule.c | 49 +++++++++++++++++++++++++++------------ gtk/gtksettings.c | 2 ++ 3 files changed, 38 insertions(+), 15 deletions(-) commit b32a9eb691920f21ad3b9127c833aaba15727c4b Author: Michael Natterer Date: Thu May 31 11:02:09 2012 +0200 GtkTreeView: make tree expanding/collapsing more robust gtk_grab_remove() *after* we did the expanding/collapsing, otherwise grab_notify() might kick in and mess with our state. Fixes bug #675835. gtk/gtktreeview.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 8750833e61360068fbf5218293cc138a2402af31 Author: Michael Natterer Date: Sun May 27 23:04:27 2012 +0200 gtk-demo: add semikolon to make it build again demos/gtk-demo/offscreen_window2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 5b91e0d501011d4dde3908267faba15373871790 Author: Connor Behan Date: Wed Feb 29 21:30:05 2012 -0800 Make gtk2 demos comply with gseal Demos in gtk-demo are supposed to be exemplary. However, if one were to give them dummy main functions many of them would not compile with -DGSEAL_ENABLE. This changes the demos to make them use accessor functions whenever possible instead of direct changes to the struct members. http://bugzilla.gnome.org/show_bug.cgi?id=667155 demos/gtk-demo/changedisplay.c | 15 ++++---- demos/gtk-demo/clipboard.c | 2 +- demos/gtk-demo/colorsel.c | 9 +++-- demos/gtk-demo/combobox.c | 2 +- demos/gtk-demo/dialog.c | 2 +- demos/gtk-demo/drawingarea.c | 22 +++++++----- demos/gtk-demo/entry_buffer.c | 2 +- demos/gtk-demo/entry_completion.c | 2 +- demos/gtk-demo/expander.c | 2 +- demos/gtk-demo/hypertext.c | 4 +-- demos/gtk-demo/offscreen_window.c | 70 ++++++++++++++++++++---------------- demos/gtk-demo/offscreen_window2.c | 63 ++++++++++++++++++-------------- demos/gtk-demo/panes.c | 31 ++++++++-------- demos/gtk-demo/rotated_text.c | 9 +++-- demos/gtk-demo/search_entry.c | 2 +- demos/gtk-demo/sizegroup.c | 2 +- demos/gtk-demo/spinner.c | 2 +- demos/gtk-demo/toolpalette.c | 14 +++++--- 18 files changed, 147 insertions(+), 108 deletions(-) commit 43c9a702c708231b038ca072ef4738d5ea547ccf Author: Christian Kellner Date: Mon May 14 21:33:08 2012 +0200 quartz: Don't use compound text for selections Explicitly return FALSE in selection_set_compound_text() to indicate that we don't want to support compound text selections; this will eliminate the "not implemented" warning for quartz. gtk/gtkselection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit eb831590cd9354bdcb9933ca9bfe531b12177473 Author: Kristian Rietveld Date: Sun Apr 22 12:14:23 2012 +0200 Implement _gtk_clipboard_store_all() This pushes the clipboard contents to the OS X clipboard when the application is quit. Without doing this, clipboard data set by a GTK+ application cannot be accessed after the clipboard has been quit. Currently, we implement this the easy way because the clipboard support is fully implemented in GTK+. In the future this might change. gtk/gtkclipboard-quartz.c | 58 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 2 deletions(-) commit 194d5544b4bc4499e6953fb57010bb6b6db5f60a Author: Kristian Rietveld Date: Sun May 13 17:57:59 2012 +0200 quartz: Ignore events from all mouse buttons past the resize boundary Before, right click events were still let through into GDK. In this case, also middle/right button events with x-coordinates in the range [-3, 0] are processed, resulting in failures/crashes in the window finding code because no GdkWindows are present in this range. gdk/quartz/gdkevents-quartz.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) commit 71164e57b9b999f07a613806058ee87b9cbf882d Author: Michael Natterer Date: Thu May 10 10:57:16 2012 +0200 quartz: add a special case to GtkIMContextSimply for entering '"' Turn dead_doubleacute plus space into '"' and not into a double acute because that's the way to enter double quotes on the US-International keyboard layout. gtk/gtkimcontextsimple.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) commit b738cf85d9a77c4b4baa493278ea001f0c99264f Author: Michael Natterer Date: Tue May 8 15:50:52 2012 +0200 quartz: handle yet another dead tilde variant which is delivered by the US-International keyboard layout. gdk/quartz/gdkkeys-quartz.c | 1 + 1 file changed, 1 insertion(+) commit 2b624f6f8fba8d68c49fd166ba5bf2aa28420ff6 Author: Federico Mena Quintero Date: Mon May 7 15:42:32 2012 -0500 bgo#675421 - Set the wm_role on GtkFileChooserDialog The window's role is 'GtkFileChooserDialog', so that window managers can match it for positioning. Signed-off-by: Federico Mena Quintero gtk/gtkfilechooserdialog.c | 2 ++ 1 file changed, 2 insertions(+) commit fb2cbb3cde0eef5c5317bff1d5f48bbe6eebab3b Author: Dumitru Mișu Moldovan Date: Sat May 5 11:26:08 2012 +0300 Updated Romanian translation po-properties/ro.po | 3869 ++++++++++++++++++++++++++------------------------- po/ro.po | 2854 +++++++++++++------------------------ 2 files changed, 2973 insertions(+), 3750 deletions(-) commit 63f6e920017ddd8dcceeabc976063e30fd6f8de4 Author: John Ralls Date: Sat Feb 25 17:54:10 2012 -0800 modules/printing/cups/gtkprintbackendcups.c won't build with CUPS 1.6 Fix up accesses of ipp structures in gtkcupsutils.c modules/printbackends/cups/gtkcupsutils.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) commit 75103b62e5ba88e03dd5d93442fc0f946dc87c13 Author: John Ralls Date: Sat Feb 25 17:53:32 2012 -0800 modules/printing/cups/gtkprintbackendcups.c won't build with CUPS 1.6 Having refactored cups_request_printer_list_cb so that the cups version-dependent block size is small enough to be handled in a single ifdef, make the ifdef HAVE_CUPS_API_1_6 block modules/printbackends/cups/gtkprintbackendcups.c | 24 +++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) commit 7d2725e40033f2a379fc23200711d4d1f7a1b00e Author: John Ralls Date: Sat Feb 25 17:52:46 2012 -0800 Move some variable declarations into the scopes in which they're used. modules/printbackends/cups/gtkprintbackendcups.c | 39 +++++++++++----------- 1 file changed, 20 insertions(+), 19 deletions(-) commit b7d59f73db8c25e5d39becee061e308305c00084 Author: John Ralls Date: Sat Feb 25 17:52:02 2012 -0800 Extract Function cups_create_printer modules/printbackends/cups/gtkprintbackendcups.c | 185 ++++++++++++---------- 1 file changed, 99 insertions(+), 86 deletions(-) commit 0d1edac55b4e1dec0a547dfb9a5bedd6232b924c Author: John Ralls Date: Sat Feb 25 17:48:06 2012 -0800 Extract function cups_printer_handle_attribute modules/printbackends/cups/gtkprintbackendcups.c | 252 +++++++++++----------- 1 file changed, 130 insertions(+), 122 deletions(-) commit 61dd746d517ec982e471a3c75e28937787a67a1f Author: John Ralls Date: Sat Feb 25 17:47:19 2012 -0800 Extract printer setup variables into a struct So that it can be passed as a single parameter to functions as we extract-function to make cups_request_printer_list_cb more manageable. Note that not all of the affected variables are changed in this changeset. Those are in extracted functions and will be addressed in the next two changes. modules/printbackends/cups/gtkprintbackendcups.c | 123 ++++++++++++---------- 1 file changed, 67 insertions(+), 56 deletions(-) commit 399f31021c921e3a2479fe8ff3e18b8185e4cf04 Author: John Ralls Date: Sat Feb 25 17:45:04 2012 -0800 Create enum PrinterStateLevel Fixes "magic number" in printer_state_reason_level. modules/printbackends/cups/gtkprintbackendcups.c | 7 +++++++ 1 file changed, 7 insertions(+) commit 3100279bf102030329ac1f22a2f9d94daea23bfc Author: John Ralls Date: Sat Feb 25 17:44:13 2012 -0800 Extract reasons and reasons_desc arrays to file level So that they can be used from more than one function. Rename them to avoid naming conflicts. modules/printbackends/cups/gtkprintbackendcups.c | 70 +++++++++++----------- 1 file changed, 36 insertions(+), 34 deletions(-) commit 0883b09086a2f3df9005a3e783c891f45cbe9792 Author: John Ralls Date: Sat Feb 25 17:43:18 2012 -0800 modules/printing/cups/gtkprintbackendcups.c won't build with CUPS 1.6 The first, simple changes. Turns off the deprecation warnings and substitutes macros and short ifdef blocks where feasible. configure.in | 6 + modules/printbackends/cups/gtkprintbackendcups.c | 146 +++++++++++++--------- 2 files changed, 93 insertions(+), 59 deletions(-) commit 85c9b5c76ad4cb948f744f4679c02059c8ddc7d9 Author: Federico Mena Quintero Date: Mon Apr 23 10:45:50 2012 -0500 bgo#674556 - Save the file chooser's settings when the toplevel gets unmapped In GTK+ 2, child widgets don't get unmapped, and yet, that is when we were trying to save the settings of GtkFileChooserDefault. Now we connect to the toplevel's unmap signal and do the right thing there. Signed-off-by: Federico Mena Quintero gtk/gtkfilechooserdefault.c | 56 ++++++++++++++++++++++++------------------- gtk/gtkfilechooserprivate.h | 2 ++ 2 files changed, 34 insertions(+), 24 deletions(-) commit 698aba575c506c81dc0f05b1224f94b54a83c5c4 Author: Kristian Rietveld Date: Sun Apr 22 17:15:06 2012 +0200 quartz: properly handle the given hotspot position gtk/gtkdnd-quartz.c | 6 ++++++ 1 file changed, 6 insertions(+) commit f91c525fe23a71abe389746bc5560bfe507ae5cb Author: Kristian Rietveld Date: Sun Apr 22 17:11:38 2012 +0200 quartz: fix coordinates for synthesized event Of course, we must pass coordinates in the NSWindow coordinate system when creating an NSEvent. This fixes drag icon positioning and makes the icon slide back to the correct position when the drag is canceled. gtk/gtkdnd-quartz.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) commit 5f25687104f77aba310ac32c35d263f9d565d983 Author: Kristian Rietveld Date: Sun Feb 19 16:08:26 2012 +0100 [quartz] Fix manual resizing of windows In the Quartz backend, there are two methods by which windows are resized. The first method is fully handled by Quartz and does not appear in the event stream the application resizes. The second method is when we resize windows by ourselves. In OS X this happens when a GTK+ resize grip is used. This resize grip is larger than the Quartz resize grip. When the resize is started outside the "Quartz area", we have to handle it by ourselves. This patch fixes this manual window resizing by ignoring events while we are in the process of resizing (such that the events actually arrive at the sendEvent handler of GdkQuartzWindow where this resize is handled). When the resize has finished we break all grabs such that GDK is not stuck thinking the cursor is still in the resize window. gdk/quartz/GdkQuartzWindow.c | 10 ++++++++++ gdk/quartz/GdkQuartzWindow.h | 1 + gdk/quartz/gdkevents-quartz.c | 6 ++++++ 3 files changed, 17 insertions(+) commit ac4f3be6a5a6672708af8fe732b932fd1e1d8beb Author: Kristian Rietveld Date: Sun Feb 19 16:02:09 2012 +0100 Export break_all_grabs() within Quartz backend Function was renamed to _gdk_quartz_events_break_all_grabs(). gdk/quartz/gdkevents-quartz.c | 8 ++++---- gdk/quartz/gdkprivate-quartz.h | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) commit 9a0e81380bfdc0abebbfa657abc974afeea6027b Author: Carlos Garcia Campos Date: Thu Mar 15 12:10:52 2012 +0100 printing: Make sure destroy function is always called by gtk_enumerate_printers When GtkPrinterFunc always returns FALSE, for example when looking for a non existent printer, if print list is done for all backends or print backend status is UNAVAILABLE, gtk_enumerate_printers() finishes with an empty backend list and destroy function is never called. We need to check the backend list again after calling list_printers_init for all backends and finish the enumeration if it's empty. https://bugzilla.gnome.org/show_bug.cgi?id=672125 gtk/gtkprinter.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) commit 51fb0419c25edccd327662303a879c2b29b75a85 Author: Chun-wei Fan Date: Thu Mar 15 16:48:35 2012 +0800 Fix "install" paths in VS property sheets build/win32/vs10/gtk+.props | 2 +- build/win32/vs9/gtk+.vsprops | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 339786f07845fc5b6de2266cf4de70ed00159f1b Author: Javier Jardón Date: Wed Mar 14 19:20:22 2012 +0000 build: require glib 2.28 As dieterv said, gtk 2.24 win32 binaries have been frozen on glib 2.28.x, and we dont have resources rigth now to ensure pygobject static bindings still function correctly with newer glib versions configure.in | 2 +- gtk/gtkfilechooserdefault.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) commit 6eacdae613d69de371099faf7146e905d9f8a4e6 Author: Javier Jardón Date: Wed Mar 14 18:51:23 2012 +0000 configure.ac: require Glib 2.30 As we use g_format_size() now See commit 2bedcd8863a88f1e1aea15494dc1995e84a49133 configure.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2bedcd8863a88f1e1aea15494dc1995e84a49133 Author: Federico Mena Quintero Date: Mon Mar 5 17:21:22 2012 -0600 Use g_format_size() instead of g_format_size_for_display() We do this like in commit 4ead7b69ea0, so that apps which use the gtk2 file chooser will show the same file sizes as gtk3 apps. gtk/gtkfilechooserdefault.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4b1e2b08a7060f34fc350be97eac41b35acda361 Author: Benjamin Otte Date: Sat Mar 3 21:10:46 2012 +0100 iconview: Fix autoscroll ... when the iconview is not the only child in it's parent GdkWindow. gtk/gtkiconview.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 3f6592f60fd15fb353fc84600caefba3054dc892 Author: Mikael Magnusson Date: Tue Feb 21 17:14:16 2012 +0100 Iconification using _NET_WM_STATE_HIDDEN hint if supported by WM If the Window Manager supports the _NET_WM_STATE_HIDDEN, we use it to use the _NET_WM_STATE protocol when de-iconifying windows (iconification is unchanged, via XIconifyWindow). Additionally, we no longer interpret all UnmapNotify events for our window as the result of iconification. (Based on patch by Tomas Frydrych ) gdk/x11/gdkevents-x11.c | 53 +++++++++++++++++++++++++++++++++++------------ gdk/x11/gdkwindow-x11.c | 17 +++++++++++++++ gdk/x11/gdkwindow-x11.h | 1 + 3 files changed, 58 insertions(+), 13 deletions(-) commit 03b7195e646c06d127de1588017ed025d5c85e86 Author: John Ralls Date: Thu Mar 1 12:04:25 2012 -0800 Bug 655065 Build failure on OS X 10.7 Lion Remove LDDADS and setting each object file's LDDAD to it; just set a global LDDAD. tests/Makefile.am | 69 +---------------------------------------------------- 1 file changed, 1 insertion(+), 68 deletions(-) commit dca75f3b938d3744ec493466d26e0cfb024326aa Author: Michael Natterer Date: Thu Feb 23 13:52:10 2012 +0100 quartz: remove excess initializers in the new modifier_keys array gdk/quartz/gdkkeys-quartz.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) commit 0b24f16241f563b71c0c827bbb760a72df892b6a Author: Michael Natterer Date: Thu Feb 23 13:27:09 2012 +0100 quartz: make function keys work (again?) The F keys have no unicode mapping, and UCKeyTranslate() returns a bogus 0x10 as mapping to unicode. Instead of checking for this random and undocumented return value, simply assign all function keys explicitly. This patch also splits the ill-named "known_keys" array into "modifier_keys" and "function_keys" which is much more obvious. gdk/quartz/gdkkeys-quartz.c | 37 +++++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 12 deletions(-) commit 2ab15264676591c65a277296080159ef40a527b4 Author: Bastien Nocera Date: Sun Feb 19 16:43:33 2012 +0100 x11: Fix first call to _gdk_x11_keymap_key_is_modifier() _gdk_x11_keymap_key_is_modifier() never tries to set min/max_keycode if they haven't been set before, meaning that until another function sets those, all the keys will be seen as non-modifiers. This causes GdkKeyEvents to be wrongly tagged with "->is_modifier = 0" when in actual fact the key is a modifier. This fixes keyboard shortcuts captured with GtkCellRendererAccel in "raw" mode thinking a modifier without any actual keys is a valid shortcut. https://bugzilla.gnome.org/show_bug.cgi?id=670400 Conflicts: gdk/x11/gdkkeys-x11.c gdk/x11/gdkkeys-x11.c | 1 + 1 file changed, 1 insertion(+) commit 8da54b81182af2d56230de22c0e00a5aba9ab442 Author: Matthias Clasen Date: Fri Feb 25 14:37:57 2011 -0500 GtkTrayIcon: chain up in dispose Pointed out in bug 643131 and bug 640308. gtk/gtktrayicon-x11.c | 2 ++ 1 file changed, 2 insertions(+) commit 0b2fd066b90b24572c3c3a0e4c811a512f239807 Author: Javier Jardón Date: Tue Feb 14 19:40:17 2012 +0000 gdk/gdkwindow: Add missins "Since:2.24" Reported by Mike Massonnet in bug https://bugzilla.gnome.org/show_bug.cgi?id=670093 gdk/gdkwindow.c | 2 ++ 1 file changed, 2 insertions(+) commit bbe8ba8affe619869c4b11a390341ec8c7b7c18b Author: Kalev Lember Date: Thu Feb 9 15:12:22 2012 +0200 win32: Don't crash when installed in a top-level directory Avoid NULL-pointer dereference when package installation directory doesn't contain any slashes. Reported by Paweł Forysiuk. gtk/gtkmain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 14488e69c43dee702763ffd48cb99d950d8ac73c Author: John Ralls Date: Tue Feb 7 16:03:28 2012 -0800 Remove stock_icons/*/text-x-generic.png from GENERATED_ICONS It's not generated, and having it included removes it during maintainer-clean so you have to retrieve it from the repo to build. gtk/Makefile.am | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit bfb50d563fe845fd55d6a535a0dcbbe6e3789780 Author: Matthias Clasen Date: Mon Feb 6 11:36:01 2012 -0500 bump version configure.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)