commit 05020b29c17e5b7eb9391eca3e1d6b300fa77ec7 Author: Jonathan Matthew Date: Sun Jul 5 20:30:51 2009 +1000 release 0.12.3 NEWS | 7 +++++++ configure.ac | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-) commit 1c74f1b047472bee1b11695cd3961584c4f5f5a8 Author: Jonathan Matthew Date: Sat Jul 4 21:34:18 2009 +1000 loader: ensure we always release the gdk lock after callbacks (bug #587691) plugins/rb/Loader.py | 31 ++++++++++++++++++++++--------- 1 files changed, 22 insertions(+), 9 deletions(-) commit 7e8864ae09b39c49a7c174f1eede0dfbece122f2 Author: Jonathan Matthew Date: Sat Jul 4 18:16:03 2009 +1000 player-gst: don't stop the pipeline in about-to-finish handler (bug #585595) about-to-finish is emitted on a streaming thread, so we can't change the pipeline state from there, and if there's nothing to play after the current track, we want to wait until it actually finishes. This is a bit of a hack, but it works for now. backends/gstreamer/rb-player-gst.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) commit ab34a3ead0fd63e56d686afbd7c83a0a8e186343 Author: Mark Krapivner Date: Fri Jul 3 18:31:38 2009 +0300 Updated Hebrew translation po/he.po | 1254 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 623 insertions(+), 631 deletions(-) commit 60dea251298c8a7894e39b1a9a215d74f822ec01 Author: ifelix Date: Fri Jul 3 16:16:42 2009 +0530 Tamil linguas added po/LINGUAS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 79f191ba6442490aaeaf58a7d464e2791d8b56ea Author: ifelix Date: Fri Jul 3 16:16:25 2009 +0530 Updated Tamil Translations po/ta.po | 4956 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 4956 insertions(+), 0 deletions(-) commit 3b8c0f2cfeb8c533264ff5f8d03d1894a702ad5d Author: Mattias Põldaru Date: Thu Jul 2 05:37:34 2009 +0300 Updating Estonian translation po/et.po | 4328 +++++++++++++++++++++++++++++++++++++++++++++++--------------- 1 files changed, 3279 insertions(+), 1049 deletions(-) commit bc5d1814b25e001fd37db30f11e548f3c4489fd1 Author: A S Alam Date: Thu Jul 2 06:44:38 2009 +0530 Updating translation for Punjabi po/pa.po | 506 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 262 insertions(+), 244 deletions(-) commit 69f00d0f4f7e8de61ad1ce093488043bbf89fe23 Author: Gabor Kelemen Date: Thu Jul 2 00:04:12 2009 +0200 Hungarian translation updated po/hu.po | 972 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 485 insertions(+), 487 deletions(-) commit 453b62df94d833ff27b70e62c3deb17b42c7ad6e Author: Jonathan Matthew Date: Wed Jul 1 10:44:19 2009 +1000 rhythmdb: don't crash when processing certain load errors (bug #587479) Some metadata load events don't end up having a metadata reader instance, but in some places we assumed they all did. rhythmdb/rhythmdb.c | 23 ++++++++++++----------- 1 files changed, 12 insertions(+), 11 deletions(-) commit e121ba05876623b7e0ff36123e11dda4f117872b Author: Jonathan Matthew Date: Tue Jun 30 09:38:03 2009 +1000 first prerelease of 0.12.3 NEWS | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ README | 2 +- configure.ac | 2 +- 3 files changed, 94 insertions(+), 2 deletions(-) commit b89bc041494ba819358cb608dd6132818776c98a Author: Jonathan Matthew Date: Tue Jun 30 09:28:58 2009 +1000 metadata: use GSlice to allocate GValues (bug #587329) Since commit 606ab6746597b8c1ca5d35e52db345bc46a67e8b they've been freed as if they were allocated this way. This fixes various allocation related complaints from the metadata helper process. metadata/rb-metadata-gst.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit f6b27b5a7a6319948042dbf538df821c42258e3d Author: Luca Ferretti Date: Mon Jun 29 07:50:13 2009 +0200 Updated Italian translation po/it.po | 366 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 193 insertions(+), 173 deletions(-) commit 9b6e1f8abae7af8c53c22ed6a051636e892be101 Author: Claude Paroz Date: Sun Jun 28 21:00:13 2009 +0200 Updated French translation (ui and help) help/fr/fr.po | 69 +++-- po/fr.po | 944 +++++++++++++++++++++++++++++---------------------------- 2 files changed, 515 insertions(+), 498 deletions(-) commit 3b829591bbce0f347f121ef22a94bf79dc8c06ce Author: Jonathan Matthew Date: Sun Jun 28 11:42:21 2009 +1000 API doc: remove proxy config sections doc/reference/rhythmbox-docs.sgml | 1 - doc/reference/rhythmbox-sections.txt | 18 ------------------ doc/reference/rhythmbox.types | 2 -- 3 files changed, 0 insertions(+), 21 deletions(-) commit 76e886d660dff8d37cd83028158c8932893b36cd Author: Jonathan Matthew Date: Sun Jun 28 10:09:14 2009 +1000 audiocd: clean up properly when metadata loading fails (bug #516192) plugins/audiocd/rb-audiocd-source.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) commit b35515b85b1f3fda18a6e8f879d257be76e7c140 Author: Jonathan Matthew Date: Sat Jun 27 18:06:05 2009 +1000 metadata: don't try to add NULL strings to dbus messages Stops the metadata helper crashing when it can't identify the media type of a file it's reading. metadata/rb-metadata-dbus-service.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 51abc1d08ca4ce7d71011745759f33d4b870f1c7 Author: Jonathan Matthew Date: Sat Jun 27 15:02:23 2009 +1000 remove rb-proxy-config.c from POTFILES.in po/POTFILES.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit e50a4772d024c174254b16c416025a1bea3af9dd Author: Jonathan Matthew Date: Sat Jun 27 13:54:27 2009 +1000 encoder-gst: use queue2 instead of queue backends/gstreamer/rb-encoder-gst.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit cc1d43f6c8fbd7a80d480fc520e2ab8996947225 Author: Jonathan Matthew Date: Sat Jun 27 13:53:23 2009 +1000 encoder-gst: only add string tags if non-NULL and not empty This fixes some GStreamer warnings. backends/gstreamer/rb-encoder-gst.c | 56 +++++++++++++---------------------- 1 files changed, 21 insertions(+), 35 deletions(-) commit 8dd0926e24f0f8ba13e1e71585ecd44c4df1966d Author: Žygimantas Beručka Date: Fri Jun 26 19:37:06 2009 +0300 Updated Lithuanian translation po/lt.po | 2891 +++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 1634 insertions(+), 1257 deletions(-) commit ddb82e1457d12d39c30237767fe59246f6df4344 Author: Jonathan Matthew Date: Fri Jun 26 21:23:45 2009 +1000 remove old proxy code, use libsoup-gnome Besides throwing away a pile of dead code, this means things work with proxy autoconfiguration (bug #345712). configure.ac | 4 +- lib/Makefile.am | 5 +- lib/rb-preferences.h | 1 - lib/rb-proxy-config.c | 289 --------------------- lib/rb-proxy-config.h | 78 ------ plugins/audioscrobbler/rb-audioscrobbler-plugin.c | 29 +-- plugins/audioscrobbler/rb-audioscrobbler.c | 57 +---- plugins/audioscrobbler/rb-audioscrobbler.h | 4 +- plugins/audioscrobbler/rb-lastfm-source.c | 57 +---- shell/rb-shell.c | 17 -- 10 files changed, 27 insertions(+), 514 deletions(-) commit dea10f4abd5e5b7b44d0322711423a993543d434 Author: Jonathan Matthew Date: Fri Jun 26 10:14:43 2009 +1000 player-gst: fix crash on pipeline shutdown failure (bug #586985) backends/gstreamer/rb-player-gst.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 531575723b8eb70466599ad217f2c2820b16bda1 Author: Sandeep Shedmake Date: Wed Jun 24 19:01:48 2009 +0530 Updated Marathi Translations po/mr.po | 256 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 136 insertions(+), 120 deletions(-) commit 3b13bc39f524f15023dff660090f660c8fa0b7d3 Author: Jonathan Matthew Date: Wed Jun 24 19:32:14 2009 +1000 ipod: implement move-to-trash for playlists (bug #586649) plugins/ipod/rb-ipod-source.c | 32 ++++++++++++++---------- plugins/ipod/rb-ipod-source.h | 3 ++ plugins/ipod/rb-ipod-static-playlist-source.c | 20 ++++++++++++++- 3 files changed, 41 insertions(+), 14 deletions(-) commit 8b1b586d6030e653ad2fd62aec5f3969151498ba Author: Jonathan Matthew Date: Wed Jun 24 19:27:33 2009 +1000 generic-player: implement move-to-trash in playlists .../rb-generic-player-playlist-source.c | 38 +++++++++- plugins/generic-player/rb-generic-player-source.c | 82 ++++++++++++++------ plugins/generic-player/rb-generic-player-source.h | 5 + 3 files changed, 100 insertions(+), 25 deletions(-) commit 4c7affae378869b7b6cfc7f13367c762bcfff038 Author: Jonathan Matthew Date: Wed Jun 24 19:21:55 2009 +1000 generic-player: shorten function names in the playlist source class .../rb-generic-player-playlist-source.c | 32 ++++++++++--------- 1 files changed, 17 insertions(+), 15 deletions(-) commit 660e2b9358062c52fe6016abfb0db5c223b65190 Author: Jonathan Matthew Date: Wed Jun 24 10:43:14 2009 +1000 rhythmdb: rearrange a message so intltool notices the translator comment rhythmdb/rhythmdb.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) commit a4d0777f15629e1a942f8b7a648cb43025e5d6e4 Author: Leonardo Ferreira Fontenelle Date: Tue Jun 23 21:20:01 2009 -0300 Updated Brazilian Portuguese translation. Fixed access key errors as well. Closes bugs #576792, #576804, #576805, #576806, #576816, #576817, #576819 and #576821. po/pt_BR.po | 90 +++++++++++++++++++++++++---------------------------------- 1 files changed, 38 insertions(+), 52 deletions(-) commit 07ecf70823e3c42381f621f5adfe3e41161dd435 Author: César Veiga Date: Tue Jun 23 20:26:50 2009 -0300 Updated Brazilian Portuguese translation. po/pt_BR.po | 2586 +++++++++++++++++++++++++++++++++-------------------------- 1 files changed, 1448 insertions(+), 1138 deletions(-) commit 8ab9c0721fd14d4309d760d3bf0f26df8f6cab3a Author: Jonathan Matthew Date: Tue Jun 23 22:54:36 2009 +1000 encoder: fix the queue size parameters so they actually help Previously, with max-size-time set to 2 minutes and everything else at default values, either max-size-buffers (200) or max-size-bytes (~10mb) would take effect. For CD audio, 200 buffers is 200 CD sectors, which is under 3 seconds. This makes CD ripping about twice as fast for me. backends/gstreamer/rb-encoder-gst.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 39ae571ee625b81c8a5a2b425428fb525bf291ef Author: Amitakhya Phukan Date: Mon Jun 22 14:00:15 2009 +0530 Updated Assamese translations po/as.po | 1717 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 870 insertions(+), 847 deletions(-) commit 3ee01d00ebc2b2af6babcbd93712d3c1a0304b59 Author: Jorge Gonzalez Date: Sun Jun 21 10:34:43 2009 +0200 Updated Spanish translation po/es.po | 256 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 136 insertions(+), 120 deletions(-) commit e1e712995d444b747037af8321d7c67f2ded2a4b Author: Jonathan Matthew Date: Sat Jun 20 20:47:02 2009 +1000 add album-info.ui to makefile plugins/audiocd/Makefile.am | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 6a6b1f155d568f57133e63694bb7d4f5cee50b35 Author: Jonathan Matthew Date: Sat Jun 20 18:57:02 2009 +1000 add album-info.ui to POTFILES.in po/POTFILES.in | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 23ca394b7e612a3f10898fed970c50a507ef2dd4 Author: Jonathan Matthew Date: Sat Jun 20 18:04:56 2009 +1000 audiocd: make title, genre, and artist columns editable in place plugins/audiocd/rb-audiocd-source.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 128f2706aab6ef896d6f25e6f2d281d3e06a876f Author: Jonathan Matthew Date: Sat Jun 20 18:03:40 2009 +1000 entry-view: add function for making columns editable bindings/python/rb.defs | 10 ++++++ widgets/rb-entry-view.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++ widgets/rb-entry-view.h | 3 ++ 3 files changed, 91 insertions(+), 0 deletions(-) commit a992081242f2639a5343fe7609da0f43d1a804d0 Author: Jonathan Matthew Date: Sat Jun 20 12:25:07 2009 +1000 generic-player: fix crash when trying to delete with no audio folders plugins/generic-player/rb-generic-player-source.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) commit 98558435e7efb12feb8ecb8d1d59f067b1155eeb Author: Jonathan Matthew Date: Sat Jun 20 11:50:33 2009 +1000 audiocd: disable paranoia when reading TOC information This has the side effect of reducing cdparanoia's cache size, making the TOC scan faster. plugins/audiocd/rb-audiocd-source.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit d231afc868b8a9aff40deeec3add32a7e73a7875 Author: Jonathan Matthew Date: Fri Jun 19 23:37:32 2009 +1000 status-icon: check widgets exist before updating them for gconf changes plugins/status-icon/rb-status-icon-plugin.c | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-) commit e1e65ce46c820e5b32b9eccbea91a9a07cc094ad Author: Amitakhya Phukan Date: Fri Jun 19 17:20:14 2009 +0530 Added as to LINGUAS and adding new Assamese translations. po/LINGUAS | 1 + po/as.po | 4860 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 4861 insertions(+), 0 deletions(-) commit 0ff073b314fa95f3ab189fdabc830f29141e4e5b Author: Jonathan Matthew Date: Fri Jun 19 21:31:28 2009 +1000 update for new totem-plparser API additions (bug #586363, #586365) plugins/audioscrobbler/rb-lastfm-source.c | 1 + plugins/iradio/rb-iradio-source.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit 87642de0566e8ed8f82f52ab4fc6d4357f3ce855 Author: Luca Ferretti Date: Fri Jun 19 09:02:38 2009 +0200 Updated Italian translation po/it.po | 858 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 429 insertions(+), 429 deletions(-) commit ead36999a19e2dc4370127e29e7cf4163259cb28 Author: Jonathan Matthew Date: Fri Jun 19 14:29:24 2009 +1000 audiocd: use album artist info for extra metadata requests (bug #550491) plugins/audiocd/rb-audiocd-source.c | 107 ++++++++++++++++++++++++++++++---- 1 files changed, 94 insertions(+), 13 deletions(-) commit d7dc14b15febb17315f690b0007bf96fcd72af85 Author: Jonathan Matthew Date: Fri Jun 19 14:26:13 2009 +1000 audiocd: add album info UI, hide 'album' column The album info UI is mostly copied from sound-juicer, with the addition of the album artist sortname. plugins/audiocd/album-info.ui | 196 +++++++++++++++++++++++++++++++++ plugins/audiocd/rb-audiocd-source.c | 202 +++++++++++++++++++++++++++++++++-- 2 files changed, 391 insertions(+), 7 deletions(-) commit 3e38e86a7c483d196d2cbe71cbc427a9d63e933b Author: Jonathan Matthew Date: Fri Jun 19 14:20:19 2009 +1000 audiocd: don't show the search bar plugins/audiocd/rb-audiocd-source.c | 41 +++++++++++++++++++++++++++++++++++ 1 files changed, 41 insertions(+), 0 deletions(-) commit 2d3deaf286595db867d3a434d23ed017045ef272 Author: Jonathan Matthew Date: Fri Jun 19 14:16:03 2009 +1000 library: request album artist name metadata when building filenames This is currently only available through the extra metadata mechanism, but at some point it should be added as a regular entry property. rhythmdb/rhythmdb.h | 2 ++ sources/rb-library-source.c | 28 +++++++++++++++++++++------- 2 files changed, 23 insertions(+), 7 deletions(-) commit b53fa656b99149540dff96da4de18385977b9b71 Author: Jonathan Matthew Date: Fri Jun 19 14:11:08 2009 +1000 ensure RBSource 'plugin' property is set during construction sources/rb-source.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 43aaef9cf17331941c3c41077d3153dab1bc217f Author: Jonathan Matthew Date: Wed Jun 17 16:04:24 2009 +1000 magnatune: add missing object ID in GtkBuilder file for purchasing plugins/magnatune/magnatune-purchase.ui | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 25e864944bfa652e06e6ca0d40dfad6dd60d6b3d Author: Stefano Frangioni Date: Tue Jun 16 21:30:53 2009 +1000 rb-client: add --set-rating command (bug #583108) remote/dbus/rb-client.c | 39 ++++++++++++++++++++++++++++++++++++++- 1 files changed, 38 insertions(+), 1 deletions(-) commit 0d2157c6eae2a7c0ff106dc077f74c48589423e2 Author: Jonathan Matthew Date: Mon Jun 15 23:35:16 2009 +1000 generic-player: remove empty directories when deleting (bug #584701) When deleting a file from a generic player, walk up the directory structure deleting directories until we hit a non-empty one, one of the device's audio folders, or the root of the device filesystem. plugins/generic-player/rb-generic-player-source.c | 65 +++++++++++++++++++++ 1 files changed, 65 insertions(+), 0 deletions(-) commit 65f1f82ef9fda2f878be45aeef5ab26dbcf0beab Author: Jonathan Matthew Date: Mon Jun 15 22:12:33 2009 +1000 fix interaction with pulseaudio flat volume (bug #584958) First, we count the number of volume changes that have been made, and keep track of the last change to be applied to the pipeline. Then, when starting the pipeline, we apply any volume changes that were made while the pipeline was not running. The extra trick here is that when the audio sink provides volume control, we ignore the first volume setting, which restores the volume setting from gconf. The reason we do this is that pulseaudio remembers our volume for itself and applies it correctly, without modifying the reference output volume. This change also fixes the volume change notification in the playbin2 backend, which was using the wrong signal. backends/gstreamer/rb-player-gst-xfade.c | 21 +++++++++---- backends/gstreamer/rb-player-gst.c | 49 ++++++++++++++++++++++++++---- 2 files changed, 58 insertions(+), 12 deletions(-) commit 738871da60fd8a6e628e8a9c7d1023c75a61e00c Author: Jonathan Matthew Date: Mon Jun 15 18:17:56 2009 +1000 rhythmdb: initialise podcast fields to empty string (bug #556296) rhythmdb/rhythmdb.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) commit eb83a0afd3b7c56d2c399919fae72ae65de06f40 Author: Sandeep Shedmake Date: Mon Jun 15 14:24:32 2009 +0530 Updated Marathi Translations po/mr.po | 163 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 86 insertions(+), 77 deletions(-) commit 71e5be87db86a55e38f54e4c345a7a266762c51b Author: Jonathan Matthew Date: Sun Jun 14 22:51:53 2009 +1000 artdisplay: use fuzzy matching to filter search results (bug #349066) Rework the processing of Amazon search results to use the fuzzy string matcher I added earlier. Rather than trying to do exact or substring matches in various combinations, we now do fuzzy matches for the album name and each of the artist names in the search results (with a special case for 'various artists' to help compilations). To avoid getting the wrong album by the right artist, we reject results where one of the matches is below a threshold. If the result doesn't have a title or an artist, we use a default match strength slightly above this threshold. We then combine the artist and album match strengths and take the highest result, as long as it's above another threshold. .../artdisplay/artdisplay/AmazonCoverArtSearch.py | 153 ++++++++++---------- 1 files changed, 80 insertions(+), 73 deletions(-) commit df7a9dce29b20e167bcd525e2a712a0f2887d5b4 Author: Jonathan Matthew Date: Sun Jun 14 17:38:21 2009 +1000 lyrics: remove the default lyrics folder This makes the plugin use the XDG cache dir rather than ~/.lyrics. data/rhythmbox.schemas | 2 +- plugins/lyrics/lyrics/__init__.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 41dd5fadde967ac65e3a8e59b762cac1c3e92ac7 Author: Jonathan Matthew Date: Sun Jun 14 17:34:56 2009 +1000 lyrics: use fuzzy matches to check lyrics search results (bug #358313) This only applies to the leoslyrics.com and astraweb.com lyrics searches, as the others don't seem to return partial match results, or are too weird for me to figure out how to add this. plugins/lyrics/lyrics/AstrawebParser.py | 34 ++++++++++++++-------- plugins/lyrics/lyrics/LeoslyricsParser.py | 45 +++++++++++++++++++++++------ 2 files changed, 58 insertions(+), 21 deletions(-) commit da948c881531b535af3f5379097baa0df7467092 Author: Jonathan Matthew Date: Sun Jun 14 17:32:33 2009 +1000 lyrics: don't search for 'unknown' as an artist or title plugins/lyrics/lyrics/__init__.py | 47 ++++++++++++++++++++++-------------- 1 files changed, 29 insertions(+), 18 deletions(-) commit e0c38ff77ed342cb6fb2b1836c094a4453757019 Author: Jonathan Matthew Date: Sun Jun 14 17:30:49 2009 +1000 add a fuzzy string matcher to the python 'rb' module plugins/rb/Makefile.am | 1 + plugins/rb/stringmatch.py | 53 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 0 deletions(-) commit 131663e1f5eaf5e9295be3b7c7116219c0d16f29 Author: Mario Blättermann Date: Sat Jun 13 11:20:23 2009 +0200 Updated German doc translation help/de/de.po | 1690 ++++++++++++++++++++++++++++++++++----------------------- 1 files changed, 1007 insertions(+), 683 deletions(-) commit cf29d9daaac71f1602b29974b9fc43ba03b84261 Author: Daniel Nylander Date: Sat Jun 13 10:46:26 2009 +0200 Updated sv translation (Daniel Nylander) po/sv.po | 2500 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 1385 insertions(+), 1115 deletions(-) commit 453a8ecbc728998197e672a3a698c5fa7df5a379 Author: Milo Casagrande Date: Fri Jun 12 12:06:40 2009 -0400 Fixed some typos in the manual * Fixed some mispelled rhythmbox now changed with an entity * Fixes bug 502670 help/C/rhythmbox.xml | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit e2f9d8063aaf04e42864e094a80e692b48dd97a4 Author: John Iacona Date: Fri Jun 12 23:01:45 2009 +1000 shell: add packing parameters for plugin-provided widgets (bug #585524) Adds packing parameters (same as those for gtk_box_pack_start) to rb_shell_add_widget. For the python bindings, the previously used values are now the defaults. C plugins will require code changes to compile. bindings/python/rb.defs | 2 ++ plugins/visualizer/rb-visualizer-plugin.c | 6 ++++-- shell/rb-shell.c | 4 ++-- shell/rb-shell.h | 2 +- 4 files changed, 9 insertions(+), 5 deletions(-) commit 167355eb68ba577624623ae5f7f8c5949e34f69c Author: Jonathan Matthew Date: Fri Jun 12 19:25:53 2009 +1000 rhythmdb: allow errors to be replaced by song entries (bug #539007) We do normal imports by creating events with no entry type specified (for some reason); a logic bug in the metadata load processing code meant that in this case, an import error would never be deleted and replaced with a regular song entry. Now torrent downloads and other types of transfer into the music library will eventually be imported correctly. rhythmdb/rhythmdb.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 185c60d7e3083b87ec6ba0a7b1f2443d1d8c1d56 Author: Sweta Kothari Date: Fri Jun 12 14:46:30 2009 +0530 Updated Gujarati Translation po/gu.po | 429 +++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 244 insertions(+), 185 deletions(-) commit 844b1243dbbb1e5ff66591872ab0bf7a56b421a3 Author: A S Alam Date: Fri Jun 12 06:11:10 2009 +0530 updating translation for Punjabi (Gurmukhi) pa.po po/pa.po | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit de658d10db504870c8ba65cc1f025a484da9d0a1 Author: A S Alam Date: Fri Jun 12 06:10:27 2009 +0530 updating translation for Punjabi (Gurmukhi) pa.po po/pa.po | 370 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 186 insertions(+), 184 deletions(-) commit 28ab6c8df4508514d3aed98db3ebd314adf21f23 Author: Claude Paroz Date: Thu Jun 11 22:51:48 2009 +0200 Updated French help translation help/fr/fr.po | 1362 +++++++++++++++++++++++++++++---------------------------- 1 files changed, 698 insertions(+), 664 deletions(-) commit 713d08da8528f32149204cff72f713dcc4cd0774 Author: Claude Paroz Date: Thu Jun 11 21:44:55 2009 +0200 help: Some more documentation update * Removed ellipsis from interface labels, as of GDP Style guide. * Replaced Source list by Side pane. * Other minor fixes. help/C/rhythmbox.xml | 69 +++++++++++++++++++++++++++---------------------- 1 files changed, 38 insertions(+), 31 deletions(-) commit f0617b51a0136e0cc1c3b71ba07ececbbac7316c Author: Dean Sas Date: Thu Jun 11 20:45:47 2009 +0200 help: Updated documentation (bug #531310) * Adds "transfer music to music players" and "use music stores" to list of features * Points out tags can be edited (bug 488888) * Updates 'new radio item' menu entry * Removes the tip that says you can't write to ipods (bug 528293) * Shuffle some of the preferences documentation about. help/C/rhythmbox.xml | 234 +++++++++++++++++++++++++++----------------------- 1 files changed, 128 insertions(+), 106 deletions(-) commit cc9bfc58221799c9e491ecb176292b935ff848e9 Author: Sweta Kothari Date: Thu Jun 11 17:01:51 2009 +0530 Updated Gujarati Translation po/gu.po | 146 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 76 insertions(+), 70 deletions(-) commit 07e61d1948ddf004eedc32257a470cb4d1d22b0c Author: Claude Paroz Date: Thu Jun 11 09:17:29 2009 +0200 More duplicated help figures deleted help/es/figures/rb-notification-zone.png | Bin 4238 -> 0 bytes help/es/figures/rb-toolbar-shuffle.png | Bin 4579 -> 0 bytes help/fr/figures/rb-toolbar-shuffle.png | Bin 4579 -> 0 bytes 3 files changed, 0 insertions(+), 0 deletions(-) commit 112e2c74339ea6b05a699fb5c49201cde1283815 Author: Jorge Gonzalez Date: Thu Jun 11 09:10:14 2009 +0200 Updated Spanish translation po/es.po | 360 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 182 insertions(+), 178 deletions(-) commit f3db8ef9178a9585f8472e9cb7a34037729ee3e1 Author: Claude Paroz Date: Thu Jun 11 09:05:31 2009 +0200 Remove executable bit from figure help/C/figures/rb-volume-changer.png | Bin 5916 -> 5916 bytes 1 files changed, 0 insertions(+), 0 deletions(-) commit 31e62eeca457afd24297d25b2ff940fd81952f17 Author: Claude Paroz Date: Thu Jun 11 09:05:10 2009 +0200 Remove duplicated figures (identical as original) help/es/figures/rb-toolbar-repeat.png | Bin 4614 -> 0 bytes help/fr/figures/rb-toolbar-repeat.png | Bin 4614 -> 0 bytes help/zh_CN/figures/rb-notification-zone.png | Bin 4238 -> 0 bytes 3 files changed, 0 insertions(+), 0 deletions(-) commit 0b217fa895f03cf88d3bb47b7ceffac948d849b7 Author: Jonathan Matthew Date: Thu Jun 11 00:39:57 2009 +1000 player-gst: pretend playing time is 0 during track changes (bug #584804) Since we don't know exactly when playbin2 changes from one track to the next, we can't emit the playing-stream signal at the right point, and we can't answer playing position queries properly either. So, we emit the playing-stream signal when we set the new URI and pretend the playback position is 0 (in the new stream) until the next timer tick. backends/gstreamer/rb-player-gst.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) commit 4beeb75ebb0683c07fe0c04672082cbf01c27824 Author: Jonathan Matthew Date: Thu Jun 11 00:15:54 2009 +1000 shell-player: use gint64 for playback position in get_playing_time shell/rb-shell-player.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit e41760f8d149eaa56373ad4322a87524eb2b6574 Author: Sweta Kothari Date: Wed Jun 10 15:59:04 2009 +0530 Committed gu.po file po/gu.po | 1031 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 521 insertions(+), 510 deletions(-) commit 6a06692f322ada49bd5a783134ec97edd912fff9 Author: Markus Järvinen Date: Wed Jun 10 19:14:59 2009 +1000 last-fm: enable creation of user playlist stations (bug #585043) plugins/audioscrobbler/rb-lastfm-source.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 9d35e279457f6e036f8a670f6ad5096d333f45b9 Author: Jean-Philippe Garcia Ballester Date: Sat Jun 6 09:01:47 2009 +0200 daap: Allow IPv6 servers (bug #584930) Using “AF_INET”, “sockaddr_in” and “inet_addr” disallow connecting to IPv6 DAAP servers. The solution is to use “soup” to get the appropriate “sockaddr” and protocol family for the given address. plugins/daap/rb-daap-src.c | 32 +++++++++++++++++++------------- 1 files changed, 19 insertions(+), 13 deletions(-) commit b6c3b13f7a4cb6a909c495c41a9eb2d66635ee71 Author: Jean-Philippe Garcia Ballester Date: Sat Jun 6 08:53:20 2009 +0200 daap: Fix “Host” HTTP header on manual daap (bug #584927) Do not resolve DAAP server hostname when adding a new DAAP share, but instead store the hostname in the RBSource object. Resolve the hostname only when necessary, i.e. when connecting with “socket” and “connect”. plugins/daap/rb-daap-plugin.c | 81 +++++++++-------------------------------- plugins/daap/rb-daap-src.c | 13 ++++++- 2 files changed, 29 insertions(+), 65 deletions(-) commit 3d3efe257a52674f3cda0830c114627402dcd2bc Author: Jonathan Matthew Date: Wed Jun 10 17:43:34 2009 +1000 metadata: remove canSave from the dbus service metadata/rb-metadata-dbus-service.c | 62 ----------------------------------- 1 files changed, 0 insertions(+), 62 deletions(-) commit 275e42a3df79b455243fdee808e15ef220d4401a Author: Jonathan Matthew Date: Wed Jun 10 17:40:33 2009 +1000 metadata: use the cached set of saveable types for can_save (bug #437324) Now that the metadata client has a copy of the set of types the metadata service can save, we don't need to ask it for each individual type. This makes the song properties window appear noticeably quicker, since we don't have to start a metadata service process any more. metadata/rb-metadata-dbus-client.c | 47 ++++++++--------------------------- 1 files changed, 11 insertions(+), 36 deletions(-) commit c2c9cf37f8cf6bc811c69df72f11b14463f13d32 Author: Jonathan Matthew Date: Wed Jun 10 17:37:09 2009 +1000 metadata: after starting the metadata helper, ask what types it can save Since the set of saveable media types can't change within the lifetime of a metadata service process, we only need to ask once. metadata/rb-metadata-dbus-client.c | 49 ++++++++++++++++++++++++++++++++++++ 1 files changed, 49 insertions(+), 0 deletions(-) commit 376931ca675387e42e2f8e7d9e30ececf67e7f14 Author: Jonathan Matthew Date: Wed Jun 10 17:35:49 2009 +1000 metadata: fix metadata dbus test client's --can-save option metadata/test-metadata.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) commit 765e3a5689042428c2403db9150d83ea0369c277 Author: Jonathan Matthew Date: Wed Jun 10 17:34:44 2009 +1000 metadata: add rb_metadata_get_saveable_types method This will be used to cache information on what media types can be retagged. Not properly implemented in the dbus client yet. metadata/rb-metadata-dbus-client.c | 17 +++++++++ metadata/rb-metadata-dbus-service.c | 63 ++++++++++++++++++++++++++++++++++- metadata/rb-metadata-gst.c | 19 ++++++++++ metadata/rb-metadata.h | 1 + 4 files changed, 99 insertions(+), 1 deletions(-) commit eda60102aafff5a751c0e6ce44482dde3fc47416 Author: Jonathan Matthew Date: Tue Jun 9 15:32:22 2009 +1000 rhythmdb: add descriptive error messages when plugin installation fails When plugin installation fails or is cancelled, replace the existing error message for the file with one that gives the names of the plugins required. rhythmdb/rhythmdb.c | 34 ++++++++++++++++++++++++++++++---- 1 files changed, 30 insertions(+), 4 deletions(-) commit f90922daa8bd7abb6d04afdedc4bbee08a0918ac Author: Jonathan Matthew Date: Tue Jun 9 15:11:48 2009 +1000 metadata: remove the NOT_AUDIO and NOT_AUDIO_IGNORE errors The metadata backend no longer makes these distinctions itself, so it shouldn't have error codes for them. metadata/rb-metadata-dbus-service.c | 8 +------- metadata/rb-metadata.h | 2 -- metadata/test-metadata.c | 25 +++++++++++-------------- 3 files changed, 12 insertions(+), 23 deletions(-) commit cc39efb4f68403e1fbcb3922c96f99a1667917f9 Author: Jonathan Matthew Date: Tue Jun 9 15:08:22 2009 +1000 rhythmdb: only process missing plugin messages for audio files When processing metadata read results, check the media types present in the file before emitting the missing-plugin signal. For video and other non-audio files, just unblock the metadata reader without attempting to install plugins. Previous commits may have claimed to implement this but they were lying. rhythmdb/rhythmdb.c | 39 ++++++++++++++++++++++----------------- 1 files changed, 22 insertions(+), 17 deletions(-) commit 8fb5a09da6c6f0fadaa141099fbdce5815a09fc9 Author: Jonathan Matthew Date: Tue Jun 9 15:05:10 2009 +1000 metadata: rework error information in dbus protocol When sending metadata read results, we always send all the information whether there was an error or not, as some of it is useful in either case. There were also a few cases where we'd send an error in a place that the client wouldn't be expecting one. metadata/rb-metadata-dbus-client.c | 22 +++--- metadata/rb-metadata-dbus-service.c | 132 +++++++++++++--------------------- 2 files changed, 62 insertions(+), 92 deletions(-) commit 0cfb6cd190e0f4d7e36b6716bd2f8203525e9ef0 Author: Sandeep Shedmake Date: Tue Jun 9 11:06:18 2009 +0530 Updated Marathi Translations po/mr.po | 617 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 307 insertions(+), 310 deletions(-) commit aa340bfc97e0b50834d24e7c5866b98423d18883 Author: Jonathan Matthew Date: Tue Jun 9 10:33:13 2009 +1000 disable vala unless explicitly enabled configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 53cef2c233a5cfb8bd13bd98d34fe93a82402a8d Author: Mario Blättermann Date: Mon Jun 8 21:25:10 2009 +0200 Updated German translation po/de.po | 589 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 295 insertions(+), 294 deletions(-) commit 06b27a5bca9662b76427f2137b0f1da56285a0d3 Author: Jonathan Matthew Date: Mon Jun 8 20:07:24 2009 +1000 metadata: simplify tagger functions, drop human readable names Pass in everything the tagger function needs (the pipeline, the source element, and the tag list), and don't register human readable names for them any more, since we don't use that information anyway. Don't register non-taggable formats at all. Since we now have a simple association of media types to tagger functions, we can store them in a hash map rather than an array. metadata/rb-metadata-gst.c | 230 ++++++++++++++------------------------------ 1 files changed, 72 insertions(+), 158 deletions(-) commit 606ab6746597b8c1ca5d35e52db345bc46a67e8b Author: Jonathan Matthew Date: Mon Jun 8 20:04:33 2009 +1000 metadata: minor cleanups, add some useful debug info metadata/rb-metadata-gst.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) commit 2347fff837af53798868ee0f9dcab7ad3a7f2b5e Author: Jonathan Matthew Date: Mon Jun 8 19:56:59 2009 +1000 metadata: figure out media types for missing plugins We can reliably guess what media type the missing decoder or demuxer processes based on the GStreamer media type strings, so we use that information to update our knowledge of the media types in the file. We don't need to use the 'unknown-type' signal any more, since the missing plugin messages convey the same information more usefully. With this, we only run the codec installer for audio-only files (bug #537113). metadata/rb-metadata-gst-common.c | 55 +++++++++++++++++++++++++++++++++++++ metadata/rb-metadata-gst-common.h | 10 +++++++ metadata/rb-metadata-gst.c | 53 ++++++++++++++++++++--------------- 3 files changed, 95 insertions(+), 23 deletions(-) commit 8139664724a58253273bb869e8689e12f4fc0532 Author: Jonathan Matthew Date: Mon Jun 8 19:38:48 2009 +1000 metadata: move media type and file size checks out to rhythmdb This leaves us with no file type checks for podcast downloads, so m4a podcasts containing image sequences will no longer show up as 'failed'. (bug #479897) metadata/rb-metadata-gst.c | 138 +------------------------------------------- rhythmdb/rhythmdb.c | 99 ++++++++++++++++++++++++++----- 2 files changed, 85 insertions(+), 152 deletions(-) commit efdc2dca0daa83a306062f936e9b08661849b136 Author: Jonathan Matthew Date: Mon Jun 8 19:15:54 2009 +1000 metadata: move some generic utility code to a separate file Mostly to avoid copying and pasting it into the upcoming reimplementation of the metadata backend. metadata/Makefile.am | 4 +- metadata/rb-metadata-gst-common.c | 205 +++++++++++++++++++++++++++++++++++++ metadata/rb-metadata-gst-common.h | 44 ++++++++ metadata/rb-metadata-gst.c | 163 +----------------------------- 4 files changed, 254 insertions(+), 162 deletions(-) commit b934260e33d124069ee934235ea4e91e2c6e37aa Author: Jonathan Matthew Date: Mon Jun 8 18:55:39 2009 +1000 metadata: add audio, video, other flags Three new functions in the RBMetadata interface, returning whether the file contains audio, video, and 'other' data. This is the first step in moving the decision on whether to ignore a file outside the metadata reader. metadata/rb-metadata-dbus-client.c | 90 ++++++++++++++++++++++++----------- metadata/rb-metadata-dbus-service.c | 13 +++++ metadata/rb-metadata-gst.c | 22 +++++++-- metadata/rb-metadata.h | 3 + 4 files changed, 96 insertions(+), 32 deletions(-) commit 6f9139204b822b5d90dffcf9e0a8bb7785a00eb5 Author: Sergey Rudchenko Date: Mon Jun 8 16:25:53 2009 +1000 status-icon: remove unnecessary inclusion of rb-marshal.h (bug #585114) plugins/status-icon/rb-status-icon-plugin.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 09ec683391a6c1ebbda72f90fa4b889384713e5f Author: Jorge Gonzalez Date: Sun Jun 7 23:13:36 2009 +0200 Updated Spanish translation po/es.po | 300 ++++++++++++++++++++++++++++++-------------------------------- 1 files changed, 147 insertions(+), 153 deletions(-) commit 48e0d44c14ece84f214c2335e3362ff5409041e4 Author: John Iacona Date: Mon Jun 8 00:19:49 2009 +1000 new location for plugin UI elements: right side pane (bug #584182) This is slightly more complicated than the existing UI locations as it has a user-controllable width (via GtkPaned) and needs to be hidden when empty. bindings/python/rb.defs | 1 + data/rhythmbox.schemas | 11 +++++++++++ lib/rb-preferences.h | 1 + shell/rb-shell.c | 45 ++++++++++++++++++++++++++++++++++++++++++--- shell/rb-shell.h | 1 + 5 files changed, 56 insertions(+), 3 deletions(-) commit 117e67986d8d4e3105803926776c608e8a7b7e43 Author: A S Alam Date: Sun Jun 7 16:33:03 2009 +0530 updating Translation for Gurmukhi po/pa.po | 366 ++++++++++++++++++++++++++++++------------------------------- 1 files changed, 180 insertions(+), 186 deletions(-) commit 131e311c643af362638af1c584158f55cfbbfdca Author: Jonathan Matthew Date: Sun Jun 7 13:05:41 2009 +1000 add comments for messages about output device failure (bug #584770) backends/gstreamer/rb-player-gst-xfade.c | 1 + backends/gstreamer/rb-player-gst.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit 1926327fb84370a69b0725b51080bad961096246 Author: Jonathan Matthew Date: Sun Jun 7 13:04:13 2009 +1000 cd-recorder: remove full stops at the end of some messages (bug #584770) plugins/cd-recorder/rb-recorder-gst.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit a2789cbc9f0db4ccbf8d8499c873c8ce49ec8767 Author: Jonathan Matthew Date: Sun Jun 7 13:02:42 2009 +1000 don't ask for translations for '0' or '-' in UI files (bug #584770) data/ui/general-prefs.ui | 2 +- data/ui/podcast-feed-properties.ui | 16 ++++++++-------- data/ui/podcast-properties.ui | 18 +++++++++--------- plugins/audioscrobbler/audioscrobbler-prefs.ui | 4 ++-- 4 files changed, 20 insertions(+), 20 deletions(-) commit dbe3f06881dc62cf7e293fd5bb3ce37e71035633 Author: Jonathan Matthew Date: Sun Jun 7 12:43:31 2009 +1000 fix up some incorrectly sized icons (bug #584726) media-eject.png was 24x24 when it should have been 16x16 playlist.png was 30x28 when it should have been 32x32 data/icons/hicolor/16x16/actions/media-eject.png | Bin 579 -> 531 bytes data/icons/hicolor/32x32/places/playlist.png | Bin 919 -> 862 bytes 2 files changed, 0 insertions(+), 0 deletions(-) commit f336f365cdd302c42d1b8b568ed545aa213f4aae Author: Jonathan Matthew Date: Sun Jun 7 00:15:06 2009 +1000 remove some obsolete libs and cflags for the rhythmbox binary shell/Makefile.am | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) commit 85a75aebd752d4a5a31514cda5a00ca1ade6628f Author: Jonathan Matthew Date: Fri Jun 5 23:19:06 2009 +1000 RBHeader: use elapsed-nano-changed to update slider (bug #382906) widgets/rb-header.c | 24 ++++++++++++------------ 1 files changed, 12 insertions(+), 12 deletions(-) commit 8fb26c089a6d18dceee856b70c492627fa2c9ac4 Author: Jonathan Matthew Date: Fri Jun 5 23:15:44 2009 +1000 shell-player: add 'elapsed-nano-changed' signal This is emitted on every player tick (currently 5Hz), allowing things to be updated more than once per second and with subsecond precision. The existing elapsed-changed signal remains as it's useful too, and because it's part of the dbus interface. lib/rb-marshal.list | 1 + shell/rb-shell-player.c | 22 ++++++++++++++++++++++ shell/rb-shell-player.h | 1 + 3 files changed, 24 insertions(+), 0 deletions(-) commit e7def113b95d80f8339bea733d7f995049b7d092 Author: Sandeep Shedmake Date: Fri Jun 5 18:01:39 2009 +0530 Updated Marathi Translatiuons po/mr.po | 1278 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 664 insertions(+), 614 deletions(-) commit 7f1ef28cbeb50eb3d2b5c29256b0cbb9e36e8612 Author: Sandeep Shedmake Date: Fri Jun 5 09:43:44 2009 +0530 Updated Marathi Translatiuons po/mr.po | 2579 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 1413 insertions(+), 1166 deletions(-) commit eb529f721d13da10c51a710c5541a79498c118e6 Author: Jonathan Matthew Date: Fri Jun 5 13:14:55 2009 +1000 player-intf: use nanoseconds for times, add new param for play behaviour Convert all times used in the player interface to nanoseconds, so we can do fractional second crossfades and (theoretically) make the song position slider move more smoothly. Rather than overloading the crossfade duration to control how rb_player_play behaves, add a new enum parameter with values for crossfading, replacing the current stream, and playing after the current stream ends. backends/gstreamer/rb-player-gst-xfade.c | 92 +++++++++++++----------- backends/gstreamer/rb-player-gst.c | 13 ++-- backends/rb-player.c | 60 +++++++++++----- backends/rb-player.h | 33 ++++++--- bindings/python/rb.defs | 14 ++++- lib/rb-marshal.list | 1 + shell/rb-shell-player.c | 114 ++++++++++++------------------ 7 files changed, 181 insertions(+), 146 deletions(-) commit fdebe06c0cbd9337ba72fd259ed57e1eb76c7bdf Author: Jonathan Matthew Date: Fri Jun 5 12:17:13 2009 +1000 remove the 'crossfade between songs on the same album' setting data/ui/playback-prefs.ui | 60 ------------------------------------------ shell/rb-shell-player.c | 51 +++++++++-------------------------- shell/rb-shell-preferences.c | 26 ------------------ 3 files changed, 13 insertions(+), 124 deletions(-) commit 6555293c03bc577ca62456b470aaa86ea76748cb Author: A S Alam Date: Thu Jun 4 20:19:12 2009 +0530 updating Translation for Gurmukhi po/pa.po | 347 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 190 insertions(+), 157 deletions(-) commit ce19154f1fbf392e8ef5b682ff9fc5c5bbf56857 Author: Nguyễn Thái Ngọc Duy Date: Thu Jun 4 21:45:28 2009 +1000 vi.po: updated Vietnamese translation po/vi.po | 356 ++++++++++++++++++++++++++------------------------------------ 1 files changed, 151 insertions(+), 205 deletions(-) commit 0e09153368183de7c54f3977153f9f55a18d23c1 Author: Nguyễn Thái Ngọc Duy Date: Thu Jun 4 21:44:21 2009 +1000 vi.po: updated by intltool po/vi.po | 2805 ++++++++++++++++++++++++++++++++++++-------------------------- 1 files changed, 1651 insertions(+), 1154 deletions(-) commit e5765865f1b1495c9702e2591b4dd2b3f3ed4634 Author: Tomasz Dominikowski Date: Thu Jun 4 14:20:43 2009 +0200 Updated Polish translation po/pl.po | 3315 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 1752 insertions(+), 1563 deletions(-) commit 0f653264280de6a86a30f29f84ef9a3d92b2672f Author: Jorge Gonzalez Date: Wed Jun 3 23:08:49 2009 +0200 Updated Spanish translation po/es.po | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit 8690fc19bacafe8de7d1a6733a9b9c656f5b903b Author: Jorge Gonzalez Date: Wed Jun 3 20:07:22 2009 +0200 Updated Spanish translation po/es.po | 237 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 129 insertions(+), 108 deletions(-) commit d5e56c4f81943084a6251f23ed1eac03da6f4905 Author: Edgar Luna Date: Wed Jun 3 14:41:44 2009 +1000 loader: fix some error handling in the gio implementation plugins/rb/Loader.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 9127fafe536bf4278f8b3c9f33afdc40625d635f Author: Sergey Rudchenko Date: Wed Jun 3 10:59:10 2009 +1000 daap: trivial fix for building without gnome-keyring plugins/daap/rb-daap-source.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 398a30c7acbad05902ae8e75a91dfefbda0f2af6 Author: Jonathan Matthew Date: Tue Jun 2 23:12:42 2009 +1000 mtp: add a GStreamer source element for reading from MTP devices This just copies the file to /tmp (using a random filename, thus fixing bug #583700) in the NULL->READY transition, and deletes it in the READY->NULL transition (fixing bug #576005), and uses a filesrc element to handle the rest of the job. plugins/mtpdevice/Makefile.am | 1 + plugins/mtpdevice/rb-mtp-gst-src.c | 439 ++++++++++++++++++++++++++++++++++++ plugins/mtpdevice/rb-mtp-plugin.c | 6 + plugins/mtpdevice/rb-mtp-source.c | 208 +++++++---------- po/POTFILES.in | 1 + 5 files changed, 529 insertions(+), 126 deletions(-) commit a1861dcb121c9596c24c2f83b416e5d720430bcb Author: Manoj Kumar Giri Date: Tue Jun 2 18:30:37 2009 +0530 Added Oriya Language into the List po/LINGUAS | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 1d33d812fe0cc051c3a03d4a0723eaacc96f4950 Author: Manoj Kumar Giri Date: Tue Jun 2 18:29:14 2009 +0530 Updated Oriya Translation po/or.po | 4867 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 4867 insertions(+), 0 deletions(-) commit 96ad3f25436fcd460d845c5c5b9654b71d977415 Author: Manoj Kumar Giri Date: Tue Jun 2 18:29:03 2009 +0530 Added Entries for Oriya Translation & addition to LINGUAS. po/ChangeLog | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 24f2206863f80caa7bd4c3c0640756823dc7797b Author: Jonathan Matthew Date: Tue Jun 2 20:44:23 2009 +1000 audiocd: remove impl_try_playlist and just use rb_true_function plugins/audiocd/rb-audiocd-source.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) commit 926c090bf100be10a17f3b56e12e3d15493dd56d Author: Jonathan Matthew Date: Tue Jun 2 20:40:43 2009 +1000 xfade: rework stream reuse to provide more useful behaviour Rather than immediately reusing the old stream when opening the new one, wait until the new stream is started (if trying to crossfade) or until the old stream ends (for some approximation of gapless playback). backends/gstreamer/rb-player-gst-xfade.c | 109 ++++++++++++++++++++++-------- 1 files changed, 80 insertions(+), 29 deletions(-) commit 1c38b8067e89b1443903dd446cd37630385733a5 Author: Jonathan Matthew Date: Tue Jun 2 20:36:48 2009 +1000 encoder-gst: remove extract_track(), emit playing-source instead backends/gstreamer/rb-encoder-gst.c | 101 ++++++----------------------------- 1 files changed, 17 insertions(+), 84 deletions(-) commit 20bc487fd727e4984c20eac0585023acf93670ce Author: Jonathan Matthew Date: Tue Jun 2 20:34:22 2009 +1000 player-gst: remove cdda hackery, emit prepare-source instead backends/gstreamer/rb-player-gst.c | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-) commit 30011c47176c0f2e68a95038feefedbd1c77a24b Author: Jonathan Matthew Date: Tue Jun 2 20:33:59 2009 +1000 xfade: remove cdda hackery, emit prepare-source signal instead backends/gstreamer/rb-player-gst-xfade.c | 22 ++-------------------- 1 files changed, 2 insertions(+), 20 deletions(-) commit ae5d132b2952c5357f77bad46de6c23814a5afff Author: Jonathan Matthew Date: Tue Jun 2 20:30:56 2009 +1000 audiocd: make use of new prepare-source hooks Cleaned up some old dead code too. plugins/audiocd/rb-audiocd-plugin.c | 109 ++++++++++++++++++++-------------- 1 files changed, 64 insertions(+), 45 deletions(-) commit 4e8d220588df0ec0e3db9ffa60ce4334d7901d2f Author: Jonathan Matthew Date: Tue Jun 2 20:27:08 2009 +1000 encoder: add RBEncoderFactory singleton for plugin hooks Since a new encoder instance is created for each file being transferred, it's tricky for plugins to make use of any hooks we might add there. RBEncoderFactory acts as a well known place for hooks to be located. The only hook we have here so far is 'prepare-source', which does the same thing as the signal of that name on the player backends. backends/gstreamer/rb-encoder-gst.h | 2 +- backends/rb-encoder.c | 63 +++++++++++++++++++++++++++++++++++ backends/rb-encoder.h | 35 ++++++++++++++++++-- 3 files changed, 96 insertions(+), 4 deletions(-) commit 02682c1c6bfc42142234b821108edcf9e7f2ef9e Author: Jonathan Matthew Date: Tue Jun 2 20:23:09 2009 +1000 add 'prepare-source' signal to player backends This hook allows plugins to set any properties that may be required on the GStreamer source element that cannot be set through the URI. The only current example of this is setting the device property on cdda source elements. backends/gstreamer/rb-player-gst-xfade.c | 11 +++++++++++ backends/gstreamer/rb-player-gst-xfade.h | 3 +++ backends/gstreamer/rb-player-gst.c | 11 +++++++++++ backends/gstreamer/rb-player-gst.h | 3 +++ lib/rb-marshal.list | 1 + 5 files changed, 29 insertions(+), 0 deletions(-) commit aac6cd5a7c7b01dfac36c7589720737ca2bddbac Author: Jonathan Matthew Date: Tue Jun 2 20:18:38 2009 +1000 player-gst: implement stream reuse backends/gstreamer/rb-player-gst.c | 62 +++++++++++------------------------- 1 files changed, 19 insertions(+), 43 deletions(-) commit 42e3a941bab9c15335d4ff837347bdd02d00ad93 Author: Jonathan Matthew Date: Tue Jun 2 20:06:45 2009 +1000 xfade: make RBXFadeStream a GstBin, rather than having it hold one Override send_event for the stream bin so that events sent to the bin go to the element that provides the bin's src pad. This means we can seek on the bin, rather than having to dig out the pad to send the event to. Simplify the stream reuse handler in the audio CD plugin by taking advantage of this. backends/gstreamer/rb-player-gst-xfade.c | 173 ++++++++++++++++-------------- plugins/audiocd/rb-audiocd-plugin.c | 15 +--- 2 files changed, 96 insertions(+), 92 deletions(-) commit f951a211240c936682cac9f890d77b4d7609b692 Author: Jonathan Matthew Date: Tue Jun 2 20:00:18 2009 +1000 player-gst: add stream reuse signals The playbin backend can handle stream reuse the same way the crossfading backend does, which lets us move the cdda specific hackery out to the audio CD plugin. backends/gstreamer/rb-player-gst.c | 22 ++++++++++++++++++++++ backends/gstreamer/rb-player-gst.h | 22 +++++++++++++++++----- 2 files changed, 39 insertions(+), 5 deletions(-) commit 95c642e273ab80957502b534d53179c2799af4e4 Author: Nguyễn Thái Ngọc Duy Date: Tue Jun 2 16:22:07 2009 +1000 Update libnotify required version to 0.4.1 status-icon plugin uses notify_notification_attach_to_status_icon(). According to [1], you need at least 0.4.1 for that function [1] http://library.gnome.org/devel/libnotify/unstable/NotifyNotification.html#notify-notification-attach-to-status-icon configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 1bb4271da855100a3bbaf7383beb82e2648115a9 Author: Jonathan Matthew Date: Mon Jun 1 22:58:07 2009 +1000 status-icon: sync gconf and action status for config items (bug #584248) plugins/status-icon/rb-status-icon-plugin.c | 44 ++++++++++++++++++++++----- 1 files changed, 36 insertions(+), 8 deletions(-) commit 65ab85d37fc3111899f15d1b902cbf993199bf43 Author: Mario Blättermann Date: Mon Jun 1 11:23:18 2009 +0200 Updated German translation po/de.po | 302 ++++++++++++++++++++++++++++++-------------------------------- 1 files changed, 147 insertions(+), 155 deletions(-) commit 69c625560037fb53c186f526f769cbb2a089dabd Author: Jonathan Matthew Date: Mon Jun 1 18:17:27 2009 +1000 shell-player: remove idle handler used to emit notify::playing This is no longer needed as the playing-stream handler already emits notify::playing. The idle handler was a hack anyway, as there's no guarantee the stream would really be playing by the time it was called. shell/rb-shell-player.c | 23 ----------------------- 1 files changed, 0 insertions(+), 23 deletions(-) commit 6ffddc262511e11bb61ac91423057e59533c61bb Author: Jonathan Matthew Date: Mon Jun 1 18:13:55 2009 +1000 player-gst: emit playing-stream after setting playing=TRUE (bug #583394) playing-stream needs to be emitted at a point where rb_player_playing will return TRUE, otherwise bits of the UI get out of sync. backends/gstreamer/rb-player-gst.c | 15 ++++++--------- 1 files changed, 6 insertions(+), 9 deletions(-) commit 363ef6c9af734ff1d34e15e4fc9a4efccfe3bb65 Author: Szilveszter Ördög Date: Mon Jun 1 12:28:40 2009 +1000 status-icon: add 'next' action to notification popups (bug #331272) plugins/status-icon/rb-status-icon-plugin.c | 40 +++++++++++++++++++++++++-- 1 files changed, 37 insertions(+), 3 deletions(-) commit dc00b9a0232d43dee114a028bf27979214b1eb48 Author: Jonathan Matthew Date: Mon Jun 1 10:41:11 2009 +1000 daap: rework base URI construction for ipv6 compatibility (bug #584244) Rather than building a http:// URI and making libsoup parse it, we fill in the URI details separately. This is simpler and it also works properly when the IP address we're using happens to be IPv6. plugins/daap/rb-daap-connection.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 02159da160b33f0e411ec502f59213b12d445c73 Author: Jonathan Matthew Date: Mon Jun 1 10:21:11 2009 +1000 fix a variety of plugin linking problems All C plugins need to be linked against librhythmbox-core as well as any other libraries they need. plugins/daap/Makefile.am | 1 + plugins/generic-player/Makefile.am | 3 ++- plugins/iradio/Makefile.am | 4 +++- plugins/lirc/Makefile.am | 2 ++ plugins/mtpdevice/Makefile.am | 4 ++-- plugins/power-manager/Makefile.am | 2 ++ plugins/sample/Makefile.am | 2 ++ plugins/status-icon/Makefile.am | 5 ++++- plugins/visualizer/Makefile.am | 1 + 9 files changed, 19 insertions(+), 5 deletions(-) commit 9c1dbca993904ea32a752585ae194662dc86e190 Author: Mark Krapivner Date: Mon Jun 1 01:13:31 2009 +0300 fix a typo po/he.po | 3238 ++++++++++++++++++++++++++++++++++++++------------------------ 1 files changed, 1967 insertions(+), 1271 deletions(-) commit 0c9d36ecc5d8866e69cdbadbe29495fc243e9817 Author: Jonathan Matthew Date: Sun May 31 23:02:48 2009 +1000 generic-player: don't search for playlists unnecessarily (bug #583934) If we don't have any information at all about playlist support, there's no need to go searching the entire device for playlists. plugins/generic-player/rb-generic-player-source.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) commit bcc46318ec43753c45866549c79703eff27c6ec5