commit 1788b0182882c3804163404d8ca7f038936bd28d Author: Jonathan Matthew Date: Sun Feb 28 23:38:39 2010 +1000 Release 0.12.7 ChangeLog |10524 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- NEWS | 105 + README | 2 +- configure.ac | 2 +- 4 files changed, 10270 insertions(+), 363 deletions(-) commit 306928a19d246c67589ffc23cb5ba9efef87154e Author: Thanos Lefteris Date: Sat Feb 27 11:08:47 2010 -0800 Updated Greek translation po/el.po | 5224 ++++++++++++++++++++++++++++++++++++++++---------------------- 1 files changed, 3397 insertions(+), 1827 deletions(-) commit cc62beb518d76b5934c7549898a30d113fef49fb Author: Peteris Krisjanis Date: Sat Feb 27 12:31:59 2010 +0200 Updated Latvian translation. po/lv.po | 314 +++++++++++++------------------------------------------------- 1 files changed, 63 insertions(+), 251 deletions(-) commit e828531f86204d39fc6d9e4078b24fdc5494446c Author: Peteris Krisjanis Date: Sat Feb 27 01:11:45 2010 +0200 Updated Latvian translation. po/lv.po | 5109 +++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 3082 insertions(+), 2027 deletions(-) commit b5d82688d043942005a5c6a8bf6edce151f0fee4 Author: Jonathan Matthew Date: Fri Feb 26 22:24:47 2010 +1000 jamendo: switch to mp3 format for streams, since ogg is not available The Ogg Vorbis streams haven't been available for a while now, and it looks like they won't come back. Switching to MP3 at least gives us something that works for now. plugins/jamendo/jamendo/JamendoSaxHandler.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 02af4ceb08f8e7393efdfebe86e7b68e23cb8f1d Author: Jonathan Matthew Date: Fri Feb 26 22:23:40 2010 +1000 jamendo: fix gtk.show_uri() invocations so they actually work JamendoSource stores the shell as a GObject property, not a python attribute. plugins/jamendo/jamendo/JamendoSource.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 8b8a5b0335239d7773bac8c0b6492a1722c747a9 Author: Miloš Popović Date: Thu Feb 25 23:37:19 2010 +0100 Updated Serbian translations po/sr.po | 1241 ++++++++++++++++++++++++++++++++------------------------ po/sr@latin.po | 1241 ++++++++++++++++++++++++++++++++------------------------ 2 files changed, 1440 insertions(+), 1042 deletions(-) commit 09aac89c52a4b4f475fb21c315f790d3aa3c05b7 Author: Adi Roiban Date: Thu Feb 25 17:03:17 2010 +0200 Update Romanian translation po/ro.po | 2236 +++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 1256 insertions(+), 980 deletions(-) commit 672a89c95a68c1879fe0c09b0be1a5c1e608f68c Author: Luca Ferretti Date: Thu Feb 25 14:14:27 2010 +0100 Updated Italian translation po/it.po | 1183 +++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 710 insertions(+), 473 deletions(-) commit 2bb7822315b9b30a71520fdecf3481c2121d6012 Author: Adam Zimmerman Date: Wed Feb 24 19:21:53 2010 -0800 magnatune/jamendo: Use gobject.timeout_add_seconds for catalog updates plugins/jamendo/jamendo/JamendoSource.py | 4 ++-- plugins/magnatune/magnatune/MagnatuneSource.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 05f676dfa480c90c696f1f0e1f229efa24921eba Author: Jonathan Matthew Date: Tue Feb 23 06:35:20 2010 +1000 file-helpers: make rb_uri_handle_recursively work for single files Now that we're using it for general import operations, it needs to try as hard as possible to do something useful. lib/rb-file-helpers.c | 32 +++++++++++++++++++++++++------- 1 files changed, 25 insertions(+), 7 deletions(-) commit 9f25a3c43512d8af6a62ae0ba258197791ee97f1 Author: Marek Černocký Date: Mon Feb 22 21:47:35 2010 +0100 Update Czech translation po/cs.po | 975 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 532 insertions(+), 443 deletions(-) commit c884a26c901274c04400760354bd2e8fd94c3f83 Author: Jonathan Matthew Date: Mon Feb 22 22:06:00 2010 +1000 source-header: don't sync source state if there's no source (bug #607935) When there's no selected source (such as when visualization is active), it doesn't make any sense to sync the header with the source's state. shell/rb-source-header.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit ab102ef5a954eb87354c3467d1a35c8fa596242b Author: Charles Reiss Date: Sun Feb 21 18:44:51 2010 -0800 Avoid getting duplicate PyGtk-related symbols. Defines NO_IMPORT_{PYGOBJECT,PYGTK} everywhere pygobject.h or pygtk.h (respectively) are included except for shell/rb-python-module.c. This avoids problems with duplicate _PyGObject_API and _PyGtk_API symbols on platforms (like Darwin) whose linkers do not handle these well. bindings/python/override_common.c | 2 ++ bindings/python/rb.override | 1 + bindings/python/rhythmdb.override | 1 + shell/main.c | 2 ++ shell/rb-python-plugin.c | 1 + 5 files changed, 7 insertions(+), 0 deletions(-) commit 3492e8c68b0c2924d21baeccb7cdb7fc2ff65167 Author: Charles Reiss Date: Sun Feb 21 18:43:48 2010 -0800 Correct type of RBQueryCreatorCriteriaOption::val widgets/rb-query-creator-private.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 760203a908ee8832949804099172e5a6736d1993 Author: Gabor Kelemen Date: Mon Feb 22 11:11:03 2010 +0100 Hungarian translation updated po/hu.po | 186 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 102 insertions(+), 84 deletions(-) commit 394691bad26e6434e499897092440bca84db72e4 Author: Claude Paroz Date: Mon Feb 22 10:45:56 2010 +0100 Updated French translation po/fr.po | 38 ++++++++++++++++++++++---------------- 1 files changed, 22 insertions(+), 16 deletions(-) commit 01b80834cb5f135940a27b4c0a14bdb1b219ecad Author: Claude Paroz Date: Mon Feb 22 10:37:24 2010 +0100 Updated French translation po/fr.po | 2111 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 1135 insertions(+), 976 deletions(-) commit 8e77270fa73334a93360a72a847e5b3eb3bc99a6 Author: Bastien Nocera Date: Mon Feb 22 00:42:08 2010 +0000 Fix installation of the sendto plugin We need to install the .py file, and put the .rb-plugin file in the right directory as well. plugins/sendto/Makefile.am | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) commit 557ff6bb512a3b27788cc11fd275a253d99988f6 Author: Bastien Nocera Date: Mon Feb 22 00:28:02 2010 +0000 Fix linkage against librhythmdb.la libm is required for librhythmdb, otherwise the test applications will fail to link when using a pedantic linker. https://bugzilla.gnome.org/show_bug.cgi?id=610643 rhythmdb/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit a5accaf217db9d47bb2facc0af9f5afef3db4425 Author: Jonathan Matthew Date: Mon Feb 22 06:55:07 2010 +1000 shell-player: check strings are valid utf-8 before emitting dbus signals Sending invalid utf-8 strings over a dbus connection causes it to disconnect, which is generally a bad thing. See bug 601171. shell/rb-shell-player.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit e8590980514590565fc3f63cb2d06ec0ca7f340f Author: Bruce Cowan Date: Sun Feb 21 20:53:46 2010 +0000 Update British English translation po/en_GB.po | 2567 ++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 1480 insertions(+), 1087 deletions(-) commit f71a546731c9b8e880ae5b21c57cc53772053f6e Author: Christophe Fergeau Date: Sun Feb 21 14:56:45 2010 +0100 drop 2 unused variables remote/dbus/rb-client.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) commit 78e52f96f07fee2665ed83b84fca61d928d5b076 Author: Petr Kovar Date: Sun Feb 21 19:40:14 2010 +0100 Update Czech translation by Marek Cernocky Reviewed by: Lucas Lommer. po/cs.po | 823 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 422 insertions(+), 401 deletions(-) commit f3e683bdec6763357c2d4e21f51e4bfa4c6406cf Author: Piotr Drąg Date: Sun Feb 21 18:31:27 2010 +0100 Updated Polish translation po/pl.po | 2623 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 1452 insertions(+), 1171 deletions(-) commit 5958a34b31522e588f9bbfe09298677ee9885dd2 Author: Mario Blättermann Date: Sun Feb 21 16:45:49 2010 +0100 Updated German translation po/de.po | 198 +++++++++++++++++++++++++++----------------------------------- 1 files changed, 87 insertions(+), 111 deletions(-) commit 1d1f83e87f06b1238d602f7c990be2b109769c42 Author: Daniel Nylander Date: Sun Feb 21 13:30:59 2010 +0100 Updated Swedish translation po/sv.po | 1234 ++++++++++++++++++++++++++++++++++++-------------------------- 1 files changed, 712 insertions(+), 522 deletions(-) commit b622305a279ed8a952b92e20a9ed3caf4ef818e8 Author: Fran Diéguez Date: Sun Feb 21 11:59:02 2010 +0100 Updated Galician Translation po/gl.po | 554 ++++++++++++++++++++++++++++++++++++++------------------------ 1 files changed, 344 insertions(+), 210 deletions(-) commit 9a3e41ae81018ebbf82a26c135a5dc0139da0ebe Author: Jorge González Date: Sun Feb 21 11:33:05 2010 +0100 Updated Spanish translation po/es.po | 173 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 87 insertions(+), 86 deletions(-) commit 6cf4def3acf95ac757918cf5c1c6b7a1e638e45e Author: Jonathan Matthew Date: Sun Feb 21 19:48:00 2010 +1000 python: add bindings for RBSearchEntry bindings/python/Makefile.am | 1 + bindings/python/rb.defs | 47 +++++++++++++++++++++++++++++++++++++++++++ bindings/python/rb.override | 1 + 3 files changed, 49 insertions(+), 0 deletions(-) commit 0abcbbca0dd0c8473f79d40614d5429d47d0f6b8 Author: Jonathan Matthew Date: Sun Feb 21 17:24:44 2010 +1000 audiocd: add checkbox column for selecting tracks to extract (bug #537483) The 'extract' column controls the set of tracks that are extracted when the 'extract to library' action is invoked. The state of the checkbox is stored in entry type specific data. The column header includes a checkbox, and clicking on that toggles its state, and sets the state of all tracks to match the new state. Individual tracks can be toggled by clicking on the checkbox in the entry view. plugins/audiocd/rb-audiocd-source.c | 159 +++++++++++++++++++++++++++++++++-- 1 files changed, 151 insertions(+), 8 deletions(-) commit 419552b4370c26c13a01c2bcfda6d239a0dc5078 Author: Jonathan Matthew Date: Sun Feb 21 17:07:14 2010 +1000 audiocd: move the 'extract to library' action into RBAudioCDSource plugins/audiocd/audiocd-ui.xml | 2 +- plugins/audiocd/rb-audiocd-source.c | 109 ++++++++++++++++++++++++++--------- shell/rb-removable-media-manager.c | 45 -------------- 3 files changed, 82 insertions(+), 74 deletions(-) commit 64a039650854ae24df267eaa185b0ef97ae4e326 Author: Jonathan Matthew Date: Sun Feb 21 16:41:48 2010 +1000 audiocd: load UI after creating a source for the first time plugins/audiocd/rb-audiocd-plugin.c | 36 ++++++++++++++++++---------------- 1 files changed, 19 insertions(+), 17 deletions(-) commit 9d1ef7a315897ec92013d85c6acf2d5d4624f5e8 Author: Jonathan Matthew Date: Sun Feb 21 16:36:06 2010 +1000 audiocd: change return type of rb_audiocd_source_new to RBSource It's just simpler this way. plugins/audiocd/rb-audiocd-plugin.c | 2 +- plugins/audiocd/rb-audiocd-source.c | 4 ++-- plugins/audiocd/rb-audiocd-source.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) commit 907a91e827542fcc4089dabf69df2095bae6ba36 Author: Jonathan Matthew Date: Sun Feb 21 16:21:43 2010 +1000 entry-view: only make columns clickable if they have a sort function widgets/rb-entry-view.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) commit 532aeb52d2051ed6c3dcc100a3068e0c17653ce5 Author: Jonathan Matthew Date: Sun Feb 21 16:20:15 2010 +1000 audiocd: don't try to set the year when no value is provided plugins/audiocd/rb-audiocd-source.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) commit 733698890a79bb1df1c56853104d52051e9cdac8 Author: Jonathan Matthew Date: Sun Feb 21 16:18:05 2010 +1000 rhythmdb: fix handling of empty strings when looking for sort values If none of the sort properties has a non-empty value, use the display property, which is almost certainly going to be empty too. rhythmdb/rhythmdb-property-model.c | 9 ++++- tests/test-rhythmdb-property-model.c | 75 ++++++++++++++++++++++++++++++++++ 2 files changed, 83 insertions(+), 1 deletions(-) commit b36fb6475b30820e08a46c6f3e4f6af88577b9bb Author: Uri Sivan Date: Sun Feb 21 16:01:51 2010 +1000 header: fix display of RTL track names in LTR locales (bug #518540) We insert an LRM or RLM (according to the widget direction) to force the header text to be displayed in the correct direction even when the start of the text (the track title) has the opposite direction. widgets/rb-header.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) commit f57dfa9e31748b742c0d8a1c4f107d6fef487063 Author: Jonathan Matthew Date: Sun Feb 21 10:16:50 2010 +1000 metadata: fix compilation with older versions of GStreamer gst_message_unref only recently became a function. Passing it as a function pointer doesn't work with versions where it was a macro, so we can't do that yet. metadata/rb-metadata-gst.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) commit 12c169318c51b81b66c15432681e012c162ecce8 Author: Andrej Žnidaršič Date: Sat Feb 20 22:22:04 2010 +0100 Updated Slovenian translation po/sl.po | 421 ++++++++++++++++++++++++++++++++++++++------------------------ 1 files changed, 261 insertions(+), 160 deletions(-) commit 1a698310e0cb126eb9e6c033d99baa11574726bb Author: Jonathan Matthew Date: Sat Feb 20 11:44:09 2010 +1000 daap: add user-agent header to requests (bug #610440) patch by tomgarper@gmx.com plugins/daap/rb-daap-connection.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 506fe6b0fba6c629b998aebddbcd3b2063cd4635 Author: Adam Zimmerman Date: Fri Feb 19 12:55:50 2010 -0800 magnatune: Use copy_async for catalog downloading plugins/magnatune/magnatune/MagnatuneSource.py | 109 ++++++++++++++---------- 1 files changed, 63 insertions(+), 46 deletions(-) commit 560fba7f4e7e1f13d1b01068221662880cd7a1c5 Author: Adam Zimmerman Date: Fri Feb 19 11:33:51 2010 -0800 magnatune: Simplify download progress code plugins/magnatune/magnatune/MagnatuneSource.py | 34 +++++++---------------- 1 files changed, 11 insertions(+), 23 deletions(-) commit ea4db9cae4dde96c83b873a16292c1f7d223897c Author: Adam Zimmerman Date: Fri Feb 19 01:05:46 2010 -0800 magnatune: Use gio.File.copy_async to download albums This has several benefits: - uses separate callbacks for progress and completion (code clarity) - makes the transfer completely async, instead of using python's blocking file.write() calls - lets us move towards using gio for all I/O, rather than a mix of gio and python calls (still more todo here) plugins/magnatune/magnatune/MagnatuneSource.py | 111 +++++++++++++---------- 1 files changed, 63 insertions(+), 48 deletions(-) commit a5025bfbde50ad8ec6ef1121d3f2c34bb05743c2 Author: Adam Zimmerman Date: Thu Feb 18 16:09:31 2010 -0800 magnatune: Code cleanup - some whitespace fixes - make callback functions into inner functions - make resuming in-progress downloads work again plugins/magnatune/magnatune/BuyAlbumHandler.py | 1 - plugins/magnatune/magnatune/MagnatuneSource.py | 459 +++++++++++------------ plugins/magnatune/magnatune/TrackListHandler.py | 3 +- plugins/magnatune/magnatune/__init__.py | 64 ++-- 4 files changed, 252 insertions(+), 275 deletions(-) commit eb3ec4c513e3b7427db6f3c47f556a6182729bed Author: Jonathan Matthew Date: Fri Feb 19 20:45:59 2010 +1000 artdisplay: remove Discogs cover art search Unfortunately we placed too much load on the discogs search servers, so they had to block all requests from rhythmbox. It appears there is no way we can cut down the volume of requests to an acceptable level, so we cannot use discogs as a cover image provider. plugins/artdisplay/artdisplay/CoverArtDatabase.py | 3 +- .../artdisplay/artdisplay/DiscogsCoverArtSearch.py | 287 -------------------- plugins/artdisplay/artdisplay/Makefile.am | 1 - po/POTFILES.in | 1 - 4 files changed, 1 insertions(+), 291 deletions(-) commit 484387b66df804505487ac248a3d068bfafbd698 Author: Jorge González Date: Wed Feb 17 22:39:21 2010 +0100 Updated Spanish translation po/es.po | 159 +++++++++++++++++++++++++++++++------------------------------ 1 files changed, 81 insertions(+), 78 deletions(-) commit 456d79808934e8d51792af56b8f9bd83ffe0703c Author: Martin Schaaf Date: Wed Feb 17 23:05:29 2010 +1000 removable-media: include track number in duplicate check (bug #609908) sources/rb-removable-media-source.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) commit 2c273a43dc1ac8794a8307ec1fd568015e467cfd Author: Jonathan Matthew Date: Wed Feb 17 22:56:33 2010 +1000 rhythmdb: skip replaygain properties in rhythmdb_entry_gather_metadata rhythmdb/rhythmdb.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) commit 9015490d77fe16f9e19997505bfdcfbe0faee073 Author: Jonathan Matthew Date: Wed Feb 17 22:36:44 2010 +1000 remove stray .arch-inventory file remote/dbus/.arch-inventory | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) commit 9ea95a713d26ced6f61c7d113151fb35846a4cde Author: Jonathan Matthew Date: Wed Feb 17 21:30:54 2010 +1000 iradio: remove cbc.ca streams as they are no longer available (bug #609916) plugins/iradio/iradio-initial.pls | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) commit eb113f094fd90eadbaa714b3c4e24f733515bb64 Author: Mattias Põldaru Date: Wed Feb 17 13:11:05 2010 +0200 Estonian translation updated po/et.po | 506 ++++++++++++++++++++++++++++++++++++++++---------------------- 1 files changed, 324 insertions(+), 182 deletions(-) commit 0d4feea5c9d8de652709b6468153ce5d2ffc8da9 Author: Mario Blättermann Date: Wed Feb 17 11:52:54 2010 +0100 Updated German translation po/de.po | 438 ++++++++++++++++++++++++++++++++++++++++---------------------- 1 files changed, 283 insertions(+), 155 deletions(-) commit 0ff31776fe91b28fc20af41d3fb97bdbc7731c87 Author: Adam Zimmerman Date: Tue Feb 16 18:12:32 2010 -0800 magnatune: Make keyring usage more robust Handle the case where the user disallows access to the keyring, or some other error occurs. Also handle the cases where the account info can't be parsed out of the secret, or no secret exists in the keyring. plugins/magnatune/magnatune/MagnatuneSource.py | 20 ++++++++-- plugins/magnatune/magnatune/__init__.py | 45 ++++++++++++++++-------- 2 files changed, 46 insertions(+), 19 deletions(-) commit 89a48d0d63e0f14234c1d74d47ee97c9b5877211 Author: Adam Zimmerman Date: Tue Feb 16 15:10:36 2010 -0800 magnatune: Use keyring to store account info data/rhythmbox.schemas | 22 ------- plugins/magnatune/magnatune/MagnatuneSource.py | 56 ++++++++++++------- plugins/magnatune/magnatune/TrackListHandler.py | 11 ++-- plugins/magnatune/magnatune/__init__.py | 70 +++++++++++++++++++---- 4 files changed, 101 insertions(+), 58 deletions(-) commit 755f8438e7e27683d6feff1ceb1f61e45f5bc91a Author: Jorge González Date: Tue Feb 16 18:39:48 2010 +0100 Updated Spanish translation po/es.po | 280 +++++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 185 insertions(+), 95 deletions(-) commit e0557ac6da3a24265e199d8031c8fedea57dd1b7 Author: Gabor Kelemen Date: Tue Feb 16 14:00:31 2010 +0100 Hungarian translation updated po/hu.po | 179 ++++++++++++++++++++++++++++++++++++++++++-------------------- 1 files changed, 122 insertions(+), 57 deletions(-) commit 6284cbe86211f3b49db13b5abd7fb3973dd6d866 Author: Gabor Kelemen Date: Tue Feb 16 13:51:13 2010 +0100 Add gettext/glade type to an .ui file po/POTFILES.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 362049a4525bd25bdbaeb89d5b5807cd637c1367 Author: Gabor Kelemen Date: Tue Feb 16 13:48:13 2010 +0100 Hungarian translation updated po/hu.po | 743 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 370 insertions(+), 373 deletions(-) commit b9062fb41c4f568cd5864e72ae51c392ffb6ff3b Author: Jonathan Matthew Date: Tue Feb 16 22:00:18 2010 +1000 query-creator: add context to criteria and sort order names (bug #604771) widgets/rb-query-creator-properties.c | 50 ++++++++++++++++---------------- widgets/rb-query-creator.c | 4 +- 2 files changed, 27 insertions(+), 27 deletions(-) commit 8a724ddef91b691358dabbb83859b4c53b81c76c Author: Mario Blättermann Date: Mon Feb 15 17:13:09 2010 +0100 Updated German translation po/de.po | 909 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 489 insertions(+), 420 deletions(-) commit b86a4670dcc7f699fa8a94a1e9aa5f5ecaa0c11c Author: Jorge González Date: Mon Feb 15 12:02:39 2010 +0100 Updated Spanish translation po/es.po | 500 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 252 insertions(+), 248 deletions(-) commit ccf5e045bb11a0d6abe7f954d09736728e5cd80e Author: Marek Černocký Date: Mon Feb 15 10:19:30 2010 +0100 Update Czech translation po/cs.po | 427 ++++++++++++++++++++++++------------------------------------- 1 files changed, 168 insertions(+), 259 deletions(-) commit d6f27115ebe3a15275e647fc5723a11180806965 Author: Adam Zimmerman Date: Sun Feb 14 19:41:10 2010 -0800 magnatune: Unzip downloaded albums in a separate thread plugins/magnatune/magnatune/MagnatuneSource.py | 45 +++++++++++++----------- 1 files changed, 24 insertions(+), 21 deletions(-) commit 30ae537e6849043dbb43ae027e6d88f2f746ee18 Author: Adam Zimmerman Date: Sat Feb 13 15:57:34 2010 -0800 magnatune: Allow user's library location to be an arbitrary URI plugins/magnatune/magnatune/MagnatuneSource.py | 28 +++++++---------------- 1 files changed, 9 insertions(+), 19 deletions(-) commit 5df73ad6de86a02a1cefc50b33f63e6764b210cd Author: Jonathan Matthew Date: Sun Feb 14 21:52:44 2010 +1000 metadata: set tag writing elements to PAUSED state We no longer build the tag writing pipeline in NULL state, so we need to sync the newly-added tag writing elements with the rest of the pipeline. metadata/rb-metadata-gst.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit e478d4994e83b6a3a7eac6805c2998e23cf83664 Author: Uri Sivan Date: Sun Feb 14 15:41:30 2010 +1000 status-icon: use direction-neutral templates when necessary (bug #609767) When the localised template strings ("by x", "from y") are in one direction but the artist and album strings being substituted in are in the other, the localised templates will look weird and wrong. Instead, we use direction neutral templates, just separating the album and artist with a slash, so what's displayed at least makes sense. plugins/status-icon/rb-status-icon-plugin.c | 65 +++++++++++++++++++++++--- 1 files changed, 57 insertions(+), 8 deletions(-) commit 0072ca795bb84fe2597a1ebc8dd6eb9094a80637 Author: Jonathan Matthew Date: Sat Feb 13 18:47:02 2010 +1000 distribute the man pages data/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 5fd3c3ac7af43d3bd67c223f4b62511b1dc7c946 Author: Jamie Nicol Date: Mon Feb 8 10:56:54 2010 +0000 play-order: do not try to unref null query model Stop unreffing new_model in rb_play_order_query_model_changed if both the old model and new_model are NULL. shell/rb-play-order.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 7fb07944bb89651186992e12befd70ec572f6d3b Author: Jonathan Matthew Date: Fri Feb 12 23:03:24 2010 +1000 library: use RhythmDBImportJob when adding to the database (bug #547174) RhythmDBImportJob provides progress information, so we can display that to the user, and allows cancellation (not exposed through the interface yet). RhythmDBImportJob requires all URIs to be added before it starts importing, but rb_source_add_uri only gets them one at a time. To work around this, we use a short timeout to collect as many as possible. In case a new job is started before an existing one finishes, we keep a list of them so we can cancel all outstanding jobs on shutdown. Only the progress information from the most recently started job is displayed. sources/rb-library-source.c | 110 +++++++++++++++++++++++++++++++++++++++++- 1 files changed, 107 insertions(+), 3 deletions(-) commit 1e9ebb594391fb95c5066152121c218d4080d123 Author: Jonathan Matthew Date: Fri Feb 12 23:02:50 2010 +1000 source: add helper method for setting status from an import job plugins/generic-player/rb-generic-player-source.c | 10 +------- sources/rb-source.c | 24 +++++++++++++++++++++ sources/rb-source.h | 6 +++++ 3 files changed, 31 insertions(+), 9 deletions(-) commit 57abdf5e722fe7b07030617d7c2fcc5b26da114c Author: Adam Zimmerman Date: Fri Feb 12 11:26:43 2010 -0800 magnatune: Redirect the user to the correct URLs Let the user sign up for an account, and pass our partner ID as part of the URL. Also fix the URL parameter used when the user purchases an album. plugins/magnatune/magnatune-prefs.ui | 6 +++--- plugins/magnatune/magnatune/MagnatuneSource.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) commit 8abe108c3c0200367efd0fc0b11e1bfd2a0f92ef Author: Andrej Žnidaršič Date: Fri Feb 12 14:12:39 2010 +0100 Updated Slovenian translation po/sl.po | 678 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 353 insertions(+), 325 deletions(-) commit c5d690988f6a366164100114584a4d79bf87a3ce Author: Fran Diéguez Date: Fri Feb 12 10:18:55 2010 +0100 Updated Galician Translation po/POTFILES.in | 1 - po/gl.po | 2185 ++++++++++++++++++++++++++++++-------------------------- 2 files changed, 1179 insertions(+), 1007 deletions(-) commit 48bb6c29ea84b4736fb34f0a9cddc430715e4eeb Author: Adam Zimmerman Date: Wed Feb 10 16:00:40 2010 -0800 Notify the user when their downloads are finished. plugins/magnatune/magnatune/MagnatuneSource.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit c45cfafb7b80a763e400bbd6bb89c4e946653608 Author: Adam Zimmerman Date: Wed Feb 10 11:15:20 2010 -0800 Make sure the cancel button is greyed out when all downloads are finished. plugins/magnatune/magnatune/MagnatuneSource.py | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) commit 8f2eca4511adec3d895e39e82d06ef7b64b1aa73 Author: Adam Zimmerman Date: Tue Feb 9 14:45:31 2010 -0800 (Mostly) enable downloads for download accounts. The purchase confirmation dialog has been removed, since we don't really need any information from the user. There are 2 functions that seem to have been removed from the rb module, which are required for the download to complete successfully. Also, use sku in name of partially downloaded file and in_progress file, because the basename for current downloads is always api-download.php. plugins/magnatune/Makefile.am | 1 - plugins/magnatune/magnatune-purchase.ui | 581 ------------------------ plugins/magnatune/magnatune/BuyAlbumHandler.py | 7 +- plugins/magnatune/magnatune/MagnatuneSource.py | 130 +----- plugins/magnatune/magnatune/__init__.py | 2 +- 5 files changed, 30 insertions(+), 691 deletions(-) commit 10341d7c8da06cbd6f5b08c5e5d744f41df279b4 Author: Adam Zimmerman Date: Tue Feb 9 12:11:31 2010 -0800 Let the magnatune server know where we're coming from. plugins/magnatune/magnatune/MagnatuneSource.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit a131dfb2e5856abd7f1c063fcface115b8b4a0ad Author: Adam Zimmerman Date: Tue Feb 9 12:10:37 2010 -0800 Remove old references to gnome-keyring. plugins/magnatune/magnatune/MagnatuneSource.py | 9 --------- plugins/magnatune/magnatune/__init__.py | 3 --- 2 files changed, 0 insertions(+), 12 deletions(-) commit 578cf1d5f976af7345b600f88f9b58f9ba2ee8b4 Author: Adam Zimmerman Date: Thu Dec 24 17:08:17 2009 -0800 Get streaming downloads to work. The preferences for download accounts are in place, but the API stuff hasn't been connected yet. Streaming accounts work just fine. data/rhythmbox.schemas | 33 +++ plugins/magnatune/magnatune-prefs.ui | 330 ++++++----------------- plugins/magnatune/magnatune/MagnatuneSource.py | 4 +- plugins/magnatune/magnatune/TrackListHandler.py | 17 +- plugins/magnatune/magnatune/__init__.py | 173 ++++-------- 5 files changed, 191 insertions(+), 366 deletions(-) commit 2fd3ab9ab052becb880508f629b242448ebd69c2 Author: Adam Zimmerman Date: Thu Dec 24 14:33:34 2009 -0800 Remove album purchase option. Magnatune no longer supports buying albums with a credit card over their API. This patch just sends the user to a page so they can purchase the albums. The purchase/download code is left in because it will be used when download accounts are added in a few commits. data/rhythmbox.schemas | 11 ---------- plugins/magnatune/magnatune/MagnatuneSource.py | 24 ++++++---------------- plugins/magnatune/magnatune/TrackListHandler.py | 4 +-- plugins/magnatune/magnatune/__init__.py | 9 +------ 4 files changed, 10 insertions(+), 38 deletions(-) commit ed716f2d850219ca56c830fdbd8282be8ad7bb07 Author: Jonathan Matthew Date: Thu Feb 11 22:52:37 2010 +1000 update POTFILES.in for recent changes po/POTFILES.in | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) commit 72919db07904ef1a260383b4d0f2e2ca57b77e1a Author: Jonathan Matthew Date: Thu Feb 11 22:04:45 2010 +1000 generic-player: convert into a media player source, add properties dialog plugins/generic-player/Makefile.am | 5 +- plugins/generic-player/generic-player-info.ui | 212 +++++++++++++++++++++ plugins/generic-player/generic-player-ui.xml | 1 + plugins/generic-player/rb-generic-player-plugin.c | 16 ++- plugins/generic-player/rb-generic-player-source.c | 197 +++++++++++++++++--- plugins/generic-player/rb-generic-player-source.h | 10 +- plugins/generic-player/rb-nokia770-source.c | 3 +- plugins/generic-player/rb-nokia770-source.h | 6 +- plugins/generic-player/rb-psp-source.c | 3 +- plugins/generic-player/rb-psp-source.h | 6 +- 10 files changed, 421 insertions(+), 38 deletions(-) commit 4d1d0ee2adb5d83d8210f9ec108c89b60e423710 Author: Jonathan Matthew Date: Thu Feb 11 22:04:15 2010 +1000 mtp: add audio format descriptions to the properties dialog plugins/mtpdevice/mtp-info.ui | 28 +++++++++++++++++++++++++++- plugins/mtpdevice/rb-mtp-source.c | 17 +++++++++++++++++ 2 files changed, 44 insertions(+), 1 deletions(-) commit 226022bd187560a7c267bfe7d5152cac21f00309 Author: Jonathan Matthew Date: Thu Feb 11 22:03:50 2010 +1000 ipod: add supported audio formats to the properties dialog plugins/ipod/ipod-info.ui | 29 ++++++++++++++++++++++++++++- plugins/ipod/rb-ipod-source.c | 17 +++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletions(-) commit 0fdef566600dcc09d37694a85fdbb7a5737580d0 Author: Jonathan Matthew Date: Thu Feb 11 21:53:38 2010 +1000 removable-media: provide list of device audio format descriptions Uses gio's content type functions to translate mime-ish types to human-friendly descriptions. sources/rb-removable-media-source.c | 27 +++++++++++++++++++++++++++ sources/rb-removable-media-source.h | 2 +- 2 files changed, 28 insertions(+), 1 deletions(-) commit 655ca6d1339b1d00a26b26b005d09cca81cb4540 Author: Petr Kovar Date: Thu Feb 11 03:18:09 2010 +0100 Update Czech translation by Marek Cernocky po/cs.po | 315 +++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 189 insertions(+), 126 deletions(-) commit 6ffac406e59db2162215e0607311752afcee62fe Author: Jonathan Matthew Date: Thu Feb 11 07:03:13 2010 +1000 python: include gdk type definitions This makes bindings for rb_source_set_pixbuf and rb_shell_notify_custom work. bindings/python/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 38a0336ae087ee1c32dbd3617f91679a65be7109 Author: Jonathan Matthew Date: Wed Feb 10 23:21:52 2010 +1000 python: add rb_sanitize_uri_for_filesystem and rb_uri_create_parent_dirs bindings/python/rb.defs | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) commit 62b30044fa5f591ac1614a65f7a09f1af8925012 Author: Jonathan Matthew Date: Wed Feb 10 23:04:01 2010 +1000 remove rb.show_uri(), call gtk.show_uri() directly As a tiny bonus, we now pass in the screen parameter correctly. plugins/context/context/ContextView.py | 2 +- plugins/jamendo/jamendo/JamendoSource.py | 4 ++-- plugins/magnatune/magnatune/MagnatuneSource.py | 6 ++++-- plugins/rb/__init__.py | 8 -------- 4 files changed, 7 insertions(+), 13 deletions(-) commit be6796fce07227801e3515b448c2be6d9c058b57 Author: Jonathan Matthew Date: Wed Feb 10 23:02:28 2010 +1000 remove EggTrayIcon, always use GtkStatusIcon configure.ac | 8 - plugins/status-icon/Makefile.am | 8 - plugins/status-icon/eggtrayicon.c | 559 --------------------------- plugins/status-icon/eggtrayicon.h | 80 ---- plugins/status-icon/rb-status-icon-plugin.c | 82 +---- plugins/status-icon/rb-tray-icon.c | 479 ----------------------- plugins/status-icon/rb-tray-icon.h | 86 ---- 7 files changed, 2 insertions(+), 1300 deletions(-) commit bac21d24b41f935f3ee2bbcaf9297a2f2180dac3 Author: Jonathan Matthew Date: Wed Feb 10 22:59:51 2010 +1000 remove libsexy GtkEntry in gtk+ 2.16 replaces SexyIconEntry, and that was the last thing we were using. configure.ac | 24 - doc/reference/Makefile.am | 1 - widgets/Makefile.am | 8 +- widgets/libsexy/Makefile.am | 19 - widgets/libsexy/sexy-icon-entry.c | 960 ------------------------------------- widgets/libsexy/sexy-icon-entry.h | 100 ---- 6 files changed, 1 insertions(+), 1111 deletions(-) commit 6fdf7588bdf91184529f71df79f71859377326cb Author: Jonathan Matthew Date: Wed Feb 10 22:57:32 2010 +1000 require gtk+ 2.16 and glib 2.18 configure.ac | 4 ++-- lib/rb-file-helpers.c | 33 --------------------------------- plugins/audiocd/rb-audiocd-source.c | 8 -------- widgets/rb-search-entry.c | 13 ------------- 4 files changed, 2 insertions(+), 56 deletions(-) commit 381fdfed50adb5f773912bc5b7c1cd51a2e1b667 Author: Jorge González Date: Sun Feb 7 14:31:24 2010 +0100 Updated Spanish translation po/es.po | 276 +++++++++++++++++++++++++++++++++++++++----------------------- 1 files changed, 173 insertions(+), 103 deletions(-) commit 6c172f87c6c44a4947389ec57813f75e9eefd669 Author: Luca Ferretti Date: Sun Feb 7 12:54:49 2010 +0100 Updated to match new files from replaygain po/POTFILES.in | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit 09735580dcf2d3e94134ea829ed86306da42209f Author: Jonathan Matthew Date: Sun Feb 7 21:16:17 2010 +1000 rhythmdb: don't leak GFiles when setting up file monitoring rhythmdb/rhythmdb-monitor.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit a36e080618bc5919c0e1b0789ecb3b4f625fed31 Author: Jonathan Matthew Date: Sun Feb 7 17:01:35 2010 +1000 replaygain: new plugin using GStreamer's ReplayGain elements This plugin uses the rgvolume and rglimiter elements to process ReplayGain tags and adjust the output volume accordingly. It provides configuration options for selecting the gain mode ('radio' or 'album'), setting the pre-amp level, and enabling or disabling compression in order to prevent clipping. It determines the fallback gain (used for tracks that don't provide ReplayGain tags) by calculating the mean of the last 10 non-fallback gain levels. configure.ac | 2 + data/rhythmbox.schemas | 58 +++++++ plugins/Makefile.am | 1 + plugins/replaygain/Makefile.am | 17 ++ plugins/replaygain/replaygain-prefs.ui | 163 ++++++++++++++++++++ plugins/replaygain/replaygain.rb-plugin.in | 9 + plugins/replaygain/replaygain/Makefile.am | 6 + plugins/replaygain/replaygain/__init__.py | 56 +++++++ plugins/replaygain/replaygain/config.py | 102 +++++++++++++ plugins/replaygain/replaygain/player.py | 228 ++++++++++++++++++++++++++++ 10 files changed, 642 insertions(+), 0 deletions(-) commit 2564a76cde4ec0493ff7a7fd5c54956da7d78bae Author: Jonathan Matthew Date: Sun Feb 7 11:09:54 2010 +1000 xfade: add ability to insert per-stream filters By returning GstElements from handlers attached to the new get-stream-filters signal, plugins can now add filters into the per-stream bins. This is useful for selectively filtering streams, or for filters that might have different settings for different streams. backends/gstreamer/rb-player-gst-xfade.c | 65 +++++++++++++++++++++++------ lib/rb-marshal.list | 1 + 2 files changed, 52 insertions(+), 14 deletions(-) commit 82a1a7f1af044dc6a90ce1d16e54ddec352b4fcc Author: Jonathan Matthew Date: Sun Feb 7 11:03:05 2010 +1000 rhythmdb: disable replaygain properties The property IDs are still there, but they can no longer be modified, and retrieving them only returns default values. The fields are no longer present in the RhythmDBEntry structure, so we aren't wasting 4 doubles per entry on data that never gets used. rhythmdb/rhythmdb-private.h | 4 -- rhythmdb/rhythmdb-tree.c | 24 +++++++------- rhythmdb/rhythmdb.c | 68 +++++++----------------------------------- rhythmdb/rhythmdb.h | 8 ++-- 4 files changed, 28 insertions(+), 76 deletions(-) commit 04fdcb9013a0543dab01b5bf0b2b5b4b28eedb55 Author: Jonathan Matthew Date: Sun Feb 7 10:46:44 2010 +1000 remove old replaygain playback code It didn't work very well, and we can do much better by just inserting a GStreamer rgvolume element into the playback pipeline. backends/gstreamer/rb-player-gst-xfade.c | 108 +----------------------------- backends/gstreamer/rb-player-gst.c | 56 +--------------- backends/rb-player.c | 24 +------ backends/rb-player.h | 10 --- bindings/python/rb.defs | 13 ---- data/rhythmbox.schemas | 11 --- doc/reference/rhythmbox-sections.txt | 1 - lib/rb-preferences.h | 1 - shell/rb-shell-player.c | 28 -------- 9 files changed, 5 insertions(+), 247 deletions(-) commit af9ca543af38c4fe0a33787e6d974258fad5f0b1 Author: Jonathan Matthew Date: Sun Feb 7 12:27:02 2010 +1000 metadata: remove extra unref We don't actually retain a reference on the sink element, so we shouldn't unref it when resetting the metadata backend. metadata/rb-metadata-gst.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 3baff08252c01cc697d4ba3a6dc926248787f007 Author: Jonathan Matthew Date: Sun Feb 7 07:51:25 2010 +1000 playlist: remove the default key binding for 'remove from playlist' Turns out it's too easy to accidentally trigger this while editing something in the search entry box. sources/rb-playlist-source.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 1025f471ac07ea1830f6fd9fbcd9f0bfffe58351 Author: Jonathan Matthew Date: Sat Feb 6 22:31:29 2010 +1000 rhythmdb: use entry changes in the default sync function Rather than writing all the entry properties through the metadata backend, just write the changes. This should mean we don't write default values for tags that weren't already present in the file. rhythmdb/rhythmdb.c | 43 +++++++++++++++++-------------------------- rhythmdb/rhythmdb.h | 2 +- 2 files changed, 18 insertions(+), 27 deletions(-) commit 03d593c95da6a50512154ebe7edcf71449a43e51 Author: Jonathan Matthew Date: Thu Jan 28 19:22:28 2010 +1000 rhythmdb: include entry changes in RhythmDBAction for sync actions The sync function could benefit from being to write only the modified properties, so now we pass it through as part of the RhythmDBAction structure. rhythmdb/rhythmdb.c | 91 ++++++++++++++++++++++++++++++++++----------------- 1 files changed, 61 insertions(+), 30 deletions(-) commit f1751ab2bc5030ce911be953647aad107567b391 Author: Jonathan Matthew Date: Thu Jan 28 06:03:43 2010 +1000 metadata: remove the need to load metadata before saving There's no need to load the metadata first, the tags from the file will be available in the tag writing pipeline anyway. When saving metadata, we need a typefind element in the pipeline, since we don't already know the file type. We now have a method to reset the metadata state. This previously happened at the start of the loading process, but we don't necessarily do that between save operations any more. bindings/python/rb.defs | 7 ++ metadata/rb-metadata-dbus-client.c | 36 ++++++-- metadata/rb-metadata-dbus-service.c | 12 ++- metadata/rb-metadata-gst.c | 184 ++++++++++++++++++++++------------- metadata/rb-metadata.h | 3 + rhythmdb/rhythmdb.c | 9 +-- 6 files changed, 167 insertions(+), 84 deletions(-) commit 2a3a3d2303f366623a6105baa781e02e985d1b7d Author: Mario Blättermann Date: Fri Feb 5 18:00:20 2010 +0100 Updated German translation po/de.po | 143 ++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 84 insertions(+), 59 deletions(-) commit ebd9b79aae43a3c265e7e15fa3776e291a4724aa Author: Gabor Kelemen Date: Wed Feb 3 21:13:26 2010 +0100 Updated Hungarian translation po/hu.po | 208 +++++++++++++++++++++++++++++-------------------------------- 1 files changed, 99 insertions(+), 109 deletions(-) commit f42b804e79526ee846149715f279e543954588e3 Author: Christophe Fergeau Date: Tue Feb 2 17:55:33 2010 +0100 link segmented bar test with needed libraries widgets/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 8699c440eb5cc9a912485e278186ebaf7e573be5 Author: Marek Černocký Date: Tue Feb 2 14:52:20 2010 +0100 Update Czech translation po/cs.po | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-) commit dbf6ebf32db7b9eb477d113262453cccc9b13347 Author: Marek Černocký Date: Tue Feb 2 13:19:22 2010 +0100 Update Czech translation po/cs.po | 3749 +++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 2217 insertions(+), 1532 deletions(-) commit 20bec45a1dd2182a723e199b8e56a477bcfb8b54 Author: Mattias Põldaru Date: Mon Feb 1 16:59:35 2010 +0200 Updating Estonian translation po/et.po | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit a81388ed7fef460c47bb2ca8d9cf1951338d44f4 Author: Jonathan Matthew Date: Mon Feb 1 22:50:05 2010 +1000 generic-player: fix compile errors introduced in commit a3ea4460 .../rb-generic-player-playlist-source.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 3a7b75b45574fe868ee29adc196450be7592c77e Author: Jorge González Date: Sun Jan 31 17:42:24 2010 +0100 Updated Spanish translation po/es.po | 115 ++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 64 insertions(+), 51 deletions(-) commit 2be0b69c36615aea62926855c003b634aab3af0c Author: Andrej Žnidaršič Date: Sun Jan 31 15:45:21 2010 +0100 Updated Slovenian translation po/sl.po | 224 ++++++++++++++++++++++++++++++++++++-------------------------- 1 files changed, 130 insertions(+), 94 deletions(-) commit 6ee9f21f18f86617c130150edaa207daa30c7f5f Author: Jamie Nicol Date: Sun Jan 31 19:13:19 2010 +1000 rhythmdb: use sortnames in property models (bug #133444) For each type of property model, we now have an ordered list of properties to use to determine the sort key string. Where there is a sortname version of a property, it is preferred to the display version. Each property model entry now includes an index into this list, which records the property that provided the current sort string for that entry. If any of the entries with a given artist name (for example) has an artist sortname set, then that is used for the entry in the property model. If there are multiple different sortnames for a single property, the results are undefined. When an entry changes, the property model needs to check if any of the properties in its sort string order have changed. When a higher priority sort string appears, or the current highest priority sort string changes or is removed, the property model entry is reordered accordingly. rhythmdb/rhythmdb-property-model.c | 181 ++++++++++++++++++++++++++++++---- tests/test-rhythmdb-property-model.c | 156 +++++++++++++++++++++++++++++ 2 files changed, 318 insertions(+), 19 deletions(-) commit e49117b83afca6689c14906977c1c6698fc7caa3 Author: Jonathan Matthew Date: Sun Jan 31 14:26:27 2010 +1000 rhythmdb: set empty sortnames and musicbrainz IDs if not found in metadata This makes it possible to remove incorrect values for these tags by removing the tags from the file. rhythmdb/rhythmdb.c | 103 ++++++++++++++++++++++----------------------------- 1 files changed, 44 insertions(+), 59 deletions(-) commit 2f69fc7681fb73e39a61aaffc19a7398f06a9fa2 Author: Jonathan Matthew Date: Sun Jan 31 14:25:35 2010 +1000 rhythmdb: don't write empty sortnames and musicbrainz IDs to disk This reduces the on-disk size of my database by about 25%. rhythmdb/rhythmdb-tree.c | 28 +++++++++++++++++----------- 1 files changed, 17 insertions(+), 11 deletions(-) commit cb3284e3138fded7f5c6b63316a77782fe5fd95b Author: Jonathan Matthew Date: Sun Jan 31 13:58:00 2010 +1000 audiocd: don't set musicbrainz IDs or sortnames to Unknown if not found Also remove the useless is_inserted parameter to entry_set_string_prop. plugins/audiocd/rb-audiocd-source.c | 42 ++++++++++++++++++---------------- 1 files changed, 22 insertions(+), 20 deletions(-) commit 1b09fc581c6c776afcc9e49fa75e3cc954d87cbe Author: Jonathan Matthew Date: Sun Jan 31 13:46:04 2010 +1000 audiocd: add check for mb_extract_uuid to configure.ac Maybe some day there will be a libmusicbrainz3 release that includes this function. Until then, we weren't getting musicbrainz IDs anyway. configure.ac | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 881ecb0218757eb4b7ad03d5dcf696a6d3a52436 Author: Jonathan Matthew Date: Sun Jan 31 10:26:27 2010 +1000 rating: fix gtk warnings on initial realize Don't call gtk_widget_set_can_focus() until we've created the window for the widget. With gtk+ 2.18, this queues a resize of the window, which results in some critical errors when the window doesn't exist yet. widgets/rb-rating.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit c41968b529380077a365308bf6b55686b33995af Author: Jamie Nicol Date: Sat Jan 30 23:09:13 2010 +1000 rhythmdb: use artist and album sortnames in query model sorting functions Part of bug #133444. When a sort name is available, it's used in preference to the artist or album display name. rhythmdb/rhythmdb-query-model.c | 20 ++++++++++++++++---- 1 files changed, 16 insertions(+), 4 deletions(-) commit 3e5e42b72332dfd65cf7caaf05cfb1073eae0a6f Author: Jamie Nicol Date: Sat Jan 30 21:31:17 2010 +1000 song-info: add 'sorting' tab, containing album and artist sort names Part of bug #133444. data/ui/song-info-multiple.ui | 80 +++++++++++++++++++++++++++++- data/ui/song-info.ui | 89 ++++++++++++++++++++++++++++++++- widgets/rb-song-info.c | 110 ++++++++++++++++++++++++++++++++++++++++- 3 files changed, 275 insertions(+), 4 deletions(-) commit a3ea4460f3ee8e5e749347bec518f046691fd1bf Author: Jonathan Matthew Date: Sat Jan 30 20:19:43 2010 +1000 generic-player: transform URIs to the device filesystem conditionally For most playlist formats, we actually want to leave playlist entry URIs as-is, so totem-pl-parser can construct paths relative to the playlist file. So, we add the playlist format as a parameter to uri_to_playlist_uri so it can be used to select the required behaviour. See bug #608397. .../rb-generic-player-playlist-source.c | 35 ++++++++++--------- plugins/generic-player/rb-generic-player-source.c | 34 +++++++++++++------ plugins/generic-player/rb-generic-player-source.h | 5 ++- 3 files changed, 44 insertions(+), 30 deletions(-) commit e62f190a2c7cbd2d0d57389ea05911ee89d2399d Author: Jonathan Matthew Date: Sat Jan 30 20:17:38 2010 +1000 generic-player: handle playlist paths with %File better Move the check for %File to rb_generic_player_source_get_playlist_path, and use that (rather than the playlist path from the device info) when building the path to search for playlists. Fixes creation of new playlists when the playlist path includes %File. plugins/generic-player/rb-generic-player-source.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit f53b0f08b8286ac5403af5dc379a1a1158294e77 Author: Jamie Nicol Date: Wed Jan 27 18:45:23 2010 +0000 rhythmdb: add sort key and folded properties for artist and album sortnames See bug #133444. rhythmdb/rhythmdb-tree.c | 4 ++++ rhythmdb/rhythmdb.c | 12 ++++++++++++ rhythmdb/rhythmdb.h | 5 +++++ 3 files changed, 21 insertions(+), 0 deletions(-) commit f5fdd9bcc25844d30a4f23e70554176b93fba83c Author: Ryan May Date: Sat Jan 30 13:56:55 2010 +1000 generic-player: write M3U playlists in DOS format For now, we're assuming that all devices that use M3U playlist format expect the playlists to be in DOS format. See bug #608397. plugins/generic-player/rb-generic-player-source.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 948c82798ff2395b4aac0ff54b040ab028bfe528 Author: Jonathan Matthew Date: Thu Jan 28 23:42:38 2010 +1000 playlist: set custom_title flag to TRUE when saving playlists (bug #607265) sources/rb-playlist-source.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit a6e3370a200215ddd931d04ab684dcda79dceb7b Author: Carlos Garnacho Date: Thu Jan 28 22:10:14 2010 +1000 Use new totem_pl_parser_save API where required .../rb-generic-player-playlist-source.c | 113 +++++++++++++++++--- sources/rb-playlist-source.c | 72 ++++++++++++- 2 files changed, 165 insertions(+), 20 deletions(-) commit 21ebc4fab92a79992fedcf2a07580d5590d331c8 Author: Jonathan Matthew Date: Wed Jan 27 21:47:50 2010 +1000 playbin2: unref bus messages as necessary Messages retrieved with gst_bus_timed_pop need to be unreffed. Failing to do so leaks references to the source elements, which in turn results in memory and file descriptor leaks. backends/gstreamer/rb-player-gst.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit b504129f54b65dbb3f4587ed9264e84995a8e746 Author: Jorge González Date: Tue Jan 26 19:43:58 2010 +0100 Updated Spanish translation po/es.po | 34 ++++++++++++++++++++++------------ 1 files changed, 22 insertions(+), 12 deletions(-) commit fecd44feb8b228509f1ece1e442eb42e47817d22 Author: Jonathan Matthew Date: Sun Jan 24 22:15:37 2010 +1000 rhythmdb: fix sort order for composed characters (bug #542055) Previously, we created the sort key based on the folded version of the string. Our custom folding function removes all combining characters, which in some locales are important for sorting, so the resulting strings didn't sort correctly. Now we create the sort key using g_utf8_casefold rather than the custom folding function. rhythmdb/rb-refstring.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) commit 680efd95b056585f2dc321c78ccee25b62df823d Author: Luca Ferretti Date: Sun Jan 24 12:30:13 2010 +0100 Updated Italian translation po/it.po | 34 +++++++++++++++++++++------------- 1 files changed, 21 insertions(+), 13 deletions(-) commit c1371bc1d8857d7ada839e8dc55cbd5e64864529 Author: Luca Ferretti Date: Sun Jan 24 12:26:32 2010 +0100 Add files from new sendto plugin to POTFILES.in po/POTFILES.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 713e54f1827839c8cbdb25ab7336d22a7f323d5c Author: Jonh Wendell Date: Sat Jan 23 19:02:58 2010 -0300 Fix some compiler warnings bindings/python/override_common.c | 2 +- bindings/python/rb.override | 2 +- bindings/python/rhythmdb.override | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) commit fcb23622b304970226750ced9c93e10c88601233 Author: Jonh Wendell Date: Sat Jan 23 18:09:49 2010 -0300 Replaced some deprecated symbols widgets/rb-segmented-bar.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) commit f27ba835d2cdac3679cd62c40732235a5cbee846 Author: Jonathan Matthew Date: Sun Jan 24 18:00:19 2010 +1000 artdisplay: open the image in the default image viewer on doubleclick (bug #384483) This isn't particularly discoverable, but I'm not sure it needs to be. plugins/artdisplay/artdisplay/__init__.py | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) commit 1f7daa51048c5da5e9b7479352489a1388182df3 Author: Jonathan Matthew Date: Sun Jan 24 15:04:33 2010 +1000 metadata: add to python bindings (bug #594132) This involves converting RBMetaDataField into a GEnum. A couple of the metadata functions also required overrides to deal with GValues. bindings/python/Makefile.am | 1 + bindings/python/rb.defs | 197 +++++++++++++++++++++++++++++++++++++++++ bindings/python/rb.override | 62 +++++++++++++- metadata/rb-metadata-common.c | 178 ++++++++++++++++++++++++++----------- metadata/rb-metadata.h | 6 ++ 5 files changed, 393 insertions(+), 51 deletions(-) commit 8f083b56a324d099574461b8be889d577b20debb Author: Jonathan Matthew Date: Sun Jan 24 13:16:51 2010 +1000 fix the rb-set-rating dbus example - dbus.Variant no longer exists remote/dbus/rb-set-rating.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 64c49e5b52cb2512dd4e3b32c46ca940e0441145 Author: Filipp Ivanov Date: Sun Jan 24 09:53:51 2010 +1000 Add new plugin that calls nautilus-sendto with selected tracks (bug #605301) configure.ac | 1 + data/rhythmbox.schemas | 26 ++++++++++++- plugins/Makefile.am | 1 + plugins/sendto/Makefile.am | 11 +++++ plugins/sendto/__init__.py | 73 ++++++++++++++++++++++++++++++++++++ plugins/sendto/sendto.rb-plugin.in | 8 ++++ 6 files changed, 118 insertions(+), 2 deletions(-) commit cd4f5afe0282015cb2e6f9f103091dc90ae761d8 Author: Jonathan Matthew Date: Sat Jan 23 09:47:19 2010 +1000 podcast: set initial rating to 0, not 2.5 (bug #607672) podcast/rb-podcast-manager.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 2c92332867fe381d222ffae0ced22c3e332c8066 Author: Gabor Kelemen Date: Fri Jan 22 02:16:03 2010 +0100 Updated Hungarian translation po/hu.po | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) commit 93b159476541d55a82882152e96cfa43fafb9683 Author: Gabor Kelemen Date: Thu Jan 21 21:26:37 2010 +0100 Updated Hungarian translation po/hu.po | 1931 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 1073 insertions(+), 858 deletions(-) commit 6dd83fa1bfe6a01b65de7389180d6b66ebc95988 Author: Krasimir Chonov Date: Thu Jan 21 15:21:19 2010 +0200 Updated Bulgarian translation po/bg.po | 43 ++++++++++++++++++++++--------------------- 1 files changed, 22 insertions(+), 21 deletions(-) commit 49c00c33cd5a06660aae223d156e4f1291989215 Author: Jonathan Matthew Date: Thu Jan 21 07:08:08 2010 +1000 gconf schemas: fix description for toolbar_style (bug #607538) The descriptions were in the order of the GtkToolbarStyle enum, but that isn't how we interpret the value we get from gconf. data/rhythmbox.schemas | 2 +- shell/rb-shell.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f012db285979e2bc40f631116a5c76dbb83d6155 Author: Miloš Popović Date: Mon Jan 18 23:47:23 2010 +0000 Updated Serbian translation po/sr.po | 2252 ++++++++++++++++++++++++++++++-------------------------- po/sr@latin.po | 2252 ++++++++++++++++++++++++++++++-------------------------- 2 files changed, 2426 insertions(+), 2078 deletions(-) commit d762af4970c8ff206d269b265ed294452e538426 Author: Jorge González Date: Mon Jan 18 23:11:44 2010 +0100 Updated Spanish translation po/es.po | 58 +++++++++++++++++++++++++++++++--------------------------- 1 files changed, 31 insertions(+), 27 deletions(-) commit e3e5d16a7e58e64509e274b80cc4341bf3779087 Author: Andrej Žnidaršič Date: Mon Jan 18 17:05:26 2010 +0100 Updated Slovenian translation po/sl.po | 730 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 373 insertions(+), 357 deletions(-) commit bc566bd8fc04430a8d13eae5cf8993fa72ed9ca7 Author: Jorge González Date: Mon Jan 18 06:18:33 2010 +0100 Updated Spanish translation po/es.po | 630 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 328 insertions(+), 302 deletions(-) commit 88fadd4b35b616589443f405704be45fea884454 Author: Luca Ferretti Date: Sun Jan 17 21:19:20 2010 +0100 Updated Italian translation po/it.po | 1581 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 811 insertions(+), 770 deletions(-) commit d825d163d23398db44e1f01c5cfc78dfdc21bb1b Author: Mario Blättermann Date: Sun Jan 17 18:49:13 2010 +0100 Updated German translation po/de.po | 73 +++++++++++++++++++++++++++---------------------------------- 1 files changed, 32 insertions(+), 41 deletions(-) commit 7a0d1ccbd01541a592c95b15f0b9bb02f152955a Author: Jonathan Matthew Date: Sun Jan 17 18:53:05 2010 +1000 context: when being deactivated, don't remove the widget if hidden This fixes a few warnings/criticals when removing the plugin or quitting rhythmbox. plugins/context/context/ContextView.py | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 2855ec99b4311155ab945accd47c3128a0543dff Author: Jonathan Matthew Date: Sun Jan 17 18:46:28 2010 +1000 context: use gtk+ font settings rather than css (bug #605725) This mostly involves translating the PangoFontDescription we get from the GTK+ style into webkit.WebSettings properties. plugins/context/context/ContextView.py | 24 ++++++++++++++++++++++-- plugins/context/tmpl/loading.html | 2 +- plugins/context/tmpl/main.css | 2 +- 3 files changed, 24 insertions(+), 4 deletions(-) commit 089d5a6ef26d701462095a013c3cf8343503653a Author: Jonathan Matthew Date: Sun Jan 17 18:36:34 2010 +1000 ipod, mtp: fix alignment and capitalisation in info dialog (bug #606472) plugins/ipod/ipod-info.ui | 20 ++++++++++++++------ plugins/mtpdevice/mtp-info.ui | 14 +++++++++++--- 2 files changed, 25 insertions(+), 9 deletions(-) commit 8aebab4817bf9fd242167c20e91fd5efe459f1fd Author: Jonathan Matthew Date: Sun Jan 17 18:35:17 2010 +1000 media-player: fix properties dialog title (bug #606470) Use the device name in the dialog title, rather than incorrectly calling everything an iPod. data/ui/media-player-properties.ui | 2 +- sources/rb-media-player-source.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletions(-) commit e590c91d3adbd0449b808a9e3939e444d9262560 Author: Alexander Shopov Date: Sat Jan 16 19:46:49 2010 +0200 Updated Bulgarian translation po/bg.po | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) commit a421e56890294fd5ff44b82f769ad99f33e00686 Author: Krasimir Chonov Date: Sat Jan 16 19:41:00 2010 +0200 Updated Bulgarian translation po/bg.po | 178 ++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 99 insertions(+), 79 deletions(-) commit 15ae2d39e81fca4b5e6429b2bd38c6f2b40ec2c7 Author: Mario Blättermann Date: Fri Jan 15 19:29:43 2010 +0100 Updated German translation po/de.po | 1609 +++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 845 insertions(+), 764 deletions(-) commit 88e7e9c3d925d2df27ccc1bb346815cea53c411c Author: Christophe Fergeau Date: Thu Jan 14 10:46:17 2010 +0000 Add segmented bar widget Port the segmented bar from Banshee. https://bugzilla.gnome.org/show_bug.cgi?id=558576 widgets/Makefile.am | 5 + widgets/rb-segmented-bar.c | 825 +++++++++++++++++++++++++++++++++++++++ widgets/rb-segmented-bar.h | 80 ++++ widgets/test-rb-segmented-bar.c | 76 ++++ 4 files changed, 986 insertions(+), 0 deletions(-) commit bfdfca4729c2e2b3d61b368ec899cd837bff871a Author: Maxim V. Dziumanenko Date: Thu Jan 14 07:41:39 2010 +0200 Update Ukrainian translation help/Makefile.am | 2 +- help/uk/uk.po | 2916 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 2917 insertions(+), 1 deletions(-) commit 4edfe671a196876c60fa83d7bc5d776faad21682 Author: Žygimantas Beručka Date: Wed Jan 13 19:36:34 2010 +0200 Updated Lithuanian translation po/lt.po | 639 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 322 insertions(+), 317 deletions(-) commit 75072f26927e95483f987e110cb457972ca617d0 Author: Žygimantas Beručka Date: Wed Jan 13 19:16:02 2010 +0200 Updated Lithuanian translation po/lt.po | 1581 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 824 insertions(+), 757 deletions(-) commit ae693e0592156bd4a160284e5c1bca1214523f59 Author: Jonathan Matthew Date: Wed Jan 13 23:05:39 2010 +1000 clipboard: improve some action descriptions (bug #485730) The new wording matches how Nautilus describes actions that operate on a selection, and hopefully hints that you can select multiple entries for most of them without it sounding weird either way. shell/rb-shell-clipboard.c | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-) commit 3847ca238b42027a939f70c134b419f4f164900e Author: Jonathan Matthew Date: Wed Jan 13 23:04:20 2010 +1000 iradio: use 'remove' rather than 'delete' in the popup We couldn't delete radio streams even if we wanted to, so this is definitely 'remove' rather than 'delete'. plugins/iradio/iradio-ui.xml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit a6369fdf542df71e50f49af08c29a800b6c7cca8 Author: Jonathan Matthew Date: Wed Jan 13 23:01:13 2010 +1000 playlist: add 'remove from playlist' action for playlist sources Removing entries from playlists is neither 'remove' as it's used elsewhere, nor 'delete', so it deserves its own description. data/ui/rhythmbox-ui.xml | 4 ++-- shell/rb-playlist-manager.c | 2 +- sources/rb-playlist-source.c | 34 ++++++++++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 3 deletions(-) commit bd6226ebcc4862f0f2febb5f787c96429f606700 Author: Jonathan Matthew Date: Wed Jan 13 22:59:50 2010 +1000 ipod: use 'delete' rather than 'move to trash' to delete files 'Move to trash' actually just deleted files, so now it's more accurately named. plugins/ipod/rb-ipod-db.c | 2 +- plugins/ipod/rb-ipod-source.c | 14 ++++++++------ plugins/ipod/rb-ipod-source.h | 2 +- plugins/ipod/rb-ipod-static-playlist-source.c | 11 ++++++----- 4 files changed, 16 insertions(+), 13 deletions(-) commit 02ebefae3bc6ed7d76433ad04fed0c47f221276f Author: Jonathan Matthew Date: Wed Jan 13 22:58:09 2010 +1000 generic-player: remove 'move to trash', only allow deletion (bug #584704) Trashing files on generic audio players isn't very useful, as the files still take up space on the device and so they need to be cleaned up manually if the device is full. .../rb-generic-player-playlist-source.c | 39 +-------- plugins/generic-player/rb-generic-player-source.c | 95 +------------------- plugins/generic-player/rb-generic-player-source.h | 5 +- 3 files changed, 7 insertions(+), 132 deletions(-) commit 2b7227b75c12f1795599daabb1ddb70e356a02b4 Author: Jonathan Matthew Date: Wed Jan 13 22:55:47 2010 +1000 removable-media: use 'delete' rather than 'remove' for removable media sources Deleting songs from a removable media source should delete the files from the device, not just remove them from the library. sources/rb-removable-media-source.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 942b8a093966ada2fa884901cba5e6c1478fbe2f Author: Jonathan Matthew Date: Wed Jan 13 22:52:26 2010 +1000 clipboard: use the source's specified deletion action When the selected source changes, ask the new source for its deletion action, then add that into various placeholders. data/ui/rhythmbox-ui.xml | 8 ++++---- shell/rb-shell-clipboard.c | 42 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 44 insertions(+), 6 deletions(-) commit f01b4eff87863e73dee27c1ff6c077e8484f03e8 Author: Jonathan Matthew Date: Wed Jan 13 22:48:36 2010 +1000 ensure RBBrowserSource subclasses implement can_delete correctly RBBrowserSource defaults to returning true, so browser sources that shouldn't allow deletion (such as the Magnatune, Jamendo, and Coherence sources) need to override it. plugins/coherence/upnp_coherence/UpnpSource.py | 3 +++ plugins/jamendo/jamendo/JamendoSource.py | 3 +++ plugins/magnatune/magnatune/MagnatuneSource.py | 3 +++ 3 files changed, 9 insertions(+), 0 deletions(-) commit f40432fb255b31c29f72f889cfbfe2fe4f68afef Author: Jonathan Matthew Date: Wed Jan 13 22:37:34 2010 +1000 source: add a method to specify the delete action for the source Since 'delete' means a variety of things depending on the source, we should use different names and descriptions to display it. This allows each source to specify its own delete action. For a start, allow sources to distinguish between 'remove' and 'delete'. Remove just removes something from the library, whereas delete also removes the underlying resource. bindings/python/rb.defs | 11 ++++++ bindings/python/rb.override | 83 +++++++++++++++++++++++++++++++++++++++++++ shell/rb-shell-clipboard.c | 7 +++- sources/rb-source.c | 26 +++++++++++++- sources/rb-source.h | 2 + 5 files changed, 126 insertions(+), 3 deletions(-) commit 8df7bea126ba768812ba6f8712319355ad4c4859 Author: Jabik Postmus Date: Sun Jan 10 10:43:20 2010 +1000 coverart: use secondary images from discogs if no primary image found .../artdisplay/artdisplay/DiscogsCoverArtSearch.py | 17 ++++++++++++----- 1 files changed, 12 insertions(+), 5 deletions(-) commit ac856708222c50552096e1fbc5a2733fe6871523 Author: Daniel Nylander Date: Fri Jan 8 12:43:15 2010 +0100 Updated Swedish translation po/sv.po | 1603 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 828 insertions(+), 775 deletions(-) commit d0c0338d9f5ce409611108b50b26a5c79911c622 Author: Jorge González Date: Wed Jan 6 14:09:30 2010 +0100 Updated Spanish translation po/es.po | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 deletions(-) commit 78ba5fa6b46aa230ef34d01412c36483f6d7c094 Author: Maxim V. Dziumanenko Date: Mon Jan 4 17:02:33 2010 +0200 Update Ukrainian translation po/uk.po | 5785 +++++++++++++++++++++++++++++++++++++++++++++++++------------- 1 files changed, 4633 insertions(+), 1152 deletions(-) commit 676f9a31cfa4170bd448a2e32a95a5dcb574906c Author: Jonathan Matthew Date: Sun Jan 3 19:45:07 2010 +1000 build in 'stores' source group so plugins don't have to create it Anyone creating a 'store' plugin ends up copying the same five or so lines from the magnatune plugin, so we might as well cut it down to one. plugins/jamendo/jamendo/__init__.py | 7 +------ plugins/magnatune/magnatune/__init__.py | 7 +------ sources/rb-source-group.c | 13 +++++++++++++ sources/rb-source-group.h | 2 ++ 4 files changed, 17 insertions(+), 12 deletions(-) commit 7d762ce34ce3ed11deb4baeefaf6731e2972fe4d Author: Jonathan Matthew Date: Sun Jan 3 19:19:13 2010 +1000 artdisplay: utf-8 encode search terms for discogs .../artdisplay/artdisplay/DiscogsCoverArtSearch.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 0d14519ddda0306bd736d15ed067e8a4dc6a98ea Author: Krasimir Chonov Date: Sun Jan 3 08:42:28 2010 +0200 Updated Bulgarian translation po/bg.po | 514 +++++++++++++++++++++++++++++++------------------------------ 1 files changed, 261 insertions(+), 253 deletions(-) commit 159fa13dee27c323a8872c0aec5cfa65b0176aae Author: Javier Jardón Date: Sat Jan 2 10:27:36 2010 +1000 Use GTK+ accessor functions instead of direct access (bug #595425) There are still a few things missing, but now we mostly build with GSEAL enabled. gseal-gtk-compat.h provides compatibility #defines for earlier versions of GTK+. lib/Makefile.am | 1 + lib/gseal-gtk-compat.h | 49 ++++++++++++++++ lib/rb-tree-dnd.c | 10 ++- plugins/audioscrobbler/rb-audioscrobbler-plugin.c | 3 +- plugins/audioscrobbler/rb-lastfm-source.c | 8 ++- plugins/cd-recorder/rb-playlist-source-recorder.c | 3 +- plugins/daap/rb-daap-dialog.c | 2 +- plugins/daap/rb-daap-plugin.c | 3 +- plugins/iradio/rb-iradio-source.c | 2 +- plugins/iradio/rb-station-properties-dialog.c | 7 ++- plugins/status-icon/rb-status-icon-plugin.c | 2 +- plugins/visualizer/rb-vis-widget.c | 65 +++++++++++++------- plugins/visualizer/rb-visualizer-plugin.c | 10 ++- podcast/rb-feed-podcast-properties-dialog.c | 6 +- podcast/rb-podcast-properties-dialog.c | 7 ++- rhythmdb/rhythmdb-property-model.c | 8 ++- rhythmdb/rhythmdb-query-model.c | 13 +++-- shell/rb-missing-plugins.c | 2 +- shell/rb-playlist-manager.c | 26 ++++++--- shell/rb-plugin-manager.c | 7 ++- shell/rb-plugins-engine.c | 2 +- shell/rb-shell-preferences.c | 7 ++- shell/rb-shell.c | 11 ++- sources/rb-auto-playlist-source.c | 11 ++- sources/rb-library-source.c | 4 +- sources/rb-podcast-source.c | 4 +- sources/rb-removable-media-source.c | 6 +- sources/rb-sourcelist-model.c | 22 ++++--- sources/rb-sourcelist.c | 3 +- sources/rb-static-playlist-source.c | 11 ++- widgets/gedit-message-area.c | 22 +++++--- widgets/gossip-cell-renderer-expander.c | 39 ++++++++---- widgets/rb-cell-renderer-pixbuf.c | 33 +++++++---- widgets/rb-cell-renderer-rating.c | 19 ++++-- widgets/rb-entry-view.c | 2 +- widgets/rb-header.c | 2 +- widgets/rb-library-browser.c | 3 +- widgets/rb-query-creator.c | 7 ++- widgets/rb-rating-helper.c | 14 +++-- widgets/rb-rating.c | 44 +++++++++----- widgets/rb-song-info.c | 8 ++- widgets/rb-uri-dialog.c | 7 ++- 42 files changed, 351 insertions(+), 164 deletions(-) commit 052413c7f8a3c97b548a276086f4581b773bc512 Author: John Daiker Date: Fri Jan 1 20:10:55 2010 +1000 shell-player: make the play button tooltip more accurate (bug #424878) Make it say 'pause playback' rather than 'stop playback' when that's what it will do. shell/rb-shell-player.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) commit bd7e425bc113ca85eaec5462d698a703dd2c7467 Author: Andrej Žnidaršič Date: Fri Jan 1 09:51:01 2010 +0100 Updated Slovenian translation po/sl.po | 1612 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 835 insertions(+), 777 deletions(-) commit 9759c518055b2f2d01f37ff1829a6b35eadda0d1 Author: Djavan Fagundes Date: Thu Dec 31 19:37:08 2009 -0200 Updated Brazilian Portuguese translation. Rodrigo Flores translated a Fuzzy that appeared after the po file update po/pt_BR.po | 1527 ++++++++++++++++++++++++++++++----------------------------- 1 files changed, 789 insertions(+), 738 deletions(-) commit 1934f0d4d8adca7aebd1d32127a1b482bf02d090 Author: Jorge González Date: Wed Dec 30 09:15:09 2009 +0100 Updated Spanish translation po/es.po | 98 ++++++++++++++++++++++++++++++++++--------------------------- 1 files changed, 55 insertions(+), 43 deletions(-) commit 4072afad6f912d9e90616c3a63b28a1ec13592ec Author: Jay L. T. Cornwall Date: Wed Dec 30 13:03:34 2009 +1000 daap: use souphttpsrc instead of our own HTTP client code This converts our DAAP source element into a bin containing a souphttpsrc element, using the extra-headers property to set the DAAP headers (which don't really do anything any more anyway). rb_daap_connection_get_headers now returns a GstStructure, since that's what souphttpsrc takes. plugins/daap/rb-daap-connection.c | 51 ++-- plugins/daap/rb-daap-connection.h | 6 +- plugins/daap/rb-daap-source.c | 7 +- plugins/daap/rb-daap-source.h | 7 +- plugins/daap/rb-daap-src.c | 626 +++++-------------------------------- 5 files changed, 117 insertions(+), 580 deletions(-) commit 627e6a50402ee8b047a65935a10e7e1ffdd870ec Author: Jonathan Matthew Date: Tue Dec 29 18:48:15 2009 +1000 mtp: only release the device if we managed to open it plugins/mtpdevice/rb-mtp-thread.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 34437632981c2784aa3233cf1cd2bb17f73c48e7 Author: Jonathan Matthew Date: Tue Dec 29 18:34:11 2009 +1000 mtp: fix stupid mistake in previous commit well, I had to test it somehow.. plugins/mtpdevice/rb-mtp-source.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit c72a090f760bfdbb7e5c2f6c3af7be83e4b47389 Author: Jonathan Matthew Date: Tue Dec 29 18:34:11 2009 +1000 mtp: fix error reporting after device open failure (bug #605583) rb_mtp_thread_report_errors() won't work here, as we don't have a libmtp device to get an error stack from. Instead, just display a generic "couldn't open device" error message, including the device manufacturer and product names. plugins/mtpdevice/rb-mtp-source.c | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-) commit 072b899d4df3d1d180a02eaf0979753e467f2094 Author: Kevin Hester Date: Tue Dec 29 17:50:39 2009 +1000 mtp: take a copy of the raw device info before opening (bug #605584) Since the device is opened asynchronously now, the raw device list could be freed before (or while) it happened. The source now takes a copy of the device information and passes that to the device handling thread. plugins/mtpdevice/rb-mtp-source.c | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) commit 0d6064eb59c12618658487591b8efa3f5d09ccb2 Author: Jonathan Matthew Date: Tue Dec 29 17:47:59 2009 +1000 mtp: add more debug output during device matching plugins/mtpdevice/rb-mtp-plugin.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) commit 02a7224a7ab48a74b8af071e3b71f77a074e99d5 Author: Javier Jardón Date: Sat Dec 26 14:45:39 2009 +0100 Use GNOME_MAINTAINER_MODE_DEFINES macro This macro notifies when a deprecated Glib / GTK+ symbols is used https://bugzilla.gnome.org/show_bug.cgi?id=559582 configure.ac | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit b3699d11d9b8727875fdd3ccb79cd5d1bbed33b3 Author: Jonathan Matthew Date: Mon Dec 28 18:26:00 2009 +1000 removable-media: use new unmount_with_operation functions (bug #559582) We don't actually pass in a mount operation, so all we're really doing here is getting rid of deprecated functions. shell/rb-removable-media-manager.c | 50 +++++++++++++++++++++++------------- 1 files changed, 32 insertions(+), 18 deletions(-) commit c258166cef4aa61a59f78c142ea7140490126ce4 Author: Jonathan Matthew Date: Mon Dec 28 17:10:15 2009 +1000 playbin2: fix track changes (bug #601524, bug #602957) Rather than emitting the playing stream change signal immediately, and pretending the playback position is 0 until the next tick, we wait until either we get a playbin2-stream-changed signal or a position query returns a position inside the first second. This means the playback position should always be consistent, and the track change is reflected in the UI closer to when it actually occurs. This also means we don't emit the playing-stream signal on a streaming thread, which fixes some threading problems with a11y enabled. backends/gstreamer/rb-player-gst.c | 131 ++++++++++++++++++++++++------------ 1 files changed, 88 insertions(+), 43 deletions(-) commit 6989b70822ad9ce5c8b1b3e2c2cc24708713a5ad Author: Alexander Shopov Date: Mon Dec 28 08:43:09 2009 +0200 Updated Bulgarian translation po/bg.po | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit 9b64d99c62c5687f824608cf2cfc03d9edb2b3a6 Author: Krasimir Chonov Date: Fri Dec 4 12:38:24 2009 +0200 Updated Bulgarian translation po/bg.po | 5985 +++++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 3973 insertions(+), 2012 deletions(-) commit 7b841d6f50303692ee8a22ee0ad382c7354a5a62 Author: Jonathan Matthew Date: Mon Dec 28 00:05:03 2009 +1000 shell-player: fix play queue debug output shell/rb-shell-player.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit a095a119f5ed77d62cb59e523188b32dc6803272 Author: Jonathan Matthew Date: Sun Dec 27 18:40:00 2009 +1000 revert changes that were accidentally included in the last commit shell/rb-removable-media-manager.c | 20 -------------------- 1 files changed, 0 insertions(+), 20 deletions(-) commit e282e7d2cc2031b9620564ae35dd2e2d2b1b1d0d Author: Jonathan Matthew Date: Sun Dec 27 18:23:50 2009 +1000 re-add the encoder destination size parameter Turns out we need this for the ipod plugin, so it can set the file size field correctly in the ipod database. backends/gstreamer/rb-encoder-gst.c | 23 +++++++++++++++++++++-- backends/rb-encoder.c | 8 ++++---- backends/rb-encoder.h | 4 ++-- bindings/python/rb.defs | 2 ++ plugins/ipod/rb-ipod-source.c | 8 +++++--- plugins/mtpdevice/rb-mtp-source.c | 2 ++ shell/rb-removable-media-manager.c | 24 ++++++++++++++++++++++-- shell/rb-removable-media-manager.h | 1 + sources/rb-library-source.c | 2 +- sources/rb-removable-media-source.c | 7 ++++--- sources/rb-removable-media-source.h | 2 ++ 11 files changed, 66 insertions(+), 17 deletions(-) commit 41af131fa874d362812a56421b695d4cd1f4117f Author: Javier Jardón Date: Fri Dec 4 00:22:21 2009 +0100 Substitute deprecated glib symbol: g_mapped_file_free() Use g_mapped_file_unref() instead if glib >= 2.22 is available plugins/daap/rb-daap-share.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit 4296f971de1f1661dad8a78dea504b6c6614fef6 Author: Jonathan Matthew Date: Thu Dec 24 23:47:27 2009 +1000 generic-player: set playlist formats correctly Somehow the test used to tell the playlist parser to ignore unsupported formats was backwards, so we were ignoring all supported formats. plugins/generic-player/rb-generic-player-source.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 568c06dba74678578402b02cc2d598b72f9fa66f Author: Jonathan Matthew Date: Thu Dec 24 23:43:45 2009 +1000 generic-player: don't crash during playlist construction Since we use the GObject 'constructed' method rather than 'constructor' in most places, the playlist base class isn't fully set up in the generic player playlist class constructor, so trying to load the playlist file there crashes. Now we load the playlist in rb_generic_player_playlist_source_new, after the object is fully constructed. .../rb-generic-player-playlist-source.c | 50 ++++++++----------- 1 files changed, 21 insertions(+), 29 deletions(-) commit 01ab44f01473476bf00336fac75e005a65873bab Author: Jonathan Matthew Date: Thu Dec 24 23:43:11 2009 +1000 mpid: read playlist formats from .is_audio_player override file lib/libmediaplayerid/mpid-util.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 476e10481a724261af7264c8f015a8277d7f07df Author: Mohamad Elrashidin Sajeli Date: Wed Dec 23 21:24:17 2009 +1000 im-status: add support for pidgin (bug #605023) plugins/im-status/im-status.rb-plugin.in | 2 +- plugins/im-status/im-status/__init__.py | 39 ++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletions(-) commit 697811bf0be7b6f40c8d1adf5dbd0b7b75416913 Author: Jorge González Date: Sun Dec 20 16:03:09 2009 +0100 Updated Spanish translation po/es.po | 33 +++++++++++++++++++++++---------- 1 files changed, 23 insertions(+), 10 deletions(-) commit 228fbdabc3d23005df7467928b3092165626efbf Author: Jonathan Matthew Date: Sun Dec 20 21:30:27 2009 +1000 Add man pages, originally from Debian packaging data/Makefile.am | 2 + data/rhythmbox-client.1 | 171 +++++++++++++++++++++++++++++++++++++++++++++++ data/rhythmbox.1 | 87 ++++++++++++++++++++++++ 3 files changed, 260 insertions(+), 0 deletions(-) commit 6e956c822b242d3d1d33bacdee74b61345d611e8 Author: Hardy Beltran Monasterios Date: Sun Sep 20 23:55:25 2009 -0400 Português Lyrics - grab lyrics from letras.terra.com.br Added a new site to grab lyrics in brazilian português. plugins/lyrics/lyrics/LyricsSites.py | 5 +- plugins/lyrics/lyrics/Makefile.am | 3 +- plugins/lyrics/lyrics/TerraParser.py | 110 ++++++++++++++++++++++++++++++++++ 3 files changed, 116 insertions(+), 2 deletions(-) commit 50e97163754ab7413a2b92c1c31d256a96901741 Author: Jonathan Matthew Date: Sun Dec 20 20:58:39 2009 +1000 lyrics: update the UI file for the previous change plugins/lyrics/lyrics-prefs.ui | 79 +++------------------------------------- 1 files changed, 5 insertions(+), 74 deletions(-) commit b587ef37b90191739ca6900af6a420114d46e178 Author: Jonathan Matthew Date: Sun Dec 20 20:41:23 2009 +1000 lyrics: use a single lyrics search site list Rather than having the list of sites in the UI file, in the configuration dialog code, and in the search code, now we have a single list that we use to do everything. Since the LyricWiki search doesn't work and shows no sign of ever working again, it has been removed from the list (bug #603876). plugins/lyrics/lyrics/LyricsConfigureDialog.py | 41 +++++++++++------------ plugins/lyrics/lyrics/LyricsParse.py | 39 ++++++++-------------- plugins/lyrics/lyrics/LyricsSites.py | 39 ++++++++++++++++++++++ plugins/lyrics/lyrics/Makefile.am | 1 + po/POTFILES.in | 1 + 5 files changed, 75 insertions(+), 46 deletions(-) commit 3b9cb9ea380d1403249c2490293602c4ecb1c5d7 Author: Jonathan Matthew Date: Sun Dec 20 15:45:14 2009 +1000 source-header: reset state properly when there's no source (bug #605038) When there's no selected source (such as when showing visualization in the main window), none of the source header should be modifiable. Notably, the browser toggle remains visible since it's in the toolbar. shell/rb-source-header.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit ca1f516f8cfc2a879fbbd8c2c6bbdaadfb0b247c Author: Jorge González Date: Sat Dec 19 14:57:02 2009 +0100 Updated Spanish translation po/es.po | 1435 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 731 insertions(+), 704 deletions(-) commit 3408e2cbb6749f0aa17f578b46e594893be4b5d4 Author: Jonathan Matthew Date: Wed Dec 16 22:36:13 2009 +1000 add new media player source files to POTFILES.in po/POTFILES.in | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 8254aa18f801035498e61ff7dc40c7aebc1be2a4 Author: Jonathan Matthew Date: Mon Dec 14 08:45:31 2009 +1000 ipod: use media player source base class plugins/ipod/ipod-info.ui | 657 ++++++++++++++++------------------------- plugins/ipod/rb-ipod-plugin.c | 6 +- plugins/ipod/rb-ipod-source.c | 249 +++++++++++----- plugins/ipod/rb-ipod-source.h | 12 +- 4 files changed, 440 insertions(+), 484 deletions(-) commit 00902b309f172101895b986c43d79cbc9f1f936f Author: Jonathan Matthew Date: Sun Dec 13 11:37:06 2009 +1000 mtp: use media player source base class The main tricky thing here is that we track the amount of free space on the device, rather than asking it when creating the properties dialog. To do this, we add a new action type to the MTP thread that just calls a specified function on the device handler thread. After any track transfer or delete action, we add a callback to update our idea of the amount of free space on the device. plugins/mtpdevice/Makefile.am | 6 +- plugins/mtpdevice/mtp-info.ui | 222 +++++++++++++++++++++++++++++++++++++ plugins/mtpdevice/mtp-ui.xml | 1 + plugins/mtpdevice/rb-mtp-plugin.c | 21 +++- plugins/mtpdevice/rb-mtp-source.c | 191 ++++++++++++++++++++++++++++++-- plugins/mtpdevice/rb-mtp-source.h | 15 ++- plugins/mtpdevice/rb-mtp-thread.c | 22 ++++ plugins/mtpdevice/rb-mtp-thread.h | 7 +- 8 files changed, 465 insertions(+), 20 deletions(-) commit 980cb9338a6e80be2991aa3e00b834b16c1ee0cf Author: Jonathan Matthew Date: Sun Dec 13 11:29:00 2009 +1000 Add base class for media player sources For now, this only has some code for setting up a common properties dialog, but this is where library/playlist/podcast sync will be implemented. data/ui/Makefile.am | 1 + data/ui/media-player-properties.ui | 140 ++++++++++++++++++++++ sources/Makefile.am | 2 + sources/rb-media-player-source.c | 231 ++++++++++++++++++++++++++++++++++++ sources/rb-media-player-source.h | 74 ++++++++++++ 5 files changed, 448 insertions(+), 0 deletions(-) commit 53f7407546137c047c468ebc2d32f8b4cf8febe3 Author: Jonathan Matthew Date: Tue Dec 15 21:48:06 2009 +1000 python: add bindings for rb_shell_get_source_by_entry_type bindings/python/rb.defs | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) commit 5de6f070d02f5d87e2c1773509b08be30302348b Author: Jonathan Matthew Date: Mon Dec 14 21:23:39 2009 +1000 shell: use g_value_transform in setSongProperty dbus method This mostly means that the caller can use any numeric type for setting properties such as play count. Since dbus-glib doesn't map any dbus value type to G_TYPE_ULONG, it wasn't possible to set the play count, track number, disc number, or year previously. shell/rb-shell.c | 26 +++++++++++++++++--------- 1 files changed, 17 insertions(+), 9 deletions(-) commit dd6c8fe6163bd05c689f893c8c125bef4eb16881 Author: Jonathan Matthew Date: Sat Dec 12 11:11:44 2009 +1000 mpid: provide access to device serial numbers lib/libmediaplayerid/mediaplayerid.h | 1 + lib/libmediaplayerid/mpid-device.c | 11 +++++++++++ lib/libmediaplayerid/mpid-hal.c | 8 ++++++++ lib/libmediaplayerid/mpid-udev.c | 3 ++- 4 files changed, 22 insertions(+), 1 deletions(-) commit 226b230c86544846d11cbf7f9534c1d7064ad7eb Author: Bastien Nocera Date: Fri Dec 11 12:53:40 2009 +0000 [artdisplay] Fix run-time warnings .../artdisplay/artdisplay/LocalCoverArtSearch.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 56471f98771fe0ba78ec2d3541f45ad1be34805b Author: Bastien Nocera Date: Fri Dec 11 12:53:24 2009 +0000 [upnp] Fix run-time warnings plugins/coherence/upnp_coherence/__init__.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit 82e71765b04fe9003f4285d3d5e0970b539d99e5 Author: Bastien Nocera Date: Fri Dec 11 12:41:44 2009 +0000 Fix FTBS plugins/artdisplay/artdisplay/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit dab4f41554fe6af12379a3183445bd871df0f717 Author: Bastien Nocera Date: Fri Dec 11 12:35:52 2009 +0000 Fix compilation plugins/audiocd/sj-metadata-musicbrainz3.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 1dd71b5a5680e2f67b7554baff0f7fb430ffbe90 Author: Bastien Nocera Date: Fri Dec 11 01:51:53 2009 +0000 Remove mention of GIO implementations, it's the only one plugins/artdisplay/artdisplay/CoverArtDatabase.py | 5 +- .../artdisplay/artdisplay/LocalCoverArtSearch.py | 205 ++++++++++++++++++++ .../artdisplay/LocalCoverArtSearchGIO.py | 205 -------------------- plugins/rb/Loader.py | 18 +-- 4 files changed, 211 insertions(+), 222 deletions(-) commit e65be779b4d39161db212e54bc5892f5598c0487 Author: Bastien Nocera Date: Thu Dec 10 19:32:31 2009 +0000 Fix crasher when MusicBrainz can't read a disc But we can. https://bugzilla.redhat.com/show_bug.cgi?id=546188 plugins/audiocd/sj-metadata-musicbrainz3.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit a0ce3987f3cf29f765aea58719ad386e770c5ee7 Author: Bastien Nocera Date: Thu Dec 10 17:24:41 2009 +0000 Use g_atomic_int_* when possible to handle refcounts https://bugzilla.gnome.org/show_bug.cgi?id=604292 rhythmdb/rb-refstring.c | 6 +++--- rhythmdb/rhythmdb-property-model.c | 19 ++++++++++--------- 2 files changed, 13 insertions(+), 12 deletions(-) commit 5ea3040ffb3278cd0370120cc556bf4b51e8eae4 Author: Bastien Nocera Date: Thu Dec 10 17:06:28 2009 +0000 Remove obsolete support for old glib versions rhythmdb/rhythmdb-private.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) commit 3dce1f2b420f3fcb6709310cf4ed1787b37fa7a7 Author: Bastien Nocera Date: Thu Dec 10 16:17:22 2009 +0000 Remove gnome-vfs support in artdisplay plugin https://bugzilla.gnome.org/show_bug.cgi?id=604186 plugins/artdisplay/artdisplay/CoverArtDatabase.py | 10 +- .../artdisplay/artdisplay/LocalCoverArtSearch.py | 187 -------------------- plugins/artdisplay/artdisplay/Makefile.am | 1 - 3 files changed, 2 insertions(+), 196 deletions(-) commit 5578742367e1dc2a5774054164ae2f336dfe6e3f Author: Bastien Nocera Date: Thu Dec 10 16:16:56 2009 +0000 Require a new enough pygobject for GIO functions https://bugzilla.gnome.org/show_bug.cgi?id=604186 configure.ac | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 53f32ed3c2252f049094d8d2f5361ad8d1f2ed1e Author: Bastien Nocera Date: Thu Dec 10 16:16:22 2009 +0000 Remove gnome-vfs support in rb python bindings https://bugzilla.gnome.org/show_bug.cgi?id=604186 plugins/rb/Loader.py | 165 ++------------------------------------------------ 1 files changed, 5 insertions(+), 160 deletions(-) commit b289610d2f619c62b8608f068f4100e2f67de7e9 Author: Bastien Nocera Date: Wed Dec 9 16:02:39 2009 +0000 [artdisplay] Simplify save_pixbuf code https://bugzilla.gnome.org/show_bug.cgi?id=604189 .../artdisplay/LocalCoverArtSearchGIO.py | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) commit eeabdd5f7e3f38e396f1df1b38ce9051e22a5fd1 Author: Bastien Nocera Date: Wed Dec 9 16:02:13 2009 +0000 [upnp] Use GIO to get the face icon's mime-type https://bugzilla.gnome.org/show_bug.cgi?id=604188 plugins/coherence/upnp_coherence/__init__.py | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) commit 253c7aae20ba3a63da98a52b3785c6f79dcf416f Author: Jonathan Matthew Date: Mon Dec 7 20:14:49 2009 +1000 rhythmdb: don't use rhythmdb_add_timeout_commit for metadata changes (bug #603929) The problem with this is that we don't want these changes to be synced with the file, but if we call rhythmdb_commit for some other reason, such as hiding a file that is no longer present in the library directory, before the timeout expires, the changes will be committed with the sync_changes flag set to TRUE, so we'll end up writing the data back to the file. Other calls to rhythmdb_add_timeout_commit are safe, as they're made for entries that can't be synced (such as import errors or ignored files) or for changes that need to be synced. rhythmdb/rhythmdb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 32daf755e5a95a43bc112f55d4ea66037e3e9cc5 Author: Jonathan Matthew Date: Sun Dec 6 12:10:54 2009 +1000 removable-media: fix compile error with GUdev 147+ Since device numbers are now always 64bit, we can't stuff them into pointers and use them as hash keys with g_direct_hash as pointers are only guaranteed to be at least 32 bits. Instead, we need to allocate and store a new copy of the device number and use uint64_hash/uint64_equal. shell/rb-removable-media-manager.c | 29 ++++++++++++++++++++++------- 1 files changed, 22 insertions(+), 7 deletions(-) commit 1d264d8f60648d4157805613579ad8d52a118804 Author: Jonathan Matthew Date: Sat Dec 5 16:29:08 2009 +1000 Add magic to support selected-source actions Actions that operate on the current selected source are pretty common, and so we had a pretty common pattern where a signal handler would go and find the selected source from the shell, check it was the right type, and then unref the source before returning. This moves all of that (except the type check) into a GClosure wrapper, simplifying the signal handler code. plugins/audiocd/rb-audiocd-source.c | 33 +++-- plugins/daap/rb-daap-plugin.c | 35 +++--- plugins/generic-player/rb-generic-player-plugin.c | 70 ++++------ plugins/ipod/rb-ipod-plugin.c | 124 +++++------------- plugins/mtpdevice/rb-mtp-plugin.c | 53 ++------ shell/rb-shell.c | 1 + sources/rb-browser-source.c | 77 ++++------- sources/rb-source.c | 147 +++++++++++++++++---- sources/rb-source.h | 15 ++- 9 files changed, 276 insertions(+), 279 deletions(-) commit 384935909df28495754ed0561b865d303364c131 Author: Jonathan Matthew Date: Sat Dec 5 15:21:58 2009 +1000 rhythmdb: don't overwrite metadata for existing entries of different types This was probably messing up podcast episodes by setting properties from the file tags (which may be correct, or they may be nonexistant or junk) when newly downloaded files are picked up by the library monitor. rhythmdb/rhythmdb.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 0843ea038b8a1a7be6874a7a96166b3c04d07bae Author: Jonathan Matthew Date: Fri Dec 4 21:18:45 2009 +1000 Increase required GTK+ version to 2.14.0 The main effect of this is the removal of the last vestiges of libgnome/libgnomeui. INSTALL.quick | 15 ++++----- configure.ac | 8 +--- plugins/daap/rb-daap-source.c | 70 ----------------------------------------- shell/rb-shell-preferences.c | 8 ----- shell/rb-shell.c | 13 ------- 5 files changed, 9 insertions(+), 105 deletions(-) commit df722b23b1779992f2377dc0390c079d979e65d6 Author: Jonathan Matthew Date: Fri Dec 4 20:58:47 2009 +1000 remove arch-tag lines from source files arch was three version control systems ago, yet I still see these showing up in new files. INSTALL.quick | 1 - INTERNALS | 1 - Makefile.am | 2 -- README | 1 - backends/Makefile.am | 2 -- backends/gstreamer/Makefile.am | 2 -- backends/gstreamer/rb-encoder-gst.c | 2 -- backends/gstreamer/rb-encoder-gst.h | 2 -- backends/rb-encoder.h | 2 -- backends/rb-player-gst-data-tee.h | 3 --- backends/rb-player-gst-filter.h | 3 --- backends/rb-player-gst-tee.h | 3 --- backends/rb-player.h | 2 -- configure.ac | 2 -- help/C/Makefile.am | 2 -- help/C/fdl-appendix.xml | 1 - help/C/legal.xml | 3 --- help/Makefile.am | 2 -- lib/eel-gconf-extensions.c | 3 +-- lib/eel-gconf-extensions.h | 3 +-- lib/rb-cut-and-paste-code.c | 2 -- lib/rb-cut-and-paste-code.h | 2 -- lib/rb-debug.c | 2 -- lib/rb-debug.h | 2 -- lib/rb-file-helpers.c | 2 -- lib/rb-file-helpers.h | 2 -- lib/rb-preferences.h | 2 -- lib/rb-stock-icons.c | 2 -- lib/rb-stock-icons.h | 2 -- lib/rb-util.c | 2 -- lib/rb-util.h | 2 -- metadata/Makefile.am | 2 -- metadata/rb-metadata-common.c | 2 -- metadata/rb-metadata-gst.c | 2 -- metadata/rb-metadata.h | 2 -- plugins/audiocd/rb-audiocd-source.c | 2 -- plugins/audiocd/rb-audiocd-source.h | 2 -- plugins/audioscrobbler/rb-audioscrobbler.c | 2 -- plugins/audioscrobbler/rb-audioscrobbler.h | 2 -- plugins/audioscrobbler/rb-lastfm-source.c | 2 -- plugins/audioscrobbler/rb-lastfm-source.h | 2 -- plugins/cd-recorder/rb-playlist-source-recorder.c | 2 -- plugins/cd-recorder/rb-playlist-source-recorder.h | 2 -- plugins/cd-recorder/rb-recorder-gst.c | 2 -- plugins/cd-recorder/rb-recorder.h | 2 -- plugins/generic-player/rb-generic-player-source.c | 2 -- plugins/generic-player/rb-generic-player-source.h | 2 -- plugins/generic-player/rb-nokia770-source.c | 2 -- plugins/generic-player/rb-nokia770-source.h | 2 -- plugins/generic-player/rb-psp-source.c | 2 -- plugins/generic-player/rb-psp-source.h | 2 -- plugins/ipod/rb-ipod-db.c | 2 -- plugins/ipod/rb-ipod-db.h | 2 -- plugins/ipod/rb-ipod-source.c | 2 -- plugins/ipod/rb-ipod-source.h | 2 -- plugins/iradio/rb-iradio-source.c | 2 -- plugins/iradio/rb-iradio-source.h | 2 -- plugins/iradio/rb-station-properties-dialog.c | 2 -- plugins/iradio/rb-station-properties-dialog.h | 2 -- plugins/mtpdevice/rb-mtp-source.c | 2 -- plugins/mtpdevice/rb-mtp-source.h | 2 -- plugins/status-icon/rb-tray-icon.c | 2 -- plugins/status-icon/rb-tray-icon.h | 2 -- podcast/Makefile.am | 2 -- podcast/rb-feed-podcast-properties-dialog.c | 2 -- podcast/rb-feed-podcast-properties-dialog.h | 2 -- podcast/rb-podcast-manager.c | 2 -- podcast/rb-podcast-manager.h | 2 -- podcast/rb-podcast-parse.c | 2 -- podcast/rb-podcast-parse.h | 2 -- podcast/rb-podcast-properties-dialog.c | 2 -- podcast/rb-podcast-properties-dialog.h | 2 -- remote/dbus/Makefile.am | 2 -- rhythmdb/DESIGN | 2 -- rhythmdb/Makefile.am | 2 -- rhythmdb/rb-refstring.c | 2 -- rhythmdb/rb-refstring.h | 2 -- rhythmdb/rhythmdb-private.h | 4 +--- rhythmdb/rhythmdb-property-model.c | 2 -- rhythmdb/rhythmdb-property-model.h | 2 -- rhythmdb/rhythmdb-query-model.c | 2 -- rhythmdb/rhythmdb-query-model.h | 2 -- rhythmdb/rhythmdb-query.c | 2 -- rhythmdb/rhythmdb-tree.c | 2 -- rhythmdb/rhythmdb-tree.h | 2 -- rhythmdb/rhythmdb.c | 2 -- rhythmdb/rhythmdb.h | 4 +--- shell/Makefile.am | 2 -- shell/main.c | 2 -- shell/rb-history.c | 2 -- shell/rb-history.h | 2 -- shell/rb-play-order-linear-loop.c | 2 -- shell/rb-play-order-linear-loop.h | 2 -- shell/rb-play-order-linear.c | 2 -- shell/rb-play-order-linear.h | 2 -- shell/rb-play-order-random-by-age-and-rating.c | 2 -- shell/rb-play-order-random-by-age-and-rating.h | 2 -- shell/rb-play-order-random-by-age.c | 2 -- shell/rb-play-order-random-by-age.h | 2 -- shell/rb-play-order-random-by-rating.c | 2 -- shell/rb-play-order-random-by-rating.h | 2 -- shell/rb-play-order-random-equal-weights.c | 2 -- shell/rb-play-order-random-equal-weights.h | 2 -- shell/rb-play-order-random.c | 2 -- shell/rb-play-order-random.h | 2 -- shell/rb-play-order-shuffle.c | 2 -- shell/rb-play-order-shuffle.h | 2 -- shell/rb-play-order.c | 2 -- shell/rb-play-order.h | 2 -- shell/rb-playlist-manager.c | 2 -- shell/rb-playlist-manager.h | 2 -- shell/rb-removable-media-manager.c | 2 -- shell/rb-removable-media-manager.h | 2 -- shell/rb-shell-clipboard.c | 2 -- shell/rb-shell-clipboard.h | 2 -- shell/rb-shell-player.c | 2 -- shell/rb-shell-player.h | 2 -- shell/rb-shell-preferences.c | 2 -- shell/rb-shell-preferences.h | 2 -- shell/rb-shell.c | 2 -- shell/rb-shell.h | 2 -- shell/rb-source-header.c | 2 -- shell/rb-source-header.h | 2 -- shell/rb-statusbar.c | 2 -- shell/rb-statusbar.h | 2 -- sources/rb-browser-source.c | 2 -- sources/rb-browser-source.h | 2 -- sources/rb-library-source.c | 2 -- sources/rb-library-source.h | 2 -- sources/rb-playlist-source.c | 2 -- sources/rb-playlist-source.h | 2 -- sources/rb-podcast-source.c | 2 -- sources/rb-podcast-source.h | 2 -- sources/rb-removable-media-source.c | 2 -- sources/rb-removable-media-source.h | 2 -- sources/rb-source.c | 2 -- sources/rb-source.h | 2 -- sources/rb-sourcelist-model.c | 2 -- sources/rb-sourcelist-model.h | 2 -- sources/rb-sourcelist.c | 2 -- sources/rb-sourcelist.h | 2 -- tests/Makefile.am | 1 - tests/test-rhythmdb-query.c | 2 -- tests/test-rhythmdb-tree-serialization.c | 2 -- tests/test-rhythmdb-view.c | 2 -- widgets/Makefile.am | 2 -- widgets/rb-cell-renderer-pixbuf.c | 2 -- widgets/rb-cell-renderer-pixbuf.h | 2 -- widgets/rb-cell-renderer-rating.c | 1 - widgets/rb-cell-renderer-rating.h | 2 -- widgets/rb-dialog.c | 2 -- widgets/rb-dialog.h | 2 -- widgets/rb-entry-view.c | 2 -- widgets/rb-entry-view.h | 2 -- widgets/rb-header.c | 2 -- widgets/rb-header.h | 2 -- widgets/rb-library-browser.c | 2 -- widgets/rb-library-browser.h | 2 -- widgets/rb-property-view.c | 2 -- widgets/rb-property-view.h | 2 -- widgets/rb-query-creator-private.h | 2 -- widgets/rb-query-creator-properties.c | 2 -- widgets/rb-query-creator.c | 2 -- widgets/rb-query-creator.h | 2 -- widgets/rb-rating-helper.c | 2 -- widgets/rb-rating-helper.h | 2 -- widgets/rb-rating.c | 2 -- widgets/rb-rating.h | 2 -- widgets/rb-search-entry.c | 2 -- widgets/rb-search-entry.h | 2 -- widgets/rb-song-info.c | 2 -- widgets/rb-song-info.h | 2 -- widgets/rb-uri-dialog.c | 2 -- widgets/rb-uri-dialog.h | 2 -- 174 files changed, 4 insertions(+), 348 deletions(-) commit cc142ec676253e48687ab72544af00350f84f4e6 Author: Jonathan Matthew Date: Fri Dec 4 20:55:03 2009 +1000 remove the thoroughly obsolete Japanese help translation help/ja/.arch-inventory | 2 - help/ja/Makefile.am | 37 -- help/ja/fdl-appendix.xml | 669 --------------------- help/ja/figures/rb-adv.png | Bin 20849 -> 0 bytes help/ja/figures/rb-basic.png | Bin 15922 -> 0 bytes help/ja/figures/rb-browser.png | Bin 74196 -> 0 bytes help/ja/figures/rb-context-menu.png | Bin 73111 -> 0 bytes help/ja/figures/rb-iradio-add.png | Bin 10053 -> 0 bytes help/ja/figures/rb-iradio.png | Bin 74721 -> 0 bytes help/ja/figures/rb-nextprev.png | Bin 1048 -> 0 bytes help/ja/figures/rb-notification-area-menu.png | Bin 16126 -> 0 bytes help/ja/figures/rb-notification-area.png | Bin 1750 -> 0 bytes help/ja/figures/rb-player.png | Bin 4443 -> 0 bytes help/ja/figures/rb-prefs-general.png | Bin 18919 -> 0 bytes help/ja/figures/rb-prefs-library.png | Bin 14591 -> 0 bytes help/ja/figures/rb-repeat.png | Bin 1983 -> 0 bytes help/ja/figures/rb-search.png | Bin 37842 -> 0 bytes help/ja/figures/rb-shuffle.png | Bin 2112 -> 0 bytes help/ja/figures/rb-sidebar.png | Bin 3951 -> 0 bytes help/ja/figures/rb-stats.png | Bin 62444 -> 0 bytes help/ja/figures/rb-volume-changer.png | Bin 4163 -> 0 bytes help/ja/figures/rb-window.png | Bin 80103 -> 0 bytes help/ja/legal.xml | 81 --- help/ja/quick-reference.xml | 263 --------- help/ja/rhythmbox-ja.omf | 35 -- help/ja/rhythmbox.xml | 227 ------- help/ja/user-guide.xml | 780 ------------------------- 27 files changed, 0 insertions(+), 2094 deletions(-) commit 46f6beef9f3cd5547eceaab42502d9224416f299 Author: Mario Blättermann Date: Wed Dec 2 19:49:11 2009 +0100 Updated German translation po/de.po | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) commit 5b1ea3cff96e9e1265c59fada78fe8daddffbd34 Author: Mario Blättermann Date: Wed Dec 2 19:34:39 2009 +0100 Updated German translation po/de.po | 54 +++++++++++++++++++++++++++--------------------------- 1 files changed, 27 insertions(+), 27 deletions(-) commit 512409fde7cb0c4920e0d728178a137ab5619f9e Author: Jonathan Matthew Date: Tue Dec 1 22:19:02 2009 +1000 rhythmdb: ignore hidden files while enumerating directories (bug #603444) rhythmdb/rhythmdb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 1a323a78118930bfbd84d3e37d73b3bf311c3b63 Author: Jorge González Date: Sun Nov 29 23:46:49 2009 +0100 Updated Spanish translation po/es.po | 157 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 79 insertions(+), 78 deletions(-) commit 9a982259f8c7b1e4733dac5fcbdd3c2560387637 Author: James Date: Sun Nov 29 22:31:05 2009 +1000 status-icon: handle forward and back mouse buttons (bug #316257) plugins/status-icon/rb-status-icon-plugin.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 569b350ba617936ff38f8f18502e87003e6464ab Author: Christian Kirbach Date: Sun Nov 29 13:27:39 2009 +0100 Updated German translation po/de.po | 337 +++++++++++++++++++++++++++++++------------------------------- 1 files changed, 170 insertions(+), 167 deletions(-) commit ad30cb76a1d430a16c897dd9feacaad3cc5eb5d9 Author: Christophe Fergeau Date: Sun Nov 29 11:46:46 2009 +0100 use proper g_print modifier for GUdevDeviceNumber (bug #603263) On 64 bit systems, compilation was failing because we were using %x to try to print what is a 64 bit value. Use G_GINT64_MODIFIER and cast the value to guint64 before printing it to be 100% everything is good. plugins/mtpdevice/rb-mtp-plugin.c | 4 ++-- shell/rb-removable-media-manager.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) commit e483e429693c925567817b6f2d823f403189915e Author: Jonathan Matthew Date: Sun Nov 29 18:30:56 2009 +1000 artdisplay: fix local cover art search for smb shares Two problems here: gvfs won't do async file enumeration unless the enumerator is created asynchronously, and the gvfs smb backend doesn't do standard::fast-content-type or access::can-read, so we switch to standard::content-type instead, and assume files are readable if access::can-read is missing. .../artdisplay/LocalCoverArtSearchGIO.py | 23 +++++++++++++++---- 1 files changed, 18 insertions(+), 5 deletions(-) commit b1eeacca434769fb6fa43ec748747083f4cc003a Author: Mika Wahlroos Date: Sun Nov 29 13:58:02 2009 +1000 context: encode album names received from last.fm in utf8 (bug #602679) urllib.quote expects a byte sequence, rather than a string, so it can't deal with unicode input. As a result, we need to encode parameter strings as UTF-8 first (as last.fm expects) before constructing URIs. plugins/context/context/AlbumTab.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 429ea56233ac01214710357f617947a0f02529ce Author: Jonathan Matthew Date: Sun Nov 29 13:55:54 2009 +1000 context: call it 'context pane' (not 'panel') everywhere plugins/context/Makefile.am | 2 +- plugins/context/context.rb-plugin.in | 2 +- plugins/context/context/ContextView.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) commit 46166b3a1b9129e8db1f5a7beef500acaa3467d0 Author: Jonathan Matthew Date: Sun Nov 29 13:15:05 2009 +1000 song-info: set tab label for the multiple song info dialog (bug #602015) data/ui/song-info-multiple.ui | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit 6ea949a6e4fa12db0a2a7ace06d81a64cab25fb6 Author: Jonathan Matthew Date: Sun Nov 29 08:18:59 2009 +1000 mpid: don't destroy HAL context twice (bug #603258) lib/libmediaplayerid/mpid-hal.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 2dd5fdc9060b9db8bcba6645c13eeee42dc16cad Author: Sebastien Bacher Date: Fri Nov 27 07:28:23 2009 +1000 don't use python's LOCALMODLIBS variable (bug #602739) configure.ac | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) commit e93fd2d7afe1411a5a60052a4adecd6a56db5b7b Author: Jonathan Matthew Date: Fri Nov 27 07:14:51 2009 +1000 context: use an idle handler for track changes (bug #602140) The playing-song-changed signal is sometimes emitted on a streaming thread. Calling into webkit on non-main threads causes it to crash pretty reliably, so we need to use an idle handler to process it on the main thread. plugins/context/context/ContextView.py | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) commit f47cd2e66fa9891cf78a6621034156992280de8e Author: Bastien Nocera Date: Wed Nov 25 18:01:12 2009 +0000 [audiocd] Update from sound-juicer 2.28.1 plugins/audiocd/sj-metadata-getter.c | 13 +++++-- plugins/audiocd/sj-metadata-getter.h | 2 +- plugins/audiocd/sj-metadata-gvfs.c | 21 ++++++++---- plugins/audiocd/sj-metadata-musicbrainz.c | 2 +- plugins/audiocd/sj-metadata-musicbrainz3.c | 51 ++++++++++++++++++++-------- 5 files changed, 62 insertions(+), 27 deletions(-) commit 860812d7586f54329ebfc9bef616f25e2f928f88 Author: Jonathan Matthew Date: Tue Nov 24 20:41:51 2009 +1000 song-info: rework location field (bug #602616) We need two separate paths here to deal with local file URIs and anything else. For local files, we extract the directory name, convert to utf8, then compare against the user's desktop directory. For other things, we find the parent URI and unescape that. Previously there was some inconsistency here that lead to strings being unescaped twice, and for strings containing '%'s, the second unescape call would return NULL, causing a crash later on. widgets/rb-song-info.c | 49 +++++++++++++++++++++++++++++++---------------- 1 files changed, 32 insertions(+), 17 deletions(-) commit d00f83758ec6fe42e31e0f313a3ead144be2528b Author: Mattias Põldaru Date: Sun Nov 22 19:29:10 2009 +0200 Updating Estonian translation po/et.po | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit c3708cfa816dce856d243d999ac78d22d8dc4d2e Author: Mattias Põldaru Date: Sun Nov 22 19:03:03 2009 +0200 Updating Estonian translation po/et.po | 21 +++++++++++++-------- 1 files changed, 13 insertions(+), 8 deletions(-) commit dcfda5a14fcdb36fc268931ef92bef42ee602f4a